From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E2CC1A1DF5 for ; Wed, 17 Aug 2016 07:04:01 -0700 (PDT) Received: by mail-io0-x235.google.com with SMTP id b62so136250445iod.3 for ; Wed, 17 Aug 2016 07:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bV0D8iIHakQxm5a+ln0/e7PAcMSYuuk5dlQZTFFvEVk=; b=LhWg/AygoWG4e4AflRfgZ+4sp2lqkbchD4U4Zodkfy/FIpzEiUdfWN/XWUCVlGy5B5 mm431oZJhmAqlOGBmvQdCPKaX04MdkLsbV2FTiVBi1uTj/4CmJxo2E7IGuQj3EpE6QB8 B+qgLEckKta2V64LelpcOCvyd4/316UJ7mI/0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bV0D8iIHakQxm5a+ln0/e7PAcMSYuuk5dlQZTFFvEVk=; b=J+rDzinT19KL8NKRpdqlA0alegeHy8CDgDMc/KHJ2QCxSAxNWoPa/b1oNIUvrYWe2+ LBraQCD58sxjrddwZW0Ozto0tXTwI7apTKpi2ohoF9VvV0620onFnUqH14s/mar+C5Vh Y8oEILdHqZSzxWdcYA1lvm+AyzCIDMXhcs/F8mDNg6fy3q66oZV/ptgZVo6YM3TFDB/l ZWF6Kp6ZbM7JVcNbhIKcvaclbVXsDojoR2RBH0TGkVgiD3un3U4thPSU+GmbEnb/sjE/ JRkkPJPCDSrvjc5Ja1/NsfWekwh33RfAZvYfC4LRpvlRZwDbyRdcGEcAgmnH9aCherNX B84Q== X-Gm-Message-State: AEkoouutowbQ/Kabz0zw4U6yuh8GdxSY9zPgrycIp3CwrGisafvt0A8kg2fVZhJvIkM953D9DJu9B+6gKusGgSoC X-Received: by 10.107.41.67 with SMTP id p64mr45377787iop.130.1471442640828; Wed, 17 Aug 2016 07:04:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Wed, 17 Aug 2016 07:04:00 -0700 (PDT) In-Reply-To: References: <1471441502-21873-1-git-send-email-leif.lindholm@linaro.org> <1471441502-21873-3-git-send-email-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Wed, 17 Aug 2016 16:04:00 +0200 Message-ID: To: Laszlo Ersek Cc: Leif Lindholm , edk2-devel-01 , Feng Tian , Star Zeng Subject: Re: [PATCH 2/2] ArmVirtPkg: enable EBC interpreter for AArch64 QEMU X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2016 14:04:01 -0000 Content-Type: text/plain; charset=UTF-8 On 17 August 2016 at 15:55, Laszlo Ersek wrote: > On 08/17/16 15:47, Ard Biesheuvel wrote: >> On 17 August 2016 at 15:45, Leif Lindholm wrote: >>> Since we now have EBC support for AArch64, enable it by default >>> on the QEMU platform. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Leif Lindholm >>> --- >>> ArmVirtPkg/ArmVirtQemu.dsc | 1 + >>> ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +++++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >>> index 9f88786..fb851e7 100644 >>> --- a/ArmVirtPkg/ArmVirtQemu.dsc >>> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >>> @@ -401,3 +401,4 @@ [Components.AARCH64] >>> >>> NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >>> } >>> + MdeModulePkg/Universal/EbcDxe/EbcDxe.inf >> >> Please add it to ArmVirtPkg/ArmVirtQemuKernel.dsc as well: >> ArmVirtQemuFvMain.fdf.inc is shared between them. >> >> With that, >> >> Reviewed-by: Ard Biesheuvel > > Any reason for not adding it to the Xen platform as well? > > What kind of modules do we expect to come in EBC? Option ROMs perhaps? Yes, that is the primary purpose, although any DXE/UEFI driver could be distributed as an EBC module, I suppose (and we have an EBC version of fat.efi in FatBinPkg) > In that case, Xen may indeed be irrelevant here (I have no clue about > adding oproms to emulated or assigned devices under Xen, so I can't make > an argument either way.) If we expect general stuff (for example, even > UEFI_APPLICATION modules) to arrive in EBC, then I think Xen would be a > justified addition. > I remember reading somewhere that EBC was strictly for drivers, not applications, but I cannot find a reference anymore in the spec. I wouldn't mind adding it to Xen, but I don't see the point tbh Thanks, Ard.