From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4635D81F4E for ; Fri, 9 Dec 2016 06:50:54 -0800 (PST) Received: by mail-io0-x229.google.com with SMTP id p42so63226107ioo.1 for ; Fri, 09 Dec 2016 06:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1ulmt0V/tREehDwAHCDwgLVQPhd/KoWKMeZU8Uqvi4g=; b=OVehktNJS5Xx4b3SGu0HoHEjAlyCeIpuXu/7U694kmVwbylxVTxB+aHxteutBxzecW vl9XEjbM2LIYrcA/v8xhnZiV1OE4d4GRhFk8JBE8J1hZqMrKXloCQ6c4K99Hudc73rcz dHlLzEuzYgT4HitjdOK9rPP72aUb9snGy362c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1ulmt0V/tREehDwAHCDwgLVQPhd/KoWKMeZU8Uqvi4g=; b=K0xs7eNA+Dg0smwkEgn3mcLStKBgH3N221F5R/4C8b3X0awZU8mpr+V/xKOMMHZaaW 9MB9gervFvc6uIMAhyhnx47JJEh2VrQhPs+iKc1jTUImVXnuJ+V98qMlVX9tT7hlBg71 LF70VJhyZ57xOm1LwxNw7KdVHXOkBoOuIznDmnOZBSba4miQYKLEno1TMR6vTIo1nUea K+6g+AoVmcGm7yPyA5PPV2CL0aMobVaX5jk8+CwwXk5exNEc0+ZXdPJWo1DbZ2+LIYwO ML55P/b6k75fNdvMxtWx5bTN57UMykOpr4s+Z9JSAQowbfAANWS1pk5nFBFUsoQjetJw 6Syg== X-Gm-Message-State: AKaTC00BckSmDMff7C3H5Mxh1jLtxzr8ipEAFCES3A3+mNRtcnhxSbJQSOFfmxJDyUu35XFM8HPe+Yr5VjQ56tZ4 X-Received: by 10.107.18.39 with SMTP id a39mr63455452ioj.45.1481295053486; Fri, 09 Dec 2016 06:50:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.198.67 with HTTP; Fri, 9 Dec 2016 06:50:53 -0800 (PST) In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB39678AD9@shsmsx102.ccr.corp.intel.com> References: <1481185042-23873-1-git-send-email-ard.biesheuvel@linaro.org> <3C0D5C461C9E904E8F62152F6274C0BB39678AD9@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Fri, 9 Dec 2016 14:50:53 +0000 Message-ID: To: "Bi, Dandan" , "Ni, Ruiyu" Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Dec 2016 14:50:54 -0000 Content-Type: text/plain; charset=UTF-8 On 8 December 2016 at 09:25, Bi, Dandan wrote: > Reviewed-by: Dandan Bi > Given that this patch fixes build issues reported by Ruiyi, I am going to assume Dandan's Reviewed-by is sufficient, and merge this patch to master Thanks, Ard. > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Thursday, December 8, 2016 4:17 PM > To: edk2-devel@lists.01.org; Ni, Ruiyu > Cc: Ard Biesheuvel > Subject: [edk2] [PATCH] MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers > > Add missing EFIAPI modifiers to the functions that are exposed via the PCI I/O protocol. > > At the same time, add a missing UINT8 cast which breaks the build on Visual Studio. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > Apologies for the breakage. > > MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c | 21 +++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c > index 1e7244a129ae..56482e3353c0 100644 > --- a/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePciDeviceIo.c > +++ b/MdeModulePkg/Bus/Pci/NonDiscoverablePciDeviceDxe/NonDiscoverablePc > +++ iDeviceIo.c > @@ -43,7 +43,7 @@ GetBarResource ( > return EFI_NOT_FOUND; > } > > - BarIndex -= Dev->BarOffset; > + BarIndex -= (UINT8)Dev->BarOffset; > > for (Desc = Dev->Device->Resources; > Desc->Desc != ACPI_END_TAG_DESCRIPTOR; @@ -61,6 +61,7 @@ GetBarResource ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoPollMem ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -78,6 +79,7 @@ PciIoPollMem ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoPollIo ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -95,6 +97,7 @@ PciIoPollIo ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoMemRW ( > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > IN UINTN Count, > @@ -145,6 +148,7 @@ PciIoMemRW ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoMemRead ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -211,6 +215,7 @@ PciIoMemRead ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoMemWrite ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -277,6 +282,7 @@ PciIoMemWrite ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoIoRead ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -292,6 +298,7 @@ PciIoIoRead ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoIoWrite ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -307,6 +314,7 @@ PciIoIoWrite ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoPciRead ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -342,6 +350,7 @@ PciIoPciRead ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoPciWrite ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -369,6 +378,7 @@ PciIoPciWrite ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoCopyMem ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_WIDTH Width, > @@ -385,6 +395,7 @@ PciIoCopyMem ( > > STATIC > EFI_STATUS > +EFIAPI > CoherentPciIoMap ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_OPERATION Operation, > @@ -450,6 +461,7 @@ CoherentPciIoMap ( > > STATIC > EFI_STATUS > +EFIAPI > CoherentPciIoUnmap ( > IN EFI_PCI_IO_PROTOCOL *This, > IN VOID *Mapping > @@ -472,6 +484,7 @@ CoherentPciIoUnmap ( > > STATIC > EFI_STATUS > +EFIAPI > CoherentPciIoAllocateBuffer ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_ALLOCATE_TYPE Type, > @@ -513,6 +526,7 @@ CoherentPciIoAllocateBuffer ( > > STATIC > EFI_STATUS > +EFIAPI > CoherentPciIoFreeBuffer ( > IN EFI_PCI_IO_PROTOCOL *This, > IN UINTN Pages, > @@ -526,6 +540,7 @@ CoherentPciIoFreeBuffer ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoFlush ( > IN EFI_PCI_IO_PROTOCOL *This > ) > @@ -535,6 +550,7 @@ PciIoFlush ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoGetLocation ( > IN EFI_PCI_IO_PROTOCOL *This, > OUT UINTN *SegmentNumber, > @@ -560,6 +576,7 @@ PciIoGetLocation ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoAttributes ( > IN EFI_PCI_IO_PROTOCOL *This, > IN EFI_PCI_IO_PROTOCOL_ATTRIBUTE_OPERATION Operation, @@ -616,6 +633,7 @@ PciIoAttributes ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoGetBarAttributes ( > IN EFI_PCI_IO_PROTOCOL *This, > IN UINT8 BarIndex, > @@ -666,6 +684,7 @@ PciIoGetBarAttributes ( > > STATIC > EFI_STATUS > +EFIAPI > PciIoSetBarAttributes ( > IN EFI_PCI_IO_PROTOCOL *This, > IN UINT64 Attributes, > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel