From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web10.82.1576776375205121620 for ; Thu, 19 Dec 2019 09:26:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=uoskNNGR; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id w15so6831445wru.4 for ; Thu, 19 Dec 2019 09:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OXBSKag5MxOWFyGciKctkKOs1uFBZ6XpZAKUhy3YA78=; b=uoskNNGRZIjlHAjqKIHPyxGcivX3St8oGE4mLCNQP/hZvkQhyslr88fUJqFM1QA7TD 8t2EZdicO641ITT3lmZIwitxu8QJ6ryFh2pXXO1G+YMtsF/QS1+Ukc7X9fLGKB1phL9T 0Z87nJ7sz+ZdgGskfaL3t/SB1He9k1t/dZ1ZibbaDgJVmK46/wfQB+WIMsTZMPjPs9t4 hKgld/gF3rClH83ejLmMfcURrE6PCSO9ooJWnlgqBd6jJet/rhdG3pmOg0WnlhMXTVz+ /qt4UZ75wj7hQhKeF4iydYbfHVMuMPmblNayomUHkSCQoSpk6xRlVKfRagl82ZW/lfOF Gg3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OXBSKag5MxOWFyGciKctkKOs1uFBZ6XpZAKUhy3YA78=; b=Rw/OfMcm7uQoYo2ztkMEapqjCnpMxNqQ0TVkUszHbYsyeGDaYj1rGKycleXZI3vKlH w7DybUD9erRrcpyi0gzcuNEyiHxVwHr7harR4gL6lJACLLTJoa8VynJXgsCPGia7MFas SVSYeakrZqTfZJ7X/l5VDYS+GQFbnvVQ9qXr+mKVjZzIKCSzea97dkTAnBErrRgt5Whz AsNIXPYm1y4gAq7QW8ZOWwe6D5SKozcXxutnwFNzIkg7Fl+92GhbzlsfxiT7jQsxMwsp xi6lvKt4JRxqNPiwtOP5/Qnjn0J/9AnQ2aO5p75Fqg1ebdvliGc44hA2KE7AgmJsKVru 3Zgg== X-Gm-Message-State: APjAAAXAQG6SYGPp++8mo2n2SOA4WBJfyEDJxEYr4aydSxkvpJwiQbwH +rS64mZXPejGyFczu7ju5lksErgTCB7t4YU/xODXrQ== X-Google-Smtp-Source: APXvYqzS/1JegBomtx5t2DfPulnHue2y0C+W3Z8Snzpa/ZAKIpGmRe/IUljo/bnQLnD4RF/ZhbbOzALYQLOCPPwJ+SI= X-Received: by 2002:a5d:5345:: with SMTP id t5mr11144135wrv.0.1576776373608; Thu, 19 Dec 2019 09:26:13 -0800 (PST) MIME-Version: 1.0 References: <20191211170401.7336-1-pete@akeo.ie> <20191216151143.GJ7359@bivouac.eciton.net> In-Reply-To: <20191216151143.GJ7359@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Thu, 19 Dec 2019 17:26:07 +0000 Message-ID: Subject: Re: [edk2-platforms][PATCH 1/1] Platform/RPi: Inhibit serial output for all runtime drivers To: Leif Lindholm Cc: Pete Batard , edk2-devel-groups-io , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Mon, 16 Dec 2019 at 17:11, Leif Lindholm wrote: > > On Wed, Dec 11, 2019 at 17:04:01 +0000, Pete Batard wrote: > > From: Ard Biesheuvel > > Oops - sorry, I missed the From: - thanks for the poke. > > Yeah, I'm good with this change: > Reviewed-by: Leif Lindholm > Thanks Pushed as e9395c53ba2c..479821a9677c > > This is an improvement of e9db04631b63574b090aeab769cc47dcb75a29f7 > > where we inhibit serial output of MMIO mapped UARTs to all runtime > > drivers rather than just RTC, as other drivers may crash the OS > > just the same. > > > > Also add it to the Pi 4 platform where it was missing altogether. > > > > Signed-off-by: Pete Batard > > --- > > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++- > > Platform/RaspberryPi/RPi4/RPi4.dsc | 2 ++ > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > > index 945baa5021f8..2368b04f40a4 100644 > > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > > @@ -200,6 +200,8 @@ [LibraryClasses.common.UEFI_DRIVER] > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited > > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > > @@ -505,7 +507,6 @@ [Components.common] > > EmbeddedPkg/ResetRuntimeDxe/ResetRuntimeDxe.inf > > EmbeddedPkg/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf { > > > > - DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > RealTimeClockLib|EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf > > } > > EmbeddedPkg/MetronomeDxe/MetronomeDxe.inf > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > > index 3764d1b3d794..03139e57a8db 100644 > > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > > @@ -202,6 +202,8 @@ [LibraryClasses.common.UEFI_DRIVER] > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > + # Runtime debug messages may crash an OS unless serial output to MMIO mapped UARTs is inhibited > > + DebugLib|MdePkg/Library/DxeRuntimeDebugLibSerialPort/DxeRuntimeDebugLibSerialPort.inf > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > > -- > > 2.21.0.windows.1 > >