From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F1CCC2222C241 for ; Fri, 26 Jan 2018 09:30:08 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id 25so1196402ioj.9 for ; Fri, 26 Jan 2018 09:35:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vLWKe9NZCuANsj7uq9tLV3y98acbuV5IEJ+5mVcvj84=; b=YmgDkkxDjoymd75le6BG/KOm2ssbYbEVN5q+xGV2uzBr+Za+LscqiOaeKTvQdEYHGS 9fLACO23nhR9lB1xQSHzi5Cx8Bvo0fb0MRYw+mMbb75EX5eBHnIhxhJ5DWOXDfIfjaBD 0ZjG7sdDrJ0iioGDvJ8Ic7qUhl+2WgyzOgqmA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vLWKe9NZCuANsj7uq9tLV3y98acbuV5IEJ+5mVcvj84=; b=lubgyvFzC490bj3hGSG0/W9T4fbsz8Q2hoB/34VWu5kiaNUDHnhmeGLltRdi41pohF nUXbj0u6NvhK/cdt+Sp9On32r8q03iWAmyYFuRGaW407M0i9EuetBSdo8zYfG119mzPb 74wMO4JadtDQ3xTc6NgqloxIGWzgEwqHF6/2R+vH0m0mVGeNJiTIoWqttSJcm9343OO4 7qG06JC0AuQGQyWBpCJX2RIbJ1WcmEj7ZAENEhKoonxo985UqAicolzv0g22lIlqBb02 VzqUFKJvvIq0ssSoqRegKVpKBPdZaTjI5VeUWMR8WKDAYth3xvMclvLlF5T6UcNVvvEk RtBw== X-Gm-Message-State: AKwxyte36thpkypCjJn/uDNG3RxLXSbGKtWNRLSiNzLtdr5I//H6B/19 KqL157xMNyVjctDMegHl04pEQZ6ysxcd6w11DdGJZA== X-Google-Smtp-Source: AH8x225ea+cI/3xODu9aml7+Z4Ft9dfZiS5xM0YAuBODdqxEEiAF4cYjp7ZxuHr6ggIYYnBmk14EbZho0ztLJyjI9bA= X-Received: by 10.107.6.161 with SMTP id f33mr18117465ioi.196.1516988138603; Fri, 26 Jan 2018 09:35:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Fri, 26 Jan 2018 09:35:38 -0800 (PST) In-Reply-To: <20180126173445.kmtaktrnxq5j7hh7@bivouac.eciton.net> References: <20180126173006.17324-1-leif.lindholm@linaro.org> <20180126173445.kmtaktrnxq5j7hh7@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 26 Jan 2018 17:35:38 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] BeagleBoardPkg: reroute Firmware Vendor Pcd to MdeModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 17:30:09 -0000 Content-Type: text/plain; charset="UTF-8" On 26 January 2018 at 17:34, Leif Lindholm wrote: > On Fri, Jan 26, 2018 at 05:31:25PM +0000, Ard Biesheuvel wrote: >> On 26 January 2018 at 17:30, Leif Lindholm wrote: >> > Commit f9669f09fb53 ("ArmPlatformPkg: retire obsolete PCDs") got rid of >> > the unfortunate ARM-specific variant of PcdFirmwareVendor. >> > >> > However, BeagleBoard was still using it, so the change broke the build. >> > Fix this by moving BeagleBoard to use the MdeModulePkg one instead. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Leif Lindholm >> > --- >> > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc >> > index 5d87ee3891..cef2e095d4 100644 >> > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc >> > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc >> > @@ -262,7 +262,7 @@ [PcdsFeatureFlag.common] >> > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE >> > >> > [PcdsFixedAtBuild.common] >> > - gArmPlatformTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" >> > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor|"Beagle Board" >> >> That should probably be L"Beagle Board" > > Good point. > Happy with me folding that in? > Sure Reviewed-by: Ard Biesheuvel