From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com;
 envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org 
Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com
 [IPv6:2607:f8b0:4864:20::d44])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 720532119EF23
 for <edk2-devel@lists.01.org>; Tue, 18 Dec 2018 04:46:29 -0800 (PST)
Received: by mail-io1-xd44.google.com with SMTP id s22so12637366ioc.8
 for <edk2-devel@lists.01.org>; Tue, 18 Dec 2018 04:46:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=dTJNUIbWf0ZNmIZbfd7HF2bltBhHCIpVxtwW7nH2lQw=;
 b=gjBVhnP0OEqPm0IyRxtri/DLMs2Pl3kmVFa0KIS+Uh/otvdpTG/3NO1DLDn5ySvlbF
 7bZiFVAzhv/bcY6igyaieDv7rTLi2Zydv3+JE57eAChSv41x4L/eKxZd3DWagyjLPUmk
 MEvNy3pin0/ZIblGZ68TCmYvASOYaO9irHVkc=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=dTJNUIbWf0ZNmIZbfd7HF2bltBhHCIpVxtwW7nH2lQw=;
 b=eHigJ0/3jg+HT9hghUO2nBQipx/Gzu0quV7G2LtO5rwmRUBI6VkFRnsRtiQkqhVpqw
 XXvbZiDmnC5l8+5indNwSQLU+P3qR946rQCoxohxwXGSsgBOiUC2FU5sfMvMT6/6mUAw
 xfEhMP1B/Kb8yCWbR9n4se9735Ot+x0TUEGpYM/94yvS9ebPAvsvNC4ro/fOfih16l+G
 hZb3c6tnxo6OdZxn9UJWv4U3Zqi6SZ6o2F7O9YVm9GJ2uGfED2A6URs5A4jsC2wgB45y
 HFhjxt7c3aUc14R4hSWYzwiWrzjfuwBg7uhYctF2aUKC8+zcu6c2hkPKQ0zXIRSHWGjK
 Bwfw==
X-Gm-Message-State: AA+aEWaW8zhSNJVnaBsol8ymP+9DQU2vxsR0s4IQCe/B3MEU4te7rQeT
 +BghLVAoxMDYnvIRiGW+6m21MnzUKAdxGjJRnVtgFg==
X-Google-Smtp-Source: AFSGD/XbWdfcDs9jOy6zg6+lqAxmUmBTssO4PX7ktNxJWuzZ8H4OJXeHRVFhpCFr+f2TuOMz2hahTYCnPRgeUU/qoX8=
X-Received: by 2002:a5d:8415:: with SMTP id i21mr14339193ion.173.1545137187367; 
 Tue, 18 Dec 2018 04:46:27 -0800 (PST)
MIME-Version: 1.0
References: <1544514341-3176-1-git-send-email-sumit.garg@linaro.org>
 <CAKv+Gu-W-1xBq5M79cPdurSgdaKS5j8qz1rn2T2ge_CD5CpaQA@mail.gmail.com>
 <CAFA6WYOee3u1SsXQ+hL2=wCX4MdY8pLjvU7es=-8KoccUpS=iA@mail.gmail.com>
 <CAKv+Gu9T8H6+mu9sRAX+GNSVX5-dC7VRF0FpkmpB71hW0VDCOg@mail.gmail.com>
 <CAKv+Gu9f5UFQe4mcgrb5D4ytg7nTC0LxM+MmrJupRcVBXLT-Dg@mail.gmail.com>
 <CAFA6WYOa2HsuJK+UUSW9Jq4HZMdsS4E5Y9f0LfmtFFBNtsr1UA@mail.gmail.com>
 <CAFA6WYO2n0tX+utCf+zYA2B_Hi1sXh=FdEeDb+DxxV0R-w-7oQ@mail.gmail.com>
In-Reply-To: <CAFA6WYO2n0tX+utCf+zYA2B_Hi1sXh=FdEeDb+DxxV0R-w-7oQ@mail.gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Tue, 18 Dec 2018 13:46:16 +0100
Message-ID: <CAKv+Gu-skQtoSEVYKTMC_-c763cTyeQdyKuWrQsyWXEqA5usOA@mail.gmail.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Daniel Thompson <daniel.thompson@linaro.org>, 
 Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH edk2-platforms v1 1/1] Silicon/SynQuacer: add OP-TEE based RNG driver
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Dec 2018 12:46:29 -0000
Content-Type: text/plain; charset="UTF-8"

On Tue, 18 Dec 2018 at 13:17, Sumit Garg <sumit.garg@linaro.org> wrote:
>
> Hi Ard,
>
> On Wed, 12 Dec 2018 at 11:05, Sumit Garg <sumit.garg@linaro.org> wrote:
> >
> > On Tue, 11 Dec 2018 at 21:37, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > >
> > > On Tue, 11 Dec 2018 at 10:06, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > >
> > > > On Tue, 11 Dec 2018 at 10:04, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > >
> > > > > On Tue, 11 Dec 2018 at 13:56, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > > > >
> > > > > > On Tue, 11 Dec 2018 at 08:46, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > > > >
> > > > > > > This driver uses OpteeLib to interface with OP-TEE based RNG service
> > > > > > > (pseudo trusted application) to implement EFI_RNG_PROTOCOL that is used
> > > > > > > to seed kernel entropy pool.
> > > > > > >
> > > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > > > > >
> > > > > > Excellent! Happy to see this code going upstream.
> > > > > >
> > > > >
> > > > > Thanks Ard.
> > > > >
> > > > > > This code looks fine to me, but I'd like to test it with an updated
> > > > > > OP-TEE build first before I merge it.
> > > > > >
> > > > >
> > > > > Agree, will wait for OP-TEE PR to be merged. BTW, if you need I could
> > > > > share updated "fip_all_arm_tf.bin" using OP-TEE PR for testing.
> > > > >
> > > >
> > > > Yes please, that would be useful.
> > > >
> > > >
> > >
> > > OK, I successfully tested this patch on my SynQuacer box. Very nice work!
> > >
> >
> > Thanks Ard for testing this patch.
> >
> > > So this is ready to go in as soon as the OP-TEE side is merged as
> > > well, so please keep me informed about that (and contribute a new
> > > ARM-TF + OP-TEE build to edk2-non-osi)
> >
> > Sure will let you know about OP-TEE PR merge and yes will contribute a
> > new ARM-TF + OP-TEE build to edk2-non-osi.
> >
>
> OP-TEE PR [1] has been merged. Also I have sent a patch to contribute
> new ARM-TF + OP-TEE build. Please have a look.
>
> [1] https://github.com/OP-TEE/optee_os/pull/2564
>

Wonderful! Thanks a lot.