From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v2 8/8] ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition
Date: Tue, 18 Oct 2016 11:00:28 +0100 [thread overview]
Message-ID: <CAKv+Gu-u7iD6g+Kkoy2o3ZQOycO2JJnMQO8SNK+Fq2RDcK6jmA@mail.gmail.com> (raw)
In-Reply-To: <20161018084613.58420-9-ruiyu.ni@intel.com>
On 18 October 2016 at 09:46, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h b/ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h
> index 8599961..2708b53 100644
> --- a/ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h
> +++ b/ArmPlatformPkg/Library/ArmShellCmdRunAxf/ArmShellCmdRunAxf.h
> @@ -15,10 +15,8 @@
> #ifndef __ARM_SHELL_CMD_RUNAXF__
> #define __ARM_SHELL_CMD_RUNAXF__
>
> -#include <ShellBase.h>
> -
> -#include <Protocol/EfiShell.h>
> -#include <Protocol/EfiShellDynamicCommand.h>
> +#include <Protocol/Shell.h>
> +#include <Protocol/ShellDynamicCommand.h>
>
> #include <Library/HiiLib.h>
> #include <Library/ShellLib.h>
> --
> 2.9.0.windows.1
>
next prev parent reply other threads:[~2016-10-18 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 8:46 [PATCH v2 0/8] Move Shell protocols definition to MdePkg Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 1/8] ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 2/8] MdePkg: Include Shell/ShellDynamicCommand/ShellParameters definitions Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 3/8] ShellPkg: Update header files to reference MdePkg protocol definition Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 4/8] MdePkg: Merge ShellBase.h and remove Efi prefix from header files Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 5/8] ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 6/8] EmbeddedPkg/FdtPlatformDxe: " Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 7/8] ShellPkg: Update sources to include MdePkg protocol definitions Ruiyu Ni
2016-10-18 8:46 ` [PATCH v2 8/8] ArmPlatformPkg/ArmShellCmdRunAxf: Reference MdePkg protocol definition Ruiyu Ni
2016-10-18 10:00 ` Ard Biesheuvel [this message]
2016-10-18 14:53 ` [PATCH v2 0/8] Move Shell protocols definition to MdePkg Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-u7iD6g+Kkoy2o3ZQOycO2JJnMQO8SNK+Fq2RDcK6jmA@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox