From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8241321EB88EA for ; Fri, 1 Sep 2017 07:03:06 -0700 (PDT) Received: by mail-io0-x234.google.com with SMTP id i200so2003141ioa.1 for ; Fri, 01 Sep 2017 07:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6qmbALU435o/z1ckDKAoZoRMdTReuND54A0vGCNAslk=; b=G/fvTLDqVxbKRfRSxRdDmveJkgqU2NkR8DTm0/AVytd//e1IvFWxiKJj5xTIxbOO2q qeqtWFNozVVDfwET2cA0uGxsKairq69RTd3C8eu0O4W1tKRCYaIwd7WHMaqo75tkjvdd aDTa5PMYKuZLdx+NMAwU01QE21V+32gN7hbOM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6qmbALU435o/z1ckDKAoZoRMdTReuND54A0vGCNAslk=; b=TboDgDrY4wjG9cmDyqfSW8rISI59JyL9mwiFnNnHieL07kOhDMdkVtjNH69PB01FXd nUXlQGG+OcPz76F/7I2WOHm5orrjkOpXGcNdSYligMvIjeg+iQIKYdnONmwkXvhAzSi7 y1TWE8XYmaI+2h5FRPiG54pNgNuwzyf9BH/a3qklfZQllN9YdXqJNiUZvLwah8DlSjf9 Ey5F2BN2w9zRLD2TfoHO22+F3Hq5RmLzqwouuX0ZC576SFGuZo+jrhofP3xW7T8bmdx3 c2G/qR4oZsQTVsuKyW2TE7XxLjgZVX3oBx6KeUHTxfKLCChqHdXHn1wCrysc3vfhcZxJ sj6A== X-Gm-Message-State: AHPjjUj8Ph5jEwJpsww8ecJWfngJ75fncxggUHvx0tDJeRqtKabtOFLG +EQKDCxgQtklyNKH/BswYLtIcPnQxXPt X-Google-Smtp-Source: ADKCNb5zkFCUonckQodNh6VyYaWwtQ676EVk0GlsAodRXbVez1XM7VpC0QO13Adsrg1R+q6e6wWSVAV24kzXs9BQlHE= X-Received: by 10.107.131.153 with SMTP id n25mr1660270ioi.263.1504274750289; Fri, 01 Sep 2017 07:05:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 07:05:49 -0700 (PDT) In-Reply-To: <1504271303-1782-3-git-send-email-mw@semihalf.com> References: <1504271303-1782-1-git-send-email-mw@semihalf.com> <1504271303-1782-3-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 15:05:49 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Alexander Graf , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , =?UTF-8?Q?Piotr_Kr=C3=B3l?= Subject: Re: [platforms: PATCH 02/11] Drivers/Spi/MvSpiDxe: Log and return correct error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 14:03:06 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 1 September 2017 at 14:08, Marcin Wojtas wrote: > From: Piotr Kr=C3=B3l > > Make log information clear where it came from and return correct code to > be interpreted by caller. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Piotr Kr=C3=B3l > Signed-off-by: Marcin Wojtas > --- > Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Platform/Marvell/Drivers/Spi/MvSpiDxe.c b/Platform/Marvell/D= rivers/Spi/MvSpiDxe.c > index aab20fc..0872f61 100755 > --- a/Platform/Marvell/Drivers/Spi/MvSpiDxe.c > +++ b/Platform/Marvell/Drivers/Spi/MvSpiDxe.c > @@ -240,7 +240,8 @@ MvSpiTransfer ( > } > > if (Iterator >=3D SPI_TIMEOUT) { > - DEBUG ((DEBUG_ERROR, "Timeout\n")); > + DEBUG ((DEBUG_ERROR, "EfiSpiTransfer: Timeout\n")); Please don't use EFI prefixes for things that are not defined in the UEFI s= pec. Also, you may want to use %a here, and pass __FUNCTION__ as the argument.