From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5B7F42217CE37 for ; Wed, 6 Dec 2017 09:04:38 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id d16so7874010itj.1 for ; Wed, 06 Dec 2017 09:09:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zHPSA2wrqVf+Nv5AZ7NJSsvPpsgAZ8Bok50G5qmldQA=; b=T0x3zy7PA2ZLjbI1z+9je51B8ttFdm4OVHAYIxkXhgPT8lhwYY1dAtGLWS0WxZCzQ3 Z+dIPu69e8zZFGy6VxT9wnzEqffOBoDU1LWPXgai+V9BqeuoTS2QhniNDH6WrP1se0px EuG6P+HsHQZuhxWX787py0M78S0uXPJpEyTi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zHPSA2wrqVf+Nv5AZ7NJSsvPpsgAZ8Bok50G5qmldQA=; b=uB16SoHu5J5Q6uTnuDerM3rHSB5UcHevAfdxrYkVjNmb/r3mBOh5d+yhhwXPw7e8st D6hn+FqszPfa4ImmYi9Ei7IL/aRDfpnjqU7+U6FpAB1fIOcD2FOihxSyS4bEZz0a4LiH yGGuYtY2GYTFWpyaJ7ztHL6VGpwbziTk4HGca0nuZd617Fr1t5e6doGkf4oQlbem5dUJ gq33xpxKgE2myLPnOxsmfBnyNf5uQB1nOQo0I3RBXh8vTlD1bG/w3wOPO+m0E8xh5oD1 oS2v7B+arYJAMKZZIdE+qX5tOeON7xw9YusocMT2pbgV8KRC8X6XyckEwRASDuLJYEt6 rZuw== X-Gm-Message-State: AKGB3mJ9rgeIK2tKChQQhN3Bv7eS3M7yuko2WMtx2tbiPjWZqLzpCr4O 9vEN3yGuNe3iedzKuGmUYOT4Ci8y7RB5sow/gIBEFQ== X-Google-Smtp-Source: AGs4zMYt7rINVx9dnara+boCfjNQW3uc+Ey9BUM0rZV3PxHkD5ldM8gziBk9+402j0qv7CJTUeqBNPVaX/bCayx70uQ= X-Received: by 10.36.78.212 with SMTP id r203mr14832369ita.58.1512580149913; Wed, 06 Dec 2017 09:09:09 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Wed, 6 Dec 2017 09:09:09 -0800 (PST) In-Reply-To: <20171206170745.8705-1-leif.lindholm@linaro.org> References: <20171206170745.8705-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Wed, 6 Dec 2017 17:09:09 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Michael D Kinney , Liming Gao Subject: Re: [PATCH] MdePkg: Arm/AArch64 - filter #pragma pack() when __ASSEMBLER__ X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 17:04:38 -0000 Content-Type: text/plain; charset="UTF-8" On 6 December 2017 at 17:07, Leif Lindholm wrote: > clang, when used as a preprocessor for dtc, does not discard #pragma > statements although -x assembler-with-cpp is specified. This causes dtc > to barf at a #pragma pack() statement that is already filtered out for > __GNUC__. So add a check to also filter this out if __ASSEMBLER__. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > MdePkg/Include/AArch64/ProcessorBind.h | 2 +- > MdePkg/Include/Arm/ProcessorBind.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdePkg/Include/AArch64/ProcessorBind.h b/MdePkg/Include/AArch64/ProcessorBind.h > index 775e7498c5..7b0f0ff32f 100644 > --- a/MdePkg/Include/AArch64/ProcessorBind.h > +++ b/MdePkg/Include/AArch64/ProcessorBind.h > @@ -26,7 +26,7 @@ > // > // Make sure we are using the correct packing rules per EFI specification > // > -#ifndef __GNUC__ > +#if !defined(__GNUC__) && !defined(__ASSEMBLER__) > #pragma pack() > #endif > > diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h > index dde1fd1152..42ea2f3055 100644 > --- a/MdePkg/Include/Arm/ProcessorBind.h > +++ b/MdePkg/Include/Arm/ProcessorBind.h > @@ -24,7 +24,7 @@ > // > // Make sure we are using the correct packing rules per EFI specification > // > -#ifndef __GNUC__ > +#if !defined(__GNUC__) && !defined(__ASSEMBLER__) > #pragma pack() > #endif > > -- > 2.11.0 >