From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BC55322436939 for ; Fri, 23 Feb 2018 06:04:13 -0800 (PST) Received: by mail-io0-x241.google.com with SMTP id t22so9927833iob.3 for ; Fri, 23 Feb 2018 06:10:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aojCJI/HNnPzmUOjjC7AK4rpnD4kMnwUPHzdPvHO1Y8=; b=SY9h2AYHskuxjS1jzSu4LAq5I8DPXjSv4L3HyQhzXNJnvbMAvADmiON0iFAxIsDEUX Vg+wJm7BK3CTrcLSt5FLVJe3UBxiBcpyqi55oHL8MI+cJjrCvnQSF7VrtmkwauMc18kg rsT4TAClvJESWAmy1ZVG5o5eNRbfiDI12/hpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aojCJI/HNnPzmUOjjC7AK4rpnD4kMnwUPHzdPvHO1Y8=; b=idM8lDqhwzm6DLp9VR0tGX49F9Yf9/aYTEpZZ2gRiJrQn/Cp8hAar3n7Hf6f8ZgVqh KIndQczEHeaTgJBeF7vIdeT9cru6YQ0cZimAGx/ZK383OEzC5GW92otyOVQtuw2x3Ztq 1paZlJ/E3GJZowWJNqwZRfH6PYyxQtK9iAruiT8MZeI50fYc7ZtloYZXz+m9nFdgxqeI 4vKnJvfJswbQPqmSoAF9yqlC15oZICTqmvkPdJEUq12DwU1MSINUjLpBz66HvL47rdwA FoKrfvfN/Bw6zVs99y+9QjlXMiaTdLyy0tlEGAYFRCvvJudsiu+ZoQAhOcaSbKw3pndi hG3g== X-Gm-Message-State: APf1xPDiT/9k0ENb3oHr/34VDtUl3EmK/laoxdKeoxACUIIkPcBhOH/u cKearqUCj+qPZPVx+NUnrY9n/ZHxdtNwlsUV8RfkEsbH X-Google-Smtp-Source: AG47ELukdbO6moRr1QWp6TM1JZPvzByREMyYGAwuseWfs+ETgOdpv/okvppk4fX9cy0VK607c1rvnsnyChwRK4X853w= X-Received: by 10.107.5.199 with SMTP id 190mr1965703iof.107.1519395014239; Fri, 23 Feb 2018 06:10:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Fri, 23 Feb 2018 06:10:12 -0800 (PST) In-Reply-To: <20180222195700.7279-1-ard.biesheuvel@linaro.org> References: <20180222195700.7279-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Fri, 23 Feb 2018 14:10:12 +0000 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , Laszlo Ersek , "Gao, Liming" , "Kinney, Michael D" , afish@apple.com, "Zeng, Star" , Ruiyu Ni , Ard Biesheuvel Subject: Re: [PATCH v4 0/2] Create UART DebugLib implementation for runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Feb 2018 14:04:14 -0000 Content-Type: text/plain; charset="UTF-8" On 22 February 2018 at 19:56, Ard Biesheuvel wrote: > Commit 4bf95a9f361e ("MdeModulePkg/ResetSystemRuntimeDxe: Add more debug > message") broke the DEBUG build for systems using a MMIO mapped UART for > DEBUG output. In other words, it broke the build for all ARM and AARCH64 > systems, given that port I/O does not exist on those architectures. > > Instead of patching it up locally, let's fix this issue once and for all, > by creating a UART DebugLib implementation for DXE_RUNTIME_DRIVER modules > that does the right thing by default. > > v4: > - add Laszlo's R-b > - keep ASSERT() message in local buffer even it is not printed to the serial > port, to allow it to be accessed via the debugger > Mike, Given that all ARM and AARCH64 DEBUG builds are still broken, may we please have your R-b on this patch so we can proceed to start fixing things? Thanks, Ard.