From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 334F581EE9 for ; Thu, 24 Nov 2016 08:31:48 -0800 (PST) Received: by mail-io0-x22f.google.com with SMTP id j65so87090598iof.0 for ; Thu, 24 Nov 2016 08:31:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=knnxQhRbZVi+HFA9Fvj15K4GY9E8H6BanUzOhwk/5W0=; b=VjoBKn044z4ScsAekdT5LGh191SZOhy8brQoQCIEBjhKdPbVgxGMz19knua5HFQIDe U63iobXxrmd/X5q4ciiS0Xxv7GVCFH56Vo7q4UtZyWpF/sjzXljJ7vk8LXrq7ipFsKrM 5pxeMBzmGFqfczc0bCHzIcozdc7WdcICIsCTw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=knnxQhRbZVi+HFA9Fvj15K4GY9E8H6BanUzOhwk/5W0=; b=Gp1qYO1wfB4RDU5EKTis1DVhWC95QV30bX5dwhtJBSHUrrTUNRYHOUmXPNI7jQnx18 /Bm2R7sVeyZWUJOZ6k3VcSgtLQVknRmB/f970IB+xyJahVaPaHdaC0t4nK4toN2azqoI dyZgmUm1SH2W5EgtG7ivEPoiI24NtOV9Z1jR3W2rgM2G3qFfTlFYcap5C+YkzQJDaqBA AxHnOf2zJc0ujorIGlq9TujL+JwsRwesXHT+sIkI8w+3tLubk0MkV9rEr8QYfFcAmtD/ 5nnfvEvIlId/24RiK0NpTVVd+36ovQS/OvMsvDhjO0vjwz2GjdhJoFH0qfd3puV3JXyC HAxA== X-Gm-Message-State: AKaTC03iNdch/V6uOPc94lT8S7Tjd7xnW9VrYLK06lsDgd4wq+m+NRJ4GkzV8RgDi3R9FmRC85LBv5894+n+A5Bg X-Received: by 10.107.25.204 with SMTP id 195mr2716844ioz.138.1480005107381; Thu, 24 Nov 2016 08:31:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.59.147 with HTTP; Thu, 24 Nov 2016 08:31:47 -0800 (PST) In-Reply-To: <1479908184-9406-1-git-send-email-haojian.zhuang@linaro.org> References: <1479908184-9406-1-git-send-email-haojian.zhuang@linaro.org> From: Ard Biesheuvel Date: Thu, 24 Nov 2016 16:31:47 +0000 Message-ID: To: Haojian Zhuang Cc: Ryan Harkin , edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v8 0/4] enhance MMC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 16:31:48 -0000 Content-Type: text/plain; charset=UTF-8 On 23 November 2016 at 13:36, Haojian Zhuang wrote: > v8: > * Avoid to update revision number twice. > * Move IsMultiBlock() interface from patch #4 to #1. > * Replace 24MHz with 26MHz since 26MHz is specified by spec. > Hi all, I have pushed this series as follows: a28b9aef6769 EmbeddedPkg/Protocol/MmcHost: add new methods for I/O width and multiblock 1df2fe1433b2 ArmPlatformPkg/PL180MciDxe: update for identifying SD 752ae80514cc EmbeddedPkg/MmcDxe: invoke SetIos() protocol method to set speed and width e06253ba80d9 EmbeddedPkg/MmcDxe: set I/O speed and bus width in SD stack 339c6e905a15 EmbeddedPkg/MmcDxe: expand to support multiple blocks where the first patch contains all changes to the protocol definitions, and the second patch was pulled forward to maintain bisectability. Thanks a lot to Haojian for the hard work! Regards, Ard. > v7: > * Add revision checking. > > v6: > * Reformat the last 5 patches after 4 MMC patches of this series merged. > * Squash original #5 and #6 patches together. > * Fix according comments. > > v5: > * Remove patch on MediaId. > * Squash two PL180 patches together. > > v4: > * Fix PL180 hang in some cases. Since the proper variable length > isn't set for CMD6 & ACMD51. > > v3: > * Fix PL180 hang because of CMD6 & ACMD51 not supported. > > v2: > * Fix print error with missing parameter. > * Change CMD51 to ACMD51. > * Add the protection after CMD55 for SD. If there's no > response of CMD55, skip to send ACMD51. > > v1: > * Wait OCR busy bit free according to eMMC spec. > * Define ECSD structure. > * Add interface to set IO bus width and speed. > * Support to access multiple blocks. > > Haojian Zhuang (4): > MmcDxe: add interface in mmc host protocol > MmcDxe: set iospeed and bus width in SD stack > PL180: update for indentifying SD > MmcDxe: expand to support multiple blocks > > ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 29 ++- > EmbeddedPkg/Include/Protocol/MmcHost.h | 35 ++- > EmbeddedPkg/Universal/MmcDxe/Mmc.h | 25 ++ > EmbeddedPkg/Universal/MmcDxe/MmcBlockIo.c | 176 +++++++++----- > EmbeddedPkg/Universal/MmcDxe/MmcIdentification.c | 291 ++++++++++++++++++++++- > 5 files changed, 486 insertions(+), 70 deletions(-) > > -- > 2.7.4 >