From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by mx.groups.io with SMTP id smtpd.web09.15205.1583343907060308204
 for <devel@edk2.groups.io>;
 Wed, 04 Mar 2020 09:45:07 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=QTeH7Um7;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f68.google.com with SMTP id g83so2782674wme.1
        for <devel@edk2.groups.io>; Wed, 04 Mar 2020 09:45:06 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=oK79VaxIMtTK67gURNsQPRR/HfFHWvAqArxvsbNdVVM=;
        b=QTeH7Um7GNc5hLNfng2kTGFA8w1APYchEZKF1ou5fvx3hgxhGkcI5IHjPt3xcnsR/R
         5MnA/Ud0y/oMfnEqxKwO+H0hEdzeM4nEIjmo6jHAuJzm4Lh83aHYDaGuri3AI9va0qOs
         42QJym80N5gIKIrtJ4kJXlMcSiAO1hKvD05l8x/UdcuWdQVWqZoiSKGFPi5tMt3sQYEJ
         wWzVL6IRf3pADuz0r4+Fyc51SrhUNs1iFa8WUXKBpum5jGJ9xYEbGE5Yja9toNBqG/26
         mgVR19vcWpE/eVzxn17O9CKzQosS4/uC1R3UQ4ngIWG6OnlejXf5fUcYLulSjwQjTyzy
         t58w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=oK79VaxIMtTK67gURNsQPRR/HfFHWvAqArxvsbNdVVM=;
        b=aFJGCxRp/h231JhQTUaId3SPjRBADX3lfhxe7tlOdOSZoZOEZZP75pFySjcPUBxuCw
         lMDztHhNwb2S6sbH3uXyY/T/OIvnA4jWQ/21CT45ZuRkADib4ORzPqOY5jgjj+h8fiTD
         Q3rx3IiWMbhety9a4J5mIZlErviP0stJpKvXAADJwfbvAl5xpgn7/b8oZaZfvfdmh9l4
         vDZTNp99/oUsd0PFjPTF1799pQpGhuEnngn+0PMty0q97bhV3Gs8n2fqDR/PgKRaHeTL
         OmfDt8mH4bXlRHk0lula1ty69BnwDjEA0GrwmEkyimhxPvLN1rfM17dHiAnBgF1jsPsb
         wOww==
X-Gm-Message-State: ANhLgQ1HLxmBpyd992GgR+sswqGU7oumWoILzBcRQOFZ8UePXHutWCm1
	rcFUGf7ax+oxiCiGh6iMRNqFAXKSJDw5DVV4H17uXQ==
X-Google-Smtp-Source: ADFU+vs1nYrJZTiE+2NoIJBMZjOereKwy8rE/kDXTHT6FONtFWqEu9L5gZJk2DM/6FWqYF8ZaSTEFErtyILHiiwenrg=
X-Received: by 2002:a05:600c:da:: with SMTP id u26mr4537704wmm.40.1583343905625;
 Wed, 04 Mar 2020 09:45:05 -0800 (PST)
MIME-Version: 1.0
References: <20200226124103.17125-1-ard.biesheuvel@linaro.org>
 <20200302125744.GG23627@bivouac.eciton.net> <CAKv+Gu_Y7cUzOBVJPk0Z0ekM3aLT0YgtrMOEF4HerV9epnu1aQ@mail.gmail.com>
 <20200302131205.GJ23627@bivouac.eciton.net>
In-Reply-To: <20200302131205.GJ23627@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 4 Mar 2020 18:44:54 +0100
Message-ID: <CAKv+Gu-vsRv_iAvqzEdkxFe5SodCEwrAQ_FrUWC5sQiYKRhsMQ@mail.gmail.com>
Subject: Re: [PATCH 1/1] ArmPkg/MmCommunicationDxe: fix logic bug in DXE driver entrypoint
To: Leif Lindholm <leif@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, "Gao, Liming" <liming.gao@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 2 Mar 2020 at 14:12, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Mon, Mar 02, 2020 at 14:00:54 +0100, Ard Biesheuvel wrote:
> > On Mon, 2 Mar 2020 at 13:57, Leif Lindholm <leif@nuviainc.com> wrote:
> > >
> > > On Wed, Feb 26, 2020 at 13:41:03 +0100, Ard Biesheuvel wrote:
> > > > Commit 2fe25a74d6fee3c2 ("ArmPkg/MmCommunicationDxe: relay architected PI
> > > > events to MM context") update the ARM specific standalone MM client
> > > > driver to register for certain events in the entrypoint code, but did
> > > > so in a way that makes the entrypoint always return with an error.
> > > >
> > > > Instead, return EFI_SUCCESS if registering for those events succeeds,
> > > > and back out the registrations that did succeed if one fails, and
> > > > return an error.
> > > >
> > > > Fixes: 2fe25a74d6fee3c2 ("ArmPkg/MmCommunicationDxe: relay architected PI events to MM context")
> > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >
> > > Reviewed-by: Leif Lindholm <leif@nuviainc.com>
> > >
> >
> > Thanks.
> >
> > > Are you looking for this one to make the stable tag? You're not
> > > explicitly asking for it, but you're cc:ing Liming.
> > >
> >
> > I don't think it is terribly useful to get this into the stable tag,
> > given that the standalone MM support is not complete yet, and stalled
> > on a PI spec update.
> > But by the same reasoning, it could go in as well, since it is an
> > obvious bugfix, and the risk is low.
> >
> > I don't really care either way tbh, I just wanted to make Liming aware of it.
>
> Thanks for explanation.
> I'd say leave it then - if tag gets pushed Wednesday as I think the
> current plan is, you can push it then.
>

Pushed as 3be909099cf66f26a5ace282e4cbbdc6bf7cb32b

Thanks