From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AB7D9210D2102 for ; Fri, 22 Jun 2018 07:08:11 -0700 (PDT) Received: by mail-it0-x241.google.com with SMTP id l6-v6so3066460iti.2 for ; Fri, 22 Jun 2018 07:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zy9ZJhtgPh9RtitbJj9oDcHoeaAcmTsoJrWgevNCMbE=; b=fFk0wMiIWeOqfSuCe9FqcLEmQSaoxeE8uO1PxoL4NYH3yoXVZRgHWwz/vZIZlsAc+i zsiJ7vZWg6TeZtYn4DSp5bPK2K73fqzXhZOF0Qelz7T2LIOu+zvfAzKdEpjAYCzCCTM4 VFBhzJBCaKtdpdk9RmneOZJj+Vvxl6PlZqtIQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zy9ZJhtgPh9RtitbJj9oDcHoeaAcmTsoJrWgevNCMbE=; b=ILE1AuJrjZ6MVyEYyTk+fEgm560j39UaCzZ+zW4uBMH1Hl+Na9cRCTHAbUcrL16tqn 1jqK2Q5m6B70Txaf4eMkKgrAtRN2ohpnc/p5xYV6KuPP4IF9Hg5OXKSgWIG7PsmJSjF6 e+8200KATxZ7tf/GecZjTUkREXgH05MlUhM4pESy7BK8VZ9ALhufYEnk1ZinbuUeClEj epTctOCOcxhwRmNTX7mox/XBvwX7GLFMM12OoMKyYfBqpV8VWtlDsTjf8ieFiVJJ42+l WeZTML6EPZbeRvGshM6rDMRw9l8HxN5NB8HHuq1EfoIHq5Z8vFicsTW/K8L4S2YLEAek cQNw== X-Gm-Message-State: APt69E2quyfOWmHRlt7zy1iURM05slg4qusmDy+9fG2q/ksWf7Qlbwhb xbc54ViNNkah/Y3y/aneIDEec15Dir8V/Sg7nDd2Gg== X-Google-Smtp-Source: ADUXVKJ2sLs7jYu7Gvvv8EORcK+musckpMzTbQpBSEPxWQnWO8uIpCHxVswjIeV2CtMwMzI6p16XvpvXmdbrD6CUuwc= X-Received: by 2002:a24:3105:: with SMTP id y5-v6mr1686113ity.138.1529676490203; Fri, 22 Jun 2018 07:08:10 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Fri, 22 Jun 2018 07:08:09 -0700 (PDT) In-Reply-To: <20180622125801.GA2437@iwish> References: <20180328010531.GA69547@SZX1000114654> <20180329002050.GB97590@SZX1000114654> <20180331013747.GA106704@SZX1000114654> <20180413020553.GB119834@SZX1000114654> <20180416135709.GA122959@SZX1000114654> <20180417012044.GA123329@SZX1000114654> <20180622125801.GA2437@iwish> From: Ard Biesheuvel Date: Fri, 22 Jun 2018 16:08:09 +0200 Message-ID: To: gary guo Cc: Leif Lindholm , "edk2-devel@lists.01.org" , Michael D Kinney , Haojian Zhuang Subject: Re: [PATCH edk2-platforms 00/12] Hisilicon/D0x: Switch to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jun 2018 14:08:11 -0000 Content-Type: text/plain; charset="UTF-8" On 22 June 2018 at 14:58, gary guo wrote: > Sure. A little busy these days; I'll do that ASAP. > No worries. BTW I noticed that we still have a problem with option ROMs when using the new MMIO translation code. Did you look into that at all? > On Thu, Jun 07, 2018 at 01:11:59PM +0200, Ard Biesheuvel wrote: >> On 17 April 2018 at 03:20, Guo Heyi wrote: >> > Hi Ard, >> > >> > I tested mm -io on D05, for root bridge 4 with CPU IO address starting from >> > 0x8_abff0000, and it worked; both mm -io 0x8abff0000 and mm 0x8abff0000 provided >> > the same output. It seems there is no other limit for 64bit IO address after you >> > fixed the issue in EFI shell mm command. >> > >> >> OK, so I think this is fine after all, even if my uneasy feeling >> hasn't gone away :-) >> >> Could you please resend the latest rebased version of the patches? >> (and include the ATU fix as well) >> >> >> > On Mon, Apr 16, 2018 at 09:57:09PM +0800, Guo Heyi wrote: >> >> Thanks, I will test mm command and let you know the result. >> >> >> >> Regards, >> >> >> >> Heyi >> >> >> >> On Fri, Apr 13, 2018 at 09:19:53AM +0200, Ard Biesheuvel wrote: >> >> > On 13 April 2018 at 04:05, Guo Heyi wrote: >> >> > > Hi Ard, >> >> > > >> >> > > Any comments? >> >> > > >> >> > >> >> > Apologies for the delay. I have been travelling and am behind on email. >> >> > >> >> > > Anyway we can modify the code if you insist on using an intermediate CPU IO >> >> > > address space. >> >> > > >> >> > >> >> > I have not made up my mind yet, to be honest. I agree there is a >> >> > certain elegance to merging both translations, but I am concerned that >> >> > existing EDK2 code may deal poorly with I/O addresses that require >> >> > more than 32 bits to express. >> >> > >> >> > Did you try the mm command in the shell for instance? As you know, I >> >> > recently removed an artificial address range limit there, but I wonder >> >> > if it uses 64-bit variables for I/O ports.