From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by mx.groups.io with SMTP id smtpd.web10.7350.1575966055030361477
 for <devel@edk2.groups.io>;
 Tue, 10 Dec 2019 00:20:55 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=lva4hzVU;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f65.google.com with SMTP id a15so18894964wrf.9
        for <devel@edk2.groups.io>; Tue, 10 Dec 2019 00:20:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=GF70Zw+aL7I5nsy0cno59dETgfMjEsKZ5RHlskACdxo=;
        b=lva4hzVURzMjPJGz4uzqcb2Zjx8SwzMflR6BB22tTR7TQ0Nv/3YTEIxK3TYE0+h6SV
         KrGqa8ORq9yqtbKP0RiyhXYXqRxBSzN202wZz7ArzQqQwZE1UOdGGVivgKttzThmj7jt
         PR3axUi48xh3LhGGeAZmx2huQ2aV2mDnqOSmWXKiVqmFcUcnyv96fMxoSEmFtal1nbrM
         eV42fOXzgktjprWaJZK9oRez161SvXxKvJzB2du49BdcViN1lJH1FD3KvChN3krQXxxO
         PEB10DTz/ZBKUH8sRBRLICqCYnNc9bsyjdeYhdf+JCUJe1amJh7XtibGvM7qUeO9NQf3
         6k6A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=GF70Zw+aL7I5nsy0cno59dETgfMjEsKZ5RHlskACdxo=;
        b=D9Y6zBL4FT5EePWweAa0hAZYJx8kGYn+AmAzHdbx7SKTMsFhX+0ZJ0R8B423qJc8rP
         Io+pyFp4ebImz7H/SL/uKD4WisiB+YqLTtd3owdLH0QTeN6xOkXAdKGpj6wQB454gHuM
         BHoFOZ8JIbztrp4SOEZiZ8Il/ix5QearMhXlLUmIJuowfNlgBDQILzijInj2eQPlzaew
         7Dbj7yFcZh0uqQ78qyWAlGKstdwK0z+BuNL1+M8NE9Ar1vEC+8ixKT5EnG+s0Ctiik3j
         6nbZoKZW+rX5MQ9W+wDOEZgmhIZWstiSpRA4BWuP1WoCrY/5Let2RhauccQhHtsB1U8d
         GVZw==
X-Gm-Message-State: APjAAAU/MwVSA7ibtkYlOB+zclvM+7XC4NCGecWIebK3ogMCMkwxKQgx
	DR6/LRS3CQfA0opC/6aDfqsokN6rSHPCCOg9XOSMaQ==
X-Google-Smtp-Source: APXvYqwDm7OI+0+BEmGZaRowOrJiecQCSmtqOkb/ZQafK+jRFzYfQ/NEp7ePIQsfzq/SxZtt+iaUDwfz44MvOMizaro=
X-Received: by 2002:a5d:43c7:: with SMTP id v7mr1602243wrr.32.1575966053477;
 Tue, 10 Dec 2019 00:20:53 -0800 (PST)
MIME-Version: 1.0
References: <20191129104716.819-1-ard.biesheuvel@linaro.org>
 <20191129112926.GA7359@bivouac.eciton.net> <CAKv+Gu-YcSQ0erMu51AH-G1PWO6aEk4C_0nJM43NmV408PzVTA@mail.gmail.com>
 <CAKv+Gu-2AE1hqegkt0d1unKQYFoSa+odFy0DtXftaa56Yxr+5Q@mail.gmail.com>
 <20191202120239.GB7359@bivouac.eciton.net> <CAKv+Gu-+phCw077XoJTGM2RiGP170tkoJ1etXrYk=jLgAK3Ymg@mail.gmail.com>
In-Reply-To: <CAKv+Gu-+phCw077XoJTGM2RiGP170tkoJ1etXrYk=jLgAK3Ymg@mail.gmail.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 10 Dec 2019 08:20:51 +0000
Message-ID: <CAKv+Gu-wZY9+TyY+XmLXiBDGABf-y1Ehapj9JJLkbsew9HYrBw@mail.gmail.com>
Subject: Re: [PATCH edk2-platforms 0/2] SynQuacer: expose OP-TEE in ACPI mode
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Content-Type: text/plain; charset="UTF-8"

On Mon, 2 Dec 2019 at 15:08, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Mon, 2 Dec 2019 at 13:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> >
> > On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote:
> > > On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > >
> > > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > > > >
> > > > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote:
> > > > > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in
> > > > > > the code in patch #2 to expose a SSDT with a device node describing
> > > > > > OP-TEE when booting in ACPI mode and OP-TEE is present.
> > > > >
> > > > > If we need any more SSDTs for this platform in future, I'll probably
> > > > > start grumbling about refactoring away the per-table global variables,
> > > > > but I guess it would be a bit overkill at this point...
> > > > >
> > > >
> > > > Yeah, the thought crossed my mind as well, but let's defer that to the
> > > > next time.
> > > >
> > > > > For the series:
> > > > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> > > > >
> > > >
> > >
> > > Actually, I need to apply this on top
> > >
> > > --- a/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> > > +++ b/Silicon/Socionext/SynQuacer/Drivers/PlatformDxe/PlatformDxe.c
> > > @@ -282,13 +282,16 @@ InstallAcpiTables (
> > >      return;
> > >    }
> > >
> > > +  if (mEmmcSsdtSize > 0) {
> > >      Status = AcpiTable->InstallAcpiTable (AcpiTable, mEmmcSsdt, mEmmcSsdtSize,
> > >                            &TableKey);
> >
> > Indentation presumably added for clarity?
> >
>
> Yep
>
> > >      if (EFI_ERROR (Status)) {
> > >        DEBUG ((DEBUG_WARN, "%a: failed to install SSDT table for eMMC - %r\n",
> > >          __FUNCTION__, Status));
> > >      }
> > > +  }
> > >
> > > +  if (mTos0SsdtSize > 0) {
> > >      Status = AcpiTable->InstallAcpiTable (AcpiTable, mTos0Ssdt, mTos0SsdtSize,
> > >                            &TableKey);
> > >      if (EFI_ERROR (Status)) {
> > > @@ -296,6 +299,7 @@ InstallAcpiTables (
> > >          __FUNCTION__, Status));
> > >      }
> > >    }
> > > +}
> >
> > LGTM.
> > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> >
>
> Thanks,
>


Pushed as 3688ab6500e2..c5a2065ee8c2