From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0090C21197079 for ; Mon, 10 Dec 2018 08:39:14 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id p197so19172931itp.0 for ; Mon, 10 Dec 2018 08:39:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nOecXqMM5HDtgbh2lrpc492sLuHXGdJlaVCQjpPYhJ4=; b=Uq8OtPUXuafBJumTAUk9Nzk7St1AXVK1EGw4bFTT2h+mquh4ZwjfRmJe3V0RyQVBpx katZTW9GT/bRpN5CiFbg7EaPmK0hj9opYz3VOmaPhaY9NVDCQ4QXyrmzHg36xDgUm48w FvMG0GpZTw8THXYVj24SA/wi1eVJJMkMONH0w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nOecXqMM5HDtgbh2lrpc492sLuHXGdJlaVCQjpPYhJ4=; b=tCnsdUQrMrh6IyKeVABzF+zlZdVLjr/Qp+O/V/YfnSKyeE6bNP2dxvwR9z1uplwctp hJ+9svQQXeHCDKQd8epZn23I2zgxikV9mFiEhtM/WflSqueEWDnY9pmg66TYRsQNkHCq 407SwmZMwBvlR8x3EtHANJxB0vSShTrYshJ3ax/5RiknwUD157lfn5YCHqdlL9e3oypp e63oXrF74zJ6Jf2zLu6h5zfUglJoY5NNwDwh9rHl+xAK4ulT/kQa/2xxqbswm910dyz0 NpLH6qJjXOIwO+fwe9VlHw+P0xGnFmJj2WMH/j9bmVmAf5qAk1M0BrUOSTIVIjRAZQEs WM5g== X-Gm-Message-State: AA+aEWbsDd101Fn+f+JWcImjdSg8TidL7p1ablwksIt16+77u8ICCpb6 YPhqfNG8QalFk0nT0E7r6U42w1kx51trwUOtl+wWpA== X-Google-Smtp-Source: AFSGD/XwHdWpbjRjYMEv3ECZY/RUCMFM8fEv7ywqH2JAc18/UthuT7KgAPululUFISuJ1/vHpXu5GOp6tQuYmI9ngDk= X-Received: by 2002:a24:edc4:: with SMTP id r187mr12770534ith.158.1544459954317; Mon, 10 Dec 2018 08:39:14 -0800 (PST) MIME-Version: 1.0 References: <20181122052153.89464-1-siyuan.fu@intel.com> <20181122052153.89464-2-siyuan.fu@intel.com> <6e29bd32-5d1c-17b3-dc70-de9cec0d781c@redhat.com> In-Reply-To: From: Ard Biesheuvel Date: Mon, 10 Dec 2018 17:39:01 +0100 Message-ID: To: Laszlo Ersek Cc: Siyuan Fu , "edk2-devel@lists.01.org" , "Ye, Ting" , "Wu, Jiaxin" , Leif Lindholm Subject: Re: [PATCH v2 1/6] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 16:39:15 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 10 Dec 2018 at 15:40, Laszlo Ersek wrote: > > Hi Ard, > > On 12/10/18 09:36, Ard Biesheuvel wrote: > > > Could anyone remind me why we have OpensslLib and OpensslLibCrypto? > > Since these are static libraries, only the referenced objects should > > be included in the final module anyway, so OpensslLibCrypto seems > > redundant to me. > > please see commit 823005621ef4 ("CryptoPkg/OpensslLib: introduce > OpensslLibCrypto instance", 2017-02-25). > Right, fair enough. > >> Namely, please *prepend* a patch to the series that simply deletes the > >> "[Components.IA32, Components.X64]" line, bringing all these drivers to > >> ARM/AARCH64, in the NetworkPkg.dsc build. Once we validate the new patch > >> separately (simply by test-building it), then the current patch can > >> simply replace the component list with the !include directive -- and > >> such a replacement won't incur arch-specific changes. > >> > > > > Ack > > Liming and I strongly disagreed on this point, and I yielded. Please see > the sub-thread that ended with the following comment: > > http://mid.mail-archive.com/e790855d-2cd9-1820-7187-0ec1dc52dabc@redhat.com > > (Alternative link: > .) > As long as we end up with a NetworkPkg.dsc that covers everything for all arches, I'm fine with whichever order we apply the changes.