From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B7A6321B00DC1 for ; Thu, 30 Nov 2017 01:31:41 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id f143so7736040itb.0 for ; Thu, 30 Nov 2017 01:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xX1heYI9qhAaLE2Ae6gkznEDCIzsuwKAAN6uDBeGvk0=; b=D5AuuUim9z6F/V12sbKs1huXJ/mAEbB0/VoOVjnggvrJvd8CIAI1EMzxNqlHOh3Zwl ZE5lKTwMyH0MocEAUhz/e5SVK3/jNeaNP47GQgu812/9N/vwLAzKqfq+Y4/5atDYbVV4 4qVHFJj/BpfKmmqupbEYJKvTcXxSYMdpMg/oA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xX1heYI9qhAaLE2Ae6gkznEDCIzsuwKAAN6uDBeGvk0=; b=MPxVlJhjfbereNrx1eCv/Ov6jhoU1s0Eibnn7MetOdqxk0LwyasFW0qLoUaCi31PsF Tb2PDIZ7oBXeTvafDVuhINIFyLHE0i/OMWTa8EGt4nGyC4QOh0p1uMjhp33Ctni/RPKy L/N/g+qfHNvzG1IH4M5FWtg9jvZk9fHmX6jGLwLtQpUySR1toWCyYndCZUoOWdcObZsK VPhEe/X9v4iVccvdaZ6OEyjSyVv3/RG9Ks0+WrcrAUIIyqUQRS3do1Ob2IBxB9AZSCIf 9SXpQhZImacBtlWi9riKRO/uyNehv/bZoo26CAVZ3ToqTOir3A8ZhOzx8hhx98dXMgWQ 129g== X-Gm-Message-State: AJaThX55Q74csJy92EaOfJ8rJrwGONWvUBB3YPS3mGlU6ekZlE6ZZHA7 nCNq4UsQTVNxpar3mv/aJCkCQlFVQGVNpjFjcQYspNkjtqE= X-Google-Smtp-Source: AGs4zMbETZHw1MM9cR9L8QK09K6VH0+n0uQ+gs40b9xk+rOkN3rUeWcljTwqKI6RgI3O84uP43YEw4k9nCTdPGrOaKk= X-Received: by 10.36.145.203 with SMTP id i194mr2281885ite.73.1512034565995; Thu, 30 Nov 2017 01:36:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Thu, 30 Nov 2017 01:36:05 -0800 (PST) In-Reply-To: <20171128201821.we2giq7yhtjynl3w@bivouac.eciton.net> References: <20171128173526.22413-1-ard.biesheuvel@linaro.org> <20171128201821.we2giq7yhtjynl3w@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 30 Nov 2017 09:36:05 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] Silicon/AMD Silicon/Hisilicon: remove -ArmGetCpuCountPerCluster() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 09:31:41 -0000 Content-Type: text/plain; charset="UTF-8" On 28 November 2017 at 20:18, Leif Lindholm wrote: > On Tue, Nov 28, 2017 at 05:35:26PM +0000, Ard Biesheuvel wrote: >> The function ArmGetCpuCountPerCluster () was moved out of ArmPlatformLib >> because it was unused (except internally by one of the implementations) >> So remove the remaining implementations from edk2-platforms. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks. Pushed as 7c4b47ff8212 >> --- >> Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S | 6 ------ >> Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c | 6 ------ >> Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S | 6 ------ >> Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c | 5 ----- >> 4 files changed, 23 deletions(-) >> >> diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S b/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S >> index b7ec02f0e69f..19a2fc07f3d7 100644 >> --- a/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S >> +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/AArch64/Helper.S >> @@ -47,12 +47,6 @@ ASM_FUNC(ArmPlatformGetPrimaryCoreMpId) >> ldr w0, PrimaryCoreMpid >> ret >> >> -# IN None >> -# OUT x0 = number of cores present in the system >> -ASM_FUNC(ArmGetCpuCountPerCluster) >> - MOV32 (w0, FixedPcdGet32 (PcdCoreCount)) >> - ret >> - >> //UINTN >> //ArmPlatformIsPrimaryCore ( >> // IN UINTN MpId >> diff --git a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c >> index f17a960d60ad..facfd61ca230 100644 >> --- a/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c >> +++ b/Silicon/AMD/Styx/Library/AmdStyxLib/Styx.c >> @@ -45,12 +45,6 @@ >> extern EFI_GUID gAmdStyxMpCoreInfoGuid; >> >> >> -UINTN >> -ArmGetCpuCountPerCluster ( >> - VOID >> - ); >> - >> - >> /** >> Return the current Boot Mode >> >> diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S >> index 3422df279c73..74e4aeeffc31 100644 >> --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S >> +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/AArch64/Helper.S >> @@ -29,12 +29,6 @@ ASM_FUNC(ArmPlatformGetPrimaryCoreMpId) >> MOV32 (w0, FixedPcdGet32(PcdArmPrimaryCore)) >> ret >> >> -# IN None >> -# OUT x0 = number of cores present in the system >> -ASM_FUNC(ArmGetCpuCountPerCluster) >> - MOV32 (w0, FixedPcdGet32(PcdCoreCount)) >> - ret >> - >> //UINTN >> //ArmPlatformIsPrimaryCore ( >> // IN UINTN MpId >> diff --git a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c >> index 07ab0d1dc271..b59b9f027573 100644 >> --- a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c >> +++ b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLib.c >> @@ -23,11 +23,6 @@ >> >> #include >> >> -UINTN >> -ArmGetCpuCountPerCluster ( >> - VOID >> - ); >> - >> extern EFI_STATUS MemInitEntry (VOID); >> >> /** >> -- >> 2.11.0 >>