From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B060E202E5CDA for ; Thu, 19 Oct 2017 14:16:06 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id 189so11294433iow.10 for ; Thu, 19 Oct 2017 14:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dh54MeTPkRHnQWu+Rej1RGTkuGKM3H0otEB6zPkY03U=; b=A+Pikz8JvuANMPJtV5lW5ByPwmjbPJQs+2IvKzH19jyEgLqyBg3Sb8ZTndvopF+mTZ S8W7Bwb5slw0ZP3w29QXEDdnJwMhNVDsiamaBo8wfVOZfUrufpkrYvsPFfMm1Myxib3f Z3vbWIqJSxqGMDg6Uz0N9Nnb97AsL2Z9Mo0zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dh54MeTPkRHnQWu+Rej1RGTkuGKM3H0otEB6zPkY03U=; b=Q8h00GVvGNVMTk8mEPJHG+0igOtIOFh9eCi9hYYTLFQM7Qo6yz4VGf/WNBP5dyue3U O01VBitp3JWmqI5gn1rGdK50iwsnoVYudCq88OLnPGKItLMh1fq6hRsyZ42uLNbaqvxI Ic3KMdNsxXSXgbyNgEmqlxgY7zfl/DYCg3cPPVj8Luwp1+V3luC7ibiYbXYUXrBDsnIK zQ+1b6RuOH4Egq/Jf6LqUy5TTXUB3uJsi+WPdKo/fbeWXxbNsttzhfI/g1wQ8DFGh0/Y GTaH/hboEr9s4AjwQh67WTF6h8mnwdNmERWLeGv5iayEvBiwpVxNAatx034BwdhJ3A6Z U3nQ== X-Gm-Message-State: AMCzsaXFJ9musZeuYxpR2pE2ilgt3vEUeVbGA/Fa1fY0zYuaVP7ELHj4 ccUiJMobUhspNeNKCyr4T6Fsf8SJreB1JDk3IbB5P3em X-Google-Smtp-Source: ABhQp+Tj+9vNHi3nJ9ntCSG3eL+GL8yFeMRULZJa7VIyUVGr9rSrtNGqqJ82tVInK5k7OiXlcCIbtJ7zRq3zfRtRWEE= X-Received: by 10.107.82.6 with SMTP id g6mr3462570iob.253.1508447984478; Thu, 19 Oct 2017 14:19:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Thu, 19 Oct 2017 14:19:44 -0700 (PDT) In-Reply-To: <20171019205504.uoiofih7quhjtiq4@bivouac.eciton.net> References: <20171019192141.4782-1-ard.biesheuvel@linaro.org> <20171019205504.uoiofih7quhjtiq4@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 19 Oct 2017 22:19:44 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] EmbeddedPkg/DtPlatformDxe: remove /chosen/stdout-path on GOP registration X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Oct 2017 21:16:06 -0000 Content-Type: text/plain; charset="UTF-8" On 19 October 2017 at 21:55, Leif Lindholm wrote: > On Thu, Oct 19, 2017 at 08:21:41PM +0100, Ard Biesheuvel wrote: >> The presence of a /chosen/stdout-path property will force Linux to use >> the serial port as the primary console, even if a graphical console is >> available as well. But the presence of the Graphics Output Protocol (GOP) >> is a strong indication that the user may prefer to use his keyboard and >> mouse rather than his terminal emulator to interact with the system, so >> let's remove /chosen/stdout-path as soon as a GOP instance is registered. > > This may be the sensible thing to do, but something just doesn't feel > right. > > Also, whatever we do here, we should try to mirror in ACPI with SPCR. > Yes, but it does not belong in this driver. > Are we guaranteed to always want to disable serial console if there is > a graphics adapter? > This does not disable the serial console, it just makes it more difficult to access :-) You will have to add console=ttyAMA0 if you have a screen connected but want your console to appear on the serial port. (Just like on a normal computer) > I still dream of a world in which I can run consplitter up to the > point where an OS takes over, and an OS installer will listen to input > from both sources and register its selection from there. > Yeah. I need this change to get the Debian installer to run on the FB console without having to add 'console=tty0' to the kernel command line. > But if we can't have that, can we have a menu setting to select preference? > The default can be a platform-specific Pcd. > That seems reasonable.