public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [PATCH] ArmVirtPkg: apply PE/COFF memory protection to DxeCore as well
Date: Wed, 8 Mar 2017 10:43:42 +0100	[thread overview]
Message-ID: <CAKv+Gu-y3sytMuO9JiOfQEBsTbyLC+DyOaBP97bZD9kECNuefw@mail.gmail.com> (raw)
In-Reply-To: <31678655-c1d6-0e4c-ec58-8b3b15b488bd@redhat.com>

On 7 March 2017 at 14:56, Laszlo Ersek <lersek@redhat.com> wrote:
> On 03/07/17 12:24, Ard Biesheuvel wrote:
>> Include DXE_CORE in the BuildOptions that are set to force 4 KB section
>> alignment for PE/COFF images in order to allow them to be mapped with
>> strict memory permissions.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>  ArmVirtPkg/ArmVirt.dsc.inc | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
>> index e2d3dcce7945..f61fd0680612 100644
>> --- a/ArmVirtPkg/ArmVirt.dsc.inc
>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
>> @@ -17,7 +17,7 @@ [Defines]
>>    DEFINE DEBUG_PRINT_ERROR_LEVEL = 0x8000004F
>>    DEFINE TTY_TERMINAL            = FALSE
>>
>> -[BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]
>> +[BuildOptions.common.EDKII.DXE_CORE,BuildOptions.common.EDKII.DXE_DRIVER,BuildOptions.common.EDKII.UEFI_DRIVER,BuildOptions.common.EDKII.UEFI_APPLICATION]
>>    GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
>>
>>  [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks, pushed.


      reply	other threads:[~2017-03-08  9:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-07 11:24 [PATCH] ArmVirtPkg: apply PE/COFF memory protection to DxeCore as well Ard Biesheuvel
2017-03-07 13:56 ` Laszlo Ersek
2017-03-08  9:43   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu-y3sytMuO9JiOfQEBsTbyLC+DyOaBP97bZD9kECNuefw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox