public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
	Leif Lindholm <Leif.Lindholm@arm.com>
Subject: Re: ArmLib : GIC Pcds in "ArmPkg/Library/ArmLib/ArmBaseLib.inf"
Date: Thu, 15 Dec 2016 07:46:21 +0000	[thread overview]
Message-ID: <CAKv+Gu-y4MhLis_mo81P80T1QyYW7V4OCDD8BL1hTYJr0rpabg@mail.gmail.com> (raw)
In-Reply-To: <DB5PR04MB099860D9E887C84705E8D3BF8E9D0@DB5PR04MB0998.eurprd04.prod.outlook.com>

On 15 December 2016 at 04:46, Meenakshi Aggarwal
<meenakshi.aggarwal@nxp.com> wrote:
> Hi,
>
>
> I need to modify GicDistributorBase and GicInterruptInterfaceBase Pcds on run time, so I need these to be dynamic.
> But on doing same I am facing errors, because these Pcds are included under [FixedPcd] section in ArmBaseLib.inf and I am using ArmLib.
>
>
> [FixedPcd]
>   gArmTokenSpaceGuid.PcdGicDistributorBase
>   gArmTokenSpaceGuid.PcdGicInterruptInterfaceBase
>
>
> Is there any particular reason behind including these Pcds in ArmBaseLib.inf, as ArmLib is not using these Pcds anywhere.
>
> I removed these Pcds from ArmBaseLib.inf and I didn't face any issue, neither in compilation nor in execution.
>
>
> Please tell me the relevance of including these Pcds in ArmBaseLib.inf.
>

If they are not used in ArmLib, they should be dropped from the .INF

Thanks,
Ard,


  reply	other threads:[~2016-12-15  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-15  4:46 ArmLib : GIC Pcds in "ArmPkg/Library/ArmLib/ArmBaseLib.inf" Meenakshi Aggarwal
2016-12-15  7:46 ` Ard Biesheuvel [this message]
2016-12-15  7:50   ` Meenakshi Aggarwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu-y4MhLis_mo81P80T1QyYW7V4OCDD8BL1hTYJr0rpabg@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox