From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0D5DC224A9EC9 for ; Fri, 30 Mar 2018 03:58:15 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id x77so4482774ioi.2 for ; Fri, 30 Mar 2018 03:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=m32tidda+4A+ZgNPpJ3xssNdj5lCW0uOOnVYe/odCMI=; b=gzm+u3aXuCR6Si4wZ4azIP1dcYsXbGT0JxzUaH06J67LKZAYTcotco+e4vSMnYOlLA uLrspqMRUNNjlZU0EWuSNtWo39ZtVLqPhs0g+5dPaQQfFChkd2TcwJSY2f6xo1y6dpke Dr7i7gfpjbGugcqMYuC1sJP0D5jUFcphKJL14= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=m32tidda+4A+ZgNPpJ3xssNdj5lCW0uOOnVYe/odCMI=; b=n2CWPpxmcCFR6oJgBs2sbawkF/hXKyJhlAq42YbuB+l+3XAiE8632mFMjV48pEklfS qMSxh1WccyhzAr3P/qdNF/obIogyTjBO3x1rbU1/4UgL3vIpJUZQxUiyNXa8c0SEytsI TiDyu9ToQib1FPhrbMIQqEJl5vaFVi3V6/4+5QUhSP7TKPEvm/TlqMdHY6E0MVpWB1s4 mfShjlgNt51mX+PlU7xHVH8otED/pT2Q8ZGPexwgjFrrf4FrXrR0f+l4hBG1iB4eJoKM RfdNcRGWBCAfElTscyarYC629EIRarf/dFdTZXPSbMjTuHkwStgbBAAe6V5m/jVeZn+m 6SCg== X-Gm-Message-State: AElRT7EDqJpCgkm9hgoN80+acFJbkxdlRgiRfhE2VK/YUjBHtUPGoAwO 9elbZYQMn1PyR3F6T2yvfiXjvr6xut6TbyLcCDqsIA== X-Google-Smtp-Source: AG47ELtqQjslkshr1GpUy/hVEd+JKQM5unfWF9ulSplXdLdQBQvdyAvQiN1olaBYsrYdI+m8Pg1cJ+ln6nnb9xY0zMo= X-Received: by 10.107.14.136 with SMTP id 130mr44018430ioo.170.1522407494286; Fri, 30 Mar 2018 03:58:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 30 Mar 2018 03:58:13 -0700 (PDT) In-Reply-To: <20180328202651.1478-4-lersek@redhat.com> References: <20180328202651.1478-1-lersek@redhat.com> <20180328202651.1478-4-lersek@redhat.com> From: Ard Biesheuvel Date: Fri, 30 Mar 2018 11:58:13 +0100 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Anthony Perard , Gary Ching-Pang Lin , Jordan Justen , Julien Grall Subject: Re: [PATCH 3/4] OvmfPkg: annotate "PcdVariableStoreSize := PcdFlashNvStorageVariableSize" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 10:58:15 -0000 Content-Type: text/plain; charset="UTF-8" On 28 March 2018 at 21:26, Laszlo Ersek wrote: > As a continuation of the last patch, clarify in the DSC files that we set > PcdVariableStoreSize to the same value as PcdFlashNvStorageVariableSize > just for convenience; the equality is not a technical requirement. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Gary Ching-Pang Lin > Cc: Jordan Justen > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > OvmfPkg/OvmfPkgX64.dsc | 2 ++ > 3 files changed, 6 insertions(+) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 92c8c560a067..7664b50ddef9 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -439,11 +439,13 @@ [PcdsFixedAtBuild] > !if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > + # match PcdFlashNvStorageVariableSize purely for convenience > gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000 > !endif > !if $(FD_SIZE_IN_KB) == 4096 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8400 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x8400 > + # match PcdFlashNvStorageVariableSize purely for convenience > gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x40000 > !endif > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 6ecaa795b288..e5969090d437 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -444,11 +444,13 @@ [PcdsFixedAtBuild] > !if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > + # match PcdFlashNvStorageVariableSize purely for convenience > gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000 > !endif > !if $(FD_SIZE_IN_KB) == 4096 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8400 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x8400 > + # match PcdFlashNvStorageVariableSize purely for convenience > gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x40000 > !endif > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index c98a3657c6f6..7197c1984a7c 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -444,11 +444,13 @@ [PcdsFixedAtBuild] > !if ($(FD_SIZE_IN_KB) == 1024) || ($(FD_SIZE_IN_KB) == 2048) > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800 > + # match PcdFlashNvStorageVariableSize purely for convenience > gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000 > !endif > !if $(FD_SIZE_IN_KB) == 4096 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x8400 > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x8400 > + # match PcdFlashNvStorageVariableSize purely for convenience > gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0x40000 > !endif > > -- > 2.14.1.3.gb7cf6e02401b > >