From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d42; helo=mail-io1-xd42.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E4E64211D9400 for ; Mon, 11 Mar 2019 07:48:38 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id x7so4252396ioh.4 for ; Mon, 11 Mar 2019 07:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I58MvLSeNEqAYbfpRgCyFXQiNUSG1xA3/QSQ9mzBn24=; b=PX/MsdNgxxWp6WRcBmQ8+e0M7qlGIqD6VUEUbkXyNmFOj7X6jIQTPWNGJ82v8k9JWj oT+26WobO0uyfnfGuzJTHG+aogN5B5/HPIkzYYVGeEvEq54zTDBFvb6zn6gHFTyy4z4Z D4pthcpSh3/O6sm2NbdyajQN3dXMwTGA5esr4EajPLi5c1VF51+hbc4FsNEDtaBEIS7A ef8VpIh28m9VPuNrUgC3pXiMIPUPaHIdXOh0XNc4ka3VRCQk7b2WJom/6g/aeqXdQ4Pl aKMQp01pOyx7pyAoVIjrCQ5pgW6u/JXG+hADMhfvJaRxMMCzyNMabgjzxF93s4A5ug3j Fsgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I58MvLSeNEqAYbfpRgCyFXQiNUSG1xA3/QSQ9mzBn24=; b=f0pBiC5HtIjskYDKqdsIdmhuKY/fwU/60gdyvvistM/KgwJIwrbrEJlwxuIxmoA8mB imdUavlgRyGn5lWVnfAqQpHFpl46wZtD1mlH4NjpYp+p7fgAZmgchLHpuBcshzufYZWw 0cxHKKQzKQXoFwg+bNiZfr4LBk/hn85J5XKr7HqQVTuHFRl78gDWLPHqFXWH51zl3DTe PLL4r/MDLIdlx4l5zeXwDdVUniDdEl7PvXZa2LpCVGFkkqTW7OAoYk/OE4UKfsxn5wVI XeDXnl8Rdbg6UmQAiARC0GHbFL0FJd64gX8kXgQNCPEwLgEbI/eE6TAy9kBMDXKZulpu 82rg== X-Gm-Message-State: APjAAAVjLZ7AwTz+/RPdj9eLKZpBpv/ntNGH0ttxhEygfODIAdQuRDVb bK6nKWkSySAWlStKHpuGFa+fkoCOoQQdWRt7uWgsXBlynO8= X-Google-Smtp-Source: APXvYqyD0p5Yo3WXWwEJXl9IgcVZklpdcxcHLrzOEMTDLd4huhoH3uYhSpk1E2qZ9wockjtSRCy1eRr0QC6G8PvZvZ0= X-Received: by 2002:a5e:d609:: with SMTP id w9mr16531375iom.170.1552315717692; Mon, 11 Mar 2019 07:48:37 -0700 (PDT) MIME-Version: 1.0 References: <20190308153010.18486-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Mon, 11 Mar 2019 15:48:26 +0100 Message-ID: To: Thomas Abraham Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms 1/2] Platform/ARM/SgiPkg: align with upstream StandaloneMmPkg changes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 14:48:39 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 11 Mar 2019 at 14:56, Thomas Abraham wrote: > > On Mon, Mar 11, 2019 at 7:09 PM Ard Biesheuvel > wrote: > > > > On Mon, 11 Mar 2019 at 14:31, Thomas Abraham wrote: > > > > > > On Fri, Mar 8, 2019 at 9:01 PM Ard Biesheuvel wrote: > > > > > > > > Bring SgiPkg in line with EDK2 core changes to StandaloneMmPkg: > > > > - add a resolution for ExtractGuidedSectionLib > > > > - remove reference to gStandaloneMmPkgTokenSpaceGuid.PcdStandaloneMmEnable > > > > - update the resolution of StandaloneMmDriverEntryPoint > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel > > > > --- > > > > Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > index 65dd6ac82c4a..ef16bfa9a20e 100644 > > > > --- a/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > +++ b/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc > > > > @@ -43,6 +43,7 @@ > > > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > > > > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > > > + ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf > > > > > > The build fails with the following error > > > > > > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:37: > > > undefined reference to `memcpy' > > > /tmp/ccOj5Ie6.ltrans0.ltrans.o: In function > > > `ExtractGuidedSectionLibConstructor': > > > /home/thopan01/devel/sgi/sgi-dev/uefi/edk2/EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.c:233: > > > undefined reference to `memcpy' > > > collect2: error: ld returned 1 exit status > > > > > > I will check further why the build fails here. > > > > > > > We need to add this in the .dsc > > > > # > > # It is not possible to prevent the ARM compiler for generic > > intrinsic functions. > > # This library provides the instrinsic functions generate by a given compiler. > > # And NULL mean link this library into all ARM images. > > # > > NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > Thanks, it works with this change. So with this change rolled into this patch. > Reviewed-by: Thomas Abraham Thanks Thomas Pushed as c63c3f071271..68cc99303e38