From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=DVjPUo09;
 spf=pass (domain: linaro.org, ip: 209.85.166.193, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f193.google.com (mail-it1-f193.google.com [209.85.166.193])
 by groups.io with SMTP; Fri, 17 May 2019 08:35:06 -0700
Received: by mail-it1-f193.google.com with SMTP id a190so12610454ite.4
        for <devel@edk2.groups.io>; Fri, 17 May 2019 08:35:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=BZT2FRgC+tQcyH6EyVBZjoEJdji6mSKV7SabZ9Jd/u8=;
        b=DVjPUo09c1qj2yN/R5GP8eMv3z/rWg/9mgCiZAFyP4+cxvyJVkSkG1z/aNdaMQkxou
         7DVbP2oMwIdvB2XK5yCiTL5p1pCt0mTrpXlsXzffjNN0Hkzoz8SpZ6rIGZPI+njfILlI
         ZdWWmcbvSigDAvScY1iPQ496py0w6s1xfQHnrQ27eGpeMbdfU4VSVNgSwy1DL21AXYdN
         qC2wz9GD3AZWMozR+12ZG3nFk2+5Cf4hzNN8un1td52nzbSmcGaCLnd4sDv8d1AdfjfO
         m59nKTOUNPWvutHk37j0h9/505XbmZGwJICvH3lQyyTUDq5Y37rWrMRuL3S4yFy16Bt2
         KBnA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=BZT2FRgC+tQcyH6EyVBZjoEJdji6mSKV7SabZ9Jd/u8=;
        b=HaTxCz8zwafStqOHtnd8l+fR4wpFvZ1vxDLEOC2V5qcVFqutJNiQTWQ5NPsr/jB5ps
         Gn6pPZnKXTVImj9oJ0c+Vfhg32BOYpgCM7flcbETBlZeGH/YmIHnOawvF3EyUzW3V1mh
         aQ+PcckHozio/I4vftlaSg1w0JsHmMyorAoCE5/JVo6enK7AWVMdjVkDgUIALWBKHevY
         ZUZqXmTn/X9Z9tBMRxpBTfQxjMoPSFJ+fj0u5b7TV7MD8ftq9QPOMLzcCwZ3pM1YGF2b
         +gGGsKbmV5GiRNrlFwh0RuJMotZ+qc5GTyNe1NHEqJo07gje29LHeYuIDByAd1LBltI1
         IOcQ==
X-Gm-Message-State: APjAAAW1SPKYjtAakChdpLgtaZh7+nO+0VGdpvAPqTsJcehdKNjZbKU0
	1L/5A7iC9nWMXg+KrVGINV/VfZNb8e8VGxiMyPL+VQ==
X-Google-Smtp-Source: APXvYqzukfehCfESnNRjBGJ/nGfqPNgv5/H54au9bVumA+Bfg82Fo0yWYws8o2eWiSWQEWqU9ZvKwIT8PLnBk1XNqc0=
X-Received: by 2002:a24:d00e:: with SMTP id m14mr17117780itg.153.1558107306027;
 Fri, 17 May 2019 08:35:06 -0700 (PDT)
MIME-Version: 1.0
References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-10-hao.a.wu@intel.com>
In-Reply-To: <20190514020831.7728-10-hao.a.wu@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 17:34:53 +0200
Message-ID: <CAKv+Gu-yp98Z7gh+uzMrAYP-1x2sX-yKME3T_TKagiaLetHTWg@mail.gmail.com>
Subject: Re: [edk2-platforms][PATCH v1 07/16] Hisilicon/D06: Drop the consume of PcdShellFile
To: Hao A Wu <hao.a.wu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif.lindholm@linaro.org>, 
	Michael D Kinney <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 14 May 2019 at 04:08, Hao A Wu <hao.a.wu@intel.com> wrote:
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
>
> After the drop of the consume of GenericBdsLib, there is no module that
> will use gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This
> commit will drop the consume of this PCD.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D06/D06.dsc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc
> index 0c12181a38..bcd57db6bb 100644
> --- a/Platform/Hisilicon/D06/D06.dsc
> +++ b/Platform/Hisilicon/D06/D06.dsc
> @@ -187,7 +187,6 @@
>
>
>    gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|FALSE
> -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
>    gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
>    gHisiTokenSpaceGuid.PcdSysControlBaseAddress|0x94010000
>    gHisiTokenSpaceGuid.PcdMailBoxAddress|0x0000FFF8
> --
> 2.12.0.windows.1
>