From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8A9D121959CB2 for ; Mon, 21 Jan 2019 08:47:22 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id m19so16885420ioh.3 for ; Mon, 21 Jan 2019 08:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bxf5OOcI6nbL+9t+oDgOXsONXZk+mVY36O2XuFW8g+Q=; b=PMm+/kpU6s2j0Gv5/ggy1VlbgfrpERfaqSUUFoPEdfpiOT7H466uNVX52otJqbwz7/ Mk+Oh/76nz3P/Y88F7G1OUVj9vNCYdhyFs/KE2fuTlPvF3CCD1uiHfufUtf0p/euPQ5B MRNv9Iw2Pvc3tKwbLTY45NbC8vVwYhtwuImfA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bxf5OOcI6nbL+9t+oDgOXsONXZk+mVY36O2XuFW8g+Q=; b=jUvm9ESr5ZWDl0zgnXkU1qJP//rRaWueKP7+Ud4p/zlK4p8kBoq1xyJKdfb5AKQ6SJ R7vUuOEDqKgXwD1khjhroXoiIM850p5g3j+Yv9stLQ6ru9nl2Kf/ItUGHHXQpaF4nUST +nla5QxXs24+T11KG8sN3mIzP4RjqB8XicazEfBaQl2HNYt6sH+x5bZIDEuK7H3itVlj DUGAZHrq+XyJ9bfazc8HIy4I8nEI50LXE/b8N5dzCgkln5cWqYsEzzp97Tl0yIjzSsWC ORofR7AZbiUzsQrueAwq6fmFbtCqXKRH/bLe4bL6tZ2uCjofY2c9ebTAzFDT5Gc0BLFg 6/SQ== X-Gm-Message-State: AJcUukdOe8iAFcdecy8jkAkF8HuTZRc4j9aa63ot4q/7/Fwo9iLPiuFi v1kom41Y7FUoC9OyGXmzbai+80E1Lbcn6EyS2ZrIwg== X-Google-Smtp-Source: ALg8bN47hEIdJIUqO1EIKE1/aWE4RZJc5n6LY+1TtGz1+xD8BrBytbzdv36EtTZl/4ca2zoCx62aJBi8EOOi+QN2CSE= X-Received: by 2002:a5e:c206:: with SMTP id v6mr17869067iop.60.1548089241458; Mon, 21 Jan 2019 08:47:21 -0800 (PST) MIME-Version: 1.0 References: <20190104144336.8941-1-ard.biesheuvel@linaro.org> <20190104144336.8941-3-ard.biesheuvel@linaro.org> <20190117101000.hsesfat7kcie7yuu@bivouac.eciton.net> <20190121164641.5ig75gmrgw4rjnbe@bivouac.eciton.net> In-Reply-To: <20190121164641.5ig75gmrgw4rjnbe@bivouac.eciton.net> From: Ard Biesheuvel Date: Mon, 21 Jan 2019 17:47:10 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Masahisa Kojima Subject: Re: [PATCH edk2-platforms 2/7] Silicon/SynQuacer/Fip006Dxe: factor out DXE specific pieces X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 16:47:22 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 21 Jan 2019 at 17:46, Leif Lindholm wrote: > > On Mon, Jan 21, 2019 at 05:16:09PM +0100, Ard Biesheuvel wrote: > > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > > similarity index 88% > > > > > rename from Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h > > > > > rename to Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > > index 20e74b0320ce..61b8e6a08fa0 100644 > > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h > > > > > +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlash.h > > > > > @@ -27,11 +27,9 @@ > > > > > #include > > > > > > > > > > #include > > > > > -#include > > > > > #include > > > > > +#include > > > > > > > > Why add this include? > > > > I'm not going to ask to move out the existing headers not actually > > > > used by this file, but could we avoid adding new ones? > > > > > > > > https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/v/release/2.20/5_source_files/53_include_files.html#534-include-files-may-include-only-those-headers-that-it-directly-depends-upon > > > > is actually a rule I agree with. > > > > > > > > But also, aren't all of the users of this file already manually > > > > including this one? > > > > > > > > > > Fair enough. I will drop the include here, and add it to whichever > > > source file requires it afterwards. > > > > > > > That include turns out to be entirely redundant, so I will just drop it. > > Works for me. > Wonderful. Can I take that as an ack? > > > > > #include > > > > > -#include > > > > > -#include > > > > > > > > > > #include "Fip006Reg.h" > > > > > > > > > > > > > > diff --git a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > > index e52ab52d8cf7..6c07799b22d8 100644 > > > > > --- a/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > > +++ b/Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c > > > > > @@ -15,15 +15,16 @@ > > > > > **/ > > > > > > > > > > #include > > > > > +#include > > > > > +#include > > > > > #include > > > > > > > > At least this one does. > > > > > > > > > #include > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > > > > > > -#include "NorFlashDxe.h" > > > > > - > > > > > -STATIC EFI_EVENT mNorFlashVirtualAddrChangeEvent; > > > > > +#include "NorFlash.h"