From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::22c; helo=mail-io0-x22c.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 619592034EE25 for ; Sun, 5 Nov 2017 02:01:32 -0800 (PST) Received: by mail-io0-x22c.google.com with SMTP id 189so12769669iow.10 for ; Sun, 05 Nov 2017 02:05:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7dgaYYluuELDVrq/L7gi5KLercgtWJJJXvzeOTUBt7c=; b=WwyESg4bu+mTD2U/h+OvmJOw4q+LOeeVUO7b8eRYtz/r5s9YiOj40tuRWQE5xE0YYX S9iPMqn21ZKnsj84c8TA6u4C+ZQe3lkptOYpqWQirqlWNQCM7f8xRib76WvgocLERFPG aWKPUHy1OEMrGfTBKFxY0Mbx0XOtZIuApJHyo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7dgaYYluuELDVrq/L7gi5KLercgtWJJJXvzeOTUBt7c=; b=pOAd4Hra//Pb5VGBd56dOM01lrQU+bB4zfTDfSk3zIv1bAhK+jyPTqg9cn4BpKH5jW KlhULKfT1RXxHAoAmnsYPjfXH1CeFuTeJhCiSIJuO8fD9f+JyxmUGvm7MB2TUihmQlll 21sBbYT/oz42EOs4nKVFKgUzBBNx9rrBKCTfevF0stYxZlWrIX2gzYRgR68jQa/h3ruJ 7r4GhsgTjnDDzAx/YIP7n+lr6LyoXpDSKEP/upH1R6fzr7AlsoxrxrBXidQsgYoeu4dY mQGeQbcHOZlmTVcaqQvqq5YCqu6sQxRikkaN0qGLS3U3HWDq+ZOgqRbRKVGv9xl9ECVw ydeQ== X-Gm-Message-State: AMCzsaWlHGA9A2f+zFnR8KY4z51qqF9sBTZR8NsRYfu70/SzvD2Gd7Av tyL1B98lgUcyLYKbqqwthV1vGlNa8k6mWB0Kd0bXOw== X-Google-Smtp-Source: ABhQp+QSR1lkeFVJWHtg4htQYqac0e30VfFw+lEBXdOvfFpbmmyTbUhIbW6f5uFIg+PTmJkV3T5S3a1uiZhqw46ghFk= X-Received: by 10.107.142.208 with SMTP id q199mr15645695iod.186.1509876328544; Sun, 05 Nov 2017 02:05:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Sun, 5 Nov 2017 02:05:28 -0800 (PST) In-Reply-To: <20171105053852.ppzfshzqrtwsts4a@bivouac.eciton.net> References: <20171101131145.16459-1-ard.biesheuvel@linaro.org> <20171101131145.16459-2-ard.biesheuvel@linaro.org> <20171105053852.ppzfshzqrtwsts4a@bivouac.eciton.net> From: Ard Biesheuvel Date: Sun, 5 Nov 2017 10:05:28 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Daniel Thompson Subject: Re: [PATCH 1/2] EmbeddedPkg: introduce GPIO PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 10:01:32 -0000 Content-Type: text/plain; charset="UTF-8" On 5 November 2017 at 05:38, Leif Lindholm wrote: > On Wed, Nov 01, 2017 at 01:11:44PM +0000, Ard Biesheuvel wrote: >> Introduce a PPI counterpart of the existing 'embedded GPIO' protocol, >> so we can manipulate GPIOs from PEI modules. This allows things like >> setting the boot mode based on a DIP switch setting. >> >> Note that the naming is slightly awkward, as there is nothing 'embedded' >> about a GPIO, but given that the DXE protocol already resides here and >> has the 'embedded' prefix, it makes sense to retain uniformity. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel > > I have no objection to this, so: > Reviewed-by: Leif Lindholm > > ...but I do have a question: > Do we strictly need to duplicate this include file? It feels like a > bit of a maintenance hazard/burden. > Yeah, I wondered about that as well, but given that it's only two enum typedefs and a couple of macros that we can really share, I didn't bother.