Re: [PATCH 1/3] MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 2 September 2016 at 16:23, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Fri, Sep 02, 2016 at 04:02:44PM +0100, Ard Biesheuvel wrote:
>> > On 2 sep. 2016, at 15:29, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>> >
>> > Recent changes to the BaseMemoryLib implementations in MdePkg,
>> > and other changes dependent on these, left all ARM* platforms
>> > unbuildable. To avoid this sort of thing in the future, move
>> > the ARM* BaseMemoryLib implementations to the same locations
>> > as the other ones.
>>
>> Can't we just get rid of the stm version, and move everything to the
>> generic version? Copying all this crap into MdePkg does not seem
>> like an improvement to me at all.
>
> This isn't a proposed alternative to your patchset, this is an
> alternative to reverting all of the other BaseMemoryLib changes.
> I'm happy to throw it away next week if we can get something better in
> by then.
>
>> The AArch64 optdxe changes i proposed are arguably as harmless,
>
> Yes, but that leaves ARM broken.
>

Not necessarily. ARM can use the generic BaseMemoryLib in MdePkg

>> since they don't affect any other arch either. And the stm aarch64
>> versions are plain c to begin with
>
> And I want to discuss that next week. Against the backdrop of a
> working master branch.
>

My concern is that having an 'ARM' flavor of BaseMemoryLib in MdePkg/
will make it more difficult rather than easier to simply add ARM
support to the existing non-sse/mmx ones

Added the fact that the Stm is not in great shape, I would really
prefer to get rid of it rather than 'promote' it to the standard ARM
implementation. Note that we will need another round of updates to the
platform .DSCs when we remove the Stm version again.