From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C02061A1E06 for ; Fri, 2 Sep 2016 09:07:49 -0700 (PDT) Received: by mail-it0-x22c.google.com with SMTP id i184so11505350itf.1 for ; Fri, 02 Sep 2016 09:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hU+X4osdfA6vuUASaxmcOj/SbqcDLMbILQeNKo050t4=; b=a91kFKrz10CncFWXldMxE1/OZPdlYd66jCBWfVYrkpTCykvAnVMZlOHUuJIk3qPeP0 yMdq175e2Oik5cQ4bA0fyYjEYBoyDxLQnq7wxIoAblobhF0ZXeMYXtSKAm18lDOxnvCj DWwpzbBAidWM8ckBdyfOkF836khuNZjqaLezQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hU+X4osdfA6vuUASaxmcOj/SbqcDLMbILQeNKo050t4=; b=VXi5IQ6SRVHE9xlJcWC28mFaNnaW552NfC6X3E7XMhnzNOi1V59bHr7j1PCoGJ9+F9 CrQELSyzenKzJnBOvZdYJXEF1z7POW5fP1ayzvae9T3nlIVI8dPvTTCMd1qvaJYHiEcm 03Oje5zgrOPOgcWhXs3yM1RAKiYabbIGMDmQZ5CfwbxboOitmQCQ8sdJ09ngviz2x6Vh gPZ6vQxXj5OPOyUutyDKXmyV1Wxi85JWDSoo5Q4kXgQceogbbv0hyG71TqJAoFGd0zIS 2/W80i4V42oN5X6HOZo2PERNBh3XrLAO8IHfmF5hBNOG8OiLI8GLKEqCgaQhRALqbi4Z F1Eg== X-Gm-Message-State: AE9vXwNLOG6qfvPwvSUpLWGcv+0BYbiowI6RtZ4l6H1/9oEqLByLoUtFcJhP1ljKhR/boMSnoxE3IsClYNW51kV6 X-Received: by 10.107.3.204 with SMTP id e73mr55332ioi.130.1472832468988; Fri, 02 Sep 2016 09:07:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Fri, 2 Sep 2016 09:07:48 -0700 (PDT) In-Reply-To: <20160902152351.GB4715@bivouac.eciton.net> References: <20160902142912.17297-1-leif.lindholm@linaro.org> <20160902142912.17297-2-leif.lindholm@linaro.org> <6C8DC7F6-2459-4CD6-A556-3B17A1FBBF5F@linaro.org> <20160902152351.GB4715@bivouac.eciton.net> From: Ard Biesheuvel Date: Fri, 2 Sep 2016 17:07:48 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Laszlo Ersek , Michael D Kinney , Liming Gao Subject: Re: [PATCH 1/3] MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 16:07:50 -0000 Content-Type: text/plain; charset=UTF-8 On 2 September 2016 at 16:23, Leif Lindholm wrote: > On Fri, Sep 02, 2016 at 04:02:44PM +0100, Ard Biesheuvel wrote: >> > On 2 sep. 2016, at 15:29, Leif Lindholm wrote: >> > >> > Recent changes to the BaseMemoryLib implementations in MdePkg, >> > and other changes dependent on these, left all ARM* platforms >> > unbuildable. To avoid this sort of thing in the future, move >> > the ARM* BaseMemoryLib implementations to the same locations >> > as the other ones. >> >> Can't we just get rid of the stm version, and move everything to the >> generic version? Copying all this crap into MdePkg does not seem >> like an improvement to me at all. > > This isn't a proposed alternative to your patchset, this is an > alternative to reverting all of the other BaseMemoryLib changes. > I'm happy to throw it away next week if we can get something better in > by then. > >> The AArch64 optdxe changes i proposed are arguably as harmless, > > Yes, but that leaves ARM broken. > Not necessarily. ARM can use the generic BaseMemoryLib in MdePkg >> since they don't affect any other arch either. And the stm aarch64 >> versions are plain c to begin with > > And I want to discuss that next week. Against the backdrop of a > working master branch. > My concern is that having an 'ARM' flavor of BaseMemoryLib in MdePkg/ will make it more difficult rather than easier to simply add ARM support to the existing non-sse/mmx ones Added the fact that the Stm is not in great shape, I would really prefer to get rid of it rather than 'promote' it to the standard ARM implementation. Note that we will need another round of updates to the platform .DSCs when we remove the Stm version again.