Re: [PATCH 5/5] ArmPlatformPkg: add package .DSC file

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 8 December 2017 at 16:19, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Dec 05, 2017 at 10:13:26AM +0000, Ard Biesheuvel wrote:
>> Now that we have removed all the cruft from ArmPlatformPkg, add a .DSC
>> file that builds all the remaining components standalone, i.e., outside
>> of the context of any particular platform. This is primarily intended
>> for build time testing.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>  ArmPlatformPkg/ArmPlatformPkg.dsc | 121 ++++++++++++++++++++
>>  1 file changed, 121 insertions(+)
>>
>> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc
>> new file mode 100644
>> index 000000000000..032942e87891
>> --- /dev/null
>> +++ b/ArmPlatformPkg/ArmPlatformPkg.dsc
>> @@ -0,0 +1,121 @@
>> +#/** @file
>> +# ARM platform package.
>> +#
>> +# Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
>> +# Copyright (c) 2011 - 2015, ARM Ltd. All rights reserved.<BR>
>> +# Copyright (c) 2016 - 2017, Linaro Ltd. All rights reserved.<BR>
>> +#
>> +#    This program and the accompanying materials
>> +#    are licensed and made available under the terms and conditions of the BSD License
>> +#    which accompanies this distribution. The full text of the license may be found at
>> +#    http://opensource.org/licenses/bsd-license.php
>> +#
>> +#    THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
>> +#    WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
>> +#
>> +#**/
>> +
>> +################################################################################
>> +#
>> +# Defines Section - statements that will be processed to create a Makefile.
>> +#
>> +################################################################################
>> +[Defines]
>> +  PLATFORM_NAME                  = ArmPlatformPkg
>> +  PLATFORM_GUID                  = 9ce08891-ac9c-476d-ab04-0c04d3a97544
>> +  PLATFORM_VERSION               = 0.1
>> +  DSC_SPECIFICATION              = 0x0001001A
>> +  OUTPUT_DIRECTORY               = Build/ArmPlatform
>> +  SUPPORTED_ARCHITECTURES        = ARM|AARCH64
>> +  BUILD_TARGETS                  = DEBUG|RELEASE
>
> DEBUG|NOOPT|RELEASE ?
> Tested with clang/gcc ARM/AARCH64.
> Feel free to fold that in, or not.
>

Yeah good point.

> For the series:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks! Pushed as a8406340bdf2..2b129e87c0f4 (with NOOPT added)