From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=UCqbY6wf;
 spf=pass (domain: linaro.org, ip: 209.85.166.68, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68])
 by groups.io with SMTP; Sun, 14 Apr 2019 19:05:05 -0700
Received: by mail-io1-f68.google.com with SMTP id v10so13278556iom.8
        for <devel@edk2.groups.io>; Sun, 14 Apr 2019 19:05:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=NFKgpIBXAXf45KIpafYQXUQzbvr69s7eihey/Qgh2Mc=;
        b=UCqbY6wfrWrtmX4zRcWYD5qThm5sE5PYIbauhoDU7blu+EqLLbzq3grEpBjvXoYFjU
         GJG2CEUQMBJF1pTE3mXFuHcTYj2WrbyJ8hBk7vIY+JU0QeuD3PMAk2tlsE5L3XQs4wN3
         LYUFkb2Q1gGu0eKLaxaRYNlKExLpQMcsgiCrRoFv15Ol69QESZLx8c9O7CdJ7Gj9ypbh
         uhF2SH1oZtXZotZxUy0xK+zCT6L0RN1sd6uFuAvbkXnXK5/jDnPhGmMMshMTcUfInrB7
         QhH+8toZw3dpO8oPZAH07U5L9yAYi/bE0L9CrVG0TJrWmz0oLAYtYGfFmIq8xOnKc4TF
         9Rog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=NFKgpIBXAXf45KIpafYQXUQzbvr69s7eihey/Qgh2Mc=;
        b=QeUlUqBoD0v2mEMuZw5fUnYh4WWEE1vk27a9OWnEfFmFZCKiskuMEj+8p4GfVWfLFH
         MK7s34ERJxKmg9fQXFM2t96fRCQSMdvi8IHwp6Z3Kjfru45n5EmUiYI29L/sE2nX+HwO
         2bJz5//Zd26TVwc+OriY8g76CmS70fFjFwWqqtOSJN0SDzWncVm+Q9RSfbHBWyCWCzmR
         Dxbx8cod7qatwU63zguU+QUkc6opUjBOfy7ny3NQ5pCR9xHhw9+tmVRs2xqBeBGt4lUa
         jMPtrlpCOaCpz4xXr7Z/ziJDMxHIaQRHqybBf0dJqz/Ocls4dICvVUT5LHLerGzqbB7w
         HVKQ==
X-Gm-Message-State: APjAAAXzro2pm3hIw6baEOBQFtIKmIfgFSb0EiO3sxtrXyu2G72rymKc
	/HEoIIyZZDIWhTfw9dgmI96fsHVKeqlaPu4/xaF1p51FU0VXrZeo
X-Google-Smtp-Source: APXvYqyuKdNzl9sRrV+oLn2hgGfFZSfIsVSAvVRehIs9M8P1akkQltwiKkNEjWm5j/Z8TVfymPrvej+JM6l6QFh5IvA=
X-Received: by 2002:a6b:f201:: with SMTP id q1mr39682902ioh.197.1555293904197;
 Sun, 14 Apr 2019 19:05:04 -0700 (PDT)
MIME-Version: 1.0
References: <20190414195233.30045-1-ard.biesheuvel@linaro.org> <B80AF82E9BFB8E4FBD8C89DA810C6A093C8BEA93@SHSMSX104.ccr.corp.intel.com>
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8BEA93@SHSMSX104.ccr.corp.intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Sun, 14 Apr 2019 19:04:53 -0700
Message-ID: <CAKv+Gu80XBJLQt+FBnVzDtazB+k1NQtWvAj1GnLiOG4BNhxa8A@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images
To: edk2-devel-groups-io <devel@edk2.groups.io>, "Wu, Hao A" <hao.a.wu@intel.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>, Andrew Fish <afish@apple.com>, 
	Leif Lindholm <leif.lindholm@linaro.org>, "Zeng, Star" <star.zeng@intel.com>, 
	"Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>, 
	"Gao, Liming" <liming.gao@intel.com>, "Carsey, Jaben" <jaben.carsey@intel.com>, 
	"Shi, Steven" <steven.shi@intel.com>, "Wang, Jian J" <jian.j.wang@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Sun, 14 Apr 2019 at 18:25, Wu, Hao A <hao.a.wu@intel.com> wrote:
>
> > -----Original Message-----
> > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org]
> > Sent: Monday, April 15, 2019 3:52 AM
> > To: devel@edk2.groups.io
> > Cc: Ard Biesheuvel; Kinney, Michael D; Andrew Fish; Leif Lindholm; Zeng, Star;
> > Dong, Eric; Ni, Ray; Gao, Liming; Carsey, Jaben; Shi, Steven; Wang, Jian J; Wu,
> > Hao A
> > Subject: [PATCH v6 0/7] MdeModulePkg: add support for dispatching foreign
> > arch PE/COFF images
> >
> > Add the basic plumbing to DXE core, the PCI bus driver and the boot manager
> > to allow PE/COFF images to be dispatched that target an architecture that is
> > not native for the platform, but which is supported by one of potentially
> > several available emulators.
> >
> > One implementation of such an emulator can be found here:
> > https://github.com/ardbiesheuvel/X86EmulatorPkg/tree/upstream-v4
> >
> > This also allows us to get rid of the special treatment of EBC images in
> > core code. Instead, the EbcDxe driver is augmented with an implementation
> > of the EDK2 PE/COFF image emulator protocol so that internal knowledge of
> > how EBC is implemented (I-cache flushing, thunks) is removed from the DXE
> > core.
> >
> > Changes since v5:
> > - Fix build issues reported by Mike Kinney (#2, #5)
> > - Fix CheckPatch.py issue regarding the use of EFI_D_ERROR (#2) [This is code
> >   that is only being moved around but I fixed it nonetheless]
> > - Use InstallMultipleProtocolInterfaces() to install the EBC protocol and the
> >   PE/COFF emu protocol at the same time (to simplify/fix the error path) (#5)
> > - Add Mike's Reviewed-by
>
> The series looks good to be.
> Please help to address the format issues as I replied in 1/7 and 2/7
> patches.
>
> With those addressed, for the series,
> Reviewed-by: Hao Wu <hao.a.wu@intel.com>
>


Thank you Hao

I have made the changes you requested, and pushed the series as
174232fa9a90..2e21e8c4b896

Thanks to all for the effort,
Ard.