From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 27CB082175 for ; Thu, 23 Feb 2017 03:18:11 -0800 (PST) Received: by mail-it0-x22c.google.com with SMTP id d9so2892753itc.0 for ; Thu, 23 Feb 2017 03:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wGXsGeu7+ZKwtbFnuwoOThqTgzgfzee7oYPu1Sft5Wc=; b=H+Ig7u+AZ0THcoiqBONt/Jgo0nRZAJ7PUtqBgTJPCUnn9dqPpIz9erPNPON9YweYZb FxvUUDOlH+aZlJLMIt77eH0lI2okHiaeHCvu8fHWmMiG1XMrsptXQtl2sTb8rz8Skye7 XPdKozJn5eI1hR9fUaQ/XKh+mE8w/s2Wp2DWE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wGXsGeu7+ZKwtbFnuwoOThqTgzgfzee7oYPu1Sft5Wc=; b=q9JoCWTrHUTpjEqsfaMOR6xkjXIzVd43JxWS0qtDuIibPFvKVAh7kFplbnK7iphQoA KcVTsESlsSOz0rk2wweZqhlqaNejLyEHzhP3iszvD+/vZNMSRf/MS5gRN+wTD+50hVB8 v/1FlSEJqRXbrUIosTeaCZGi5RLu4Zzw82T4YFyWymY6Tp50BAKpO9j2RrEDIcDBkYiZ hXNhEGoH9/gB6Ifmo8YAKKifzgZ12XeWb9aLZjilV2BvrAIR+LFdjSogMfY2ivYocUo3 annk2KxKAT6DPX2UbEcNCUb42r1VV68JL/dsPqid/38IEnLO/tyGqfKPT+K31JPQjP7N sQKA== X-Gm-Message-State: AMke39mlYOx7tFhGNNLO6ThsVsrmzk1mJugKUWloI02qsG3lOjHiH2AvSl8zbGNxOOKzEO9d2w6dtfXOiE/cl6W5 X-Received: by 10.36.107.194 with SMTP id v185mr3192538itc.59.1487848690088; Thu, 23 Feb 2017 03:18:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.198.134 with HTTP; Thu, 23 Feb 2017 03:18:09 -0800 (PST) In-Reply-To: <20170223014814.10937-5-lersek@redhat.com> References: <20170223014814.10937-1-lersek@redhat.com> <20170223014814.10937-5-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 23 Feb 2017 11:18:09 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 Subject: Re: [PATCH 04/12] ArmVirtPkg: resolve QemuFwCfgS3Lib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2017 11:18:11 -0000 Content-Type: text/plain; charset=UTF-8 On 23 February 2017 at 01:48, Laszlo Ersek wrote: > QemuFwCfgS3Enabled() in "ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c" > returns constant FALSE. > > The same implementation is now available factored-out in > "OvmfPkg/Library/QemuFwCfgS3Lib/QemuFwCfgS3Base.c". > > Resolve QemuFwCfgS3Lib to BaseQemuFwCfgS3LibNull. > > Cc: Ard Biesheuvel > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=394 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtQemu.dsc | 1 + > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 8fe3c3816961..9c8a2d977a8a 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -52,6 +52,7 @@ [LibraryClasses.common] > VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf > VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf > QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > + QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf > > ArmPlatformLib|ArmVirtPkg/Library/ArmVirtPlatformLib/ArmVirtPlatformLib.inf > ArmPlatformSysConfigLib|ArmPlatformPkg/Library/ArmPlatformSysConfigLibNull/ArmPlatformSysConfigLibNull.inf > diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc > index aa40374745af..6afc10e69ef5 100644 > --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc > +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc > @@ -51,6 +51,7 @@ [LibraryClasses.common] > VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf > VirtioMmioDeviceLib|OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceLib.inf > QemuFwCfgLib|ArmVirtPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > + QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf > > ArmPlatformLib|ArmVirtPkg/Library/ArmQemuRelocatablePlatformLib/ArmQemuRelocatablePlatformLib.inf > ArmPlatformSysConfigLib|ArmPlatformPkg/Library/ArmPlatformSysConfigLibNull/ArmPlatformSysConfigLibNull.inf > -- > 2.9.3 > >