From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6615D21A07A82 for ; Fri, 4 Jan 2019 00:43:53 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id b5so691681iti.2 for ; Fri, 04 Jan 2019 00:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FsQMemM+XieLxLlhUM3Ird5sb6BgWZGaK8yVcX4dEhg=; b=BaW2xcsvyjxpSFHTtestN7VvpQ5dv12LO3EPH3id2jSLTYmx3JOv1ZEiP3ycZG1DQ6 7wbrzO22urLW3hPVgH7Ea/wj8BckzlIwIRp55XKEDWpaUMOsFNTfi8d3SOGeFgXMvyiR lEudDLBYlNKmFyCiPD0t/BBuwtCdN92QVlhm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FsQMemM+XieLxLlhUM3Ird5sb6BgWZGaK8yVcX4dEhg=; b=k7QQ284tjFZqnJ2c1D2v8rosjL+rGpSUc3CcTpQtLndZs3IcER+6yV2ssXsD+nOMPB MZ0FDkTXwkHQx9fogcweAAkWtm1EQYxJMun92rgWQ+aFbZhd0Q7AaY18AabmrEeWqpp5 Ign5ggUhRO9KhMRcRKEKdLttc+Pz0/Zd0CB0laoewfmXoiNM7HXDkCqV7/+HQbQkM7V9 A15O3aqqG8gw9LSG1sRIMXlDZxyI/fdnKOk2eeeZEoxnt9Dkzn2BI2UFY2PEN8K3iTRx cbXfAs3H01Zb+8hWTNO05IZxTYCn+34rXagS84iUWIW8Xd002snnenrVkZNi08N3pfNp 8vpg== X-Gm-Message-State: AJcUuke23OThVangAO/LS7HNMQoBb0AXDje7sJW9NcAiguw/zC4ahDnk Ino0wIGFkiXMe6IZBe+BzMqi5LO2/1/Lj4sgreu+xQ== X-Google-Smtp-Source: ALg8bN5XHCAk2zbI6stEd4S52zvfu1Z/2WmLA1fwtlAXrZrEQTagri1D/fd2ww8S8zzFtaFK1Pajvf6ME0kIfgHG7s4= X-Received: by 2002:a02:4c9:: with SMTP id 192mr25854770jab.2.1546591432980; Fri, 04 Jan 2019 00:43:52 -0800 (PST) MIME-Version: 1.0 References: <20190103121315.19416-1-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Fri, 4 Jan 2019 09:43:41 +0100 Message-ID: To: "Carsey, Jaben" , "Feng, Bob C" Cc: "edk2-devel@lists.01.org" , "Gao, Liming" Subject: Re: [PATCH] BaseTools/GenFds: permit stripped MM_CORE_STANDALONE binaries X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2019 08:43:54 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 3 Jan 2019 at 17:05, Carsey, Jaben wrote: > > Reviewed-by: Jaben Carsey > > Thanks all Pushed as 672601cfcc6f..8ef653aa5aad > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Ard Biesheuvel > > Sent: Thursday, January 03, 2019 4:13 AM > > To: edk2-devel@lists.01.org > > Cc: Gao, Liming > > Subject: [edk2] [PATCH] BaseTools/GenFds: permit stripped > > MM_CORE_STANDALONE binaries > > > > The standalone MM core is executed in place, and resides in a > > separate execution context which may be space constrained. > > Since code and data may be mapped with different attributes for > > security reasons, the PE/COFF binary could have a section > > alignment of 4 KB. > > > > This means that any relocation data is not only useless, but it > > will also take up 4 KB of valuable space. > > > > So add support for the RELOCS_STRIPPED attribute on FFS files of > > this type, so that we can get rid of the .reloc section altogether. > > Combined with the FIXED attribute (which enables an optimization > > in GenFfs that strips redundant padding) and a TE type binary, this > > gets rid of all the needless padding around the standalone MM core > > binary. > > > > Cc: Bob Feng > > Cc: Liming Gao > > Cc: Jagadeesh Ujja > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > BaseTools/Source/Python/GenFds/EfiSection.py | 2 +- > > BaseTools/Source/Python/GenFds/FdfParser.py | 2 +- > > BaseTools/Source/Python/GenFds/FfsInfStatement.py | 2 +- > > 3 files changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/BaseTools/Source/Python/GenFds/EfiSection.py > > b/BaseTools/Source/Python/GenFds/EfiSection.py > > index f8573b5c7d1b..0be176ec8ae1 100644 > > --- a/BaseTools/Source/Python/GenFds/EfiSection.py > > +++ b/BaseTools/Source/Python/GenFds/EfiSection.py > > @@ -68,7 +68,7 @@ class EfiSection (EfiSectionClassObject): > > StringData = FfsInf.__ExtendMacro__(self.StringData) > > ModuleNameStr = FfsInf.__ExtendMacro__('$(MODULE_NAME)') > > NoStrip = True > > - if FfsInf.ModuleType in (SUP_MODULE_SEC, > > SUP_MODULE_PEI_CORE, SUP_MODULE_PEIM) and SectionType in > > (BINARY_FILE_TYPE_TE, BINARY_FILE_TYPE_PE32): > > + if FfsInf.ModuleType in (SUP_MODULE_SEC, > > SUP_MODULE_PEI_CORE, SUP_MODULE_PEIM, > > SUP_MODULE_MM_CORE_STANDALONE) and SectionType in > > (BINARY_FILE_TYPE_TE, BINARY_FILE_TYPE_PE32): > > if FfsInf.KeepReloc is not None: > > NoStrip = FfsInf.KeepReloc > > elif FfsInf.KeepRelocFromRule is not None: > > diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py > > b/BaseTools/Source/Python/GenFds/FdfParser.py > > index e000228d2f6c..de0b166030e7 100644 > > --- a/BaseTools/Source/Python/GenFds/FdfParser.py > > +++ b/BaseTools/Source/Python/GenFds/FdfParser.py > > @@ -2589,7 +2589,7 @@ class FdfParser: > > # > > @staticmethod > > def _FileCouldHaveRelocFlag (FileType): > > - if FileType in {SUP_MODULE_SEC, SUP_MODULE_PEI_CORE, > > SUP_MODULE_PEIM, 'PEI_DXE_COMBO'}: > > + if FileType in {SUP_MODULE_SEC, SUP_MODULE_PEI_CORE, > > SUP_MODULE_PEIM, SUP_MODULE_MM_CORE_STANDALONE, > > 'PEI_DXE_COMBO'}: > > return True > > else: > > return False > > diff --git a/BaseTools/Source/Python/GenFds/FfsInfStatement.py > > b/BaseTools/Source/Python/GenFds/FfsInfStatement.py > > index c1073c96e9aa..d4c61c074963 100644 > > --- a/BaseTools/Source/Python/GenFds/FfsInfStatement.py > > +++ b/BaseTools/Source/Python/GenFds/FfsInfStatement.py > > @@ -901,7 +901,7 @@ class FfsInfStatement(FfsInfStatementClassObject): > > # @retval string File name of the generated section file > > # > > def __GenComplexFileSection__(self, Rule, FvChildAddr, FvParentAddr, > > IsMakefile = False): > > - if self.ModuleType in (SUP_MODULE_SEC, SUP_MODULE_PEI_CORE, > > SUP_MODULE_PEIM): > > + if self.ModuleType in (SUP_MODULE_SEC, SUP_MODULE_PEI_CORE, > > SUP_MODULE_PEIM, SUP_MODULE_MM_CORE_STANDALONE): > > if Rule.KeepReloc is not None: > > self.KeepRelocFromRule = Rule.KeepReloc > > SectFiles = [] > > -- > > 2.17.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel