From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 43F78211A759E for ; Wed, 16 Jan 2019 12:36:58 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id i145so5250750ita.4 for ; Wed, 16 Jan 2019 12:36:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=50pQ+Ou+26m2S9kDu+hwVEBsQi5vRdzmSQzVpK4jHMw=; b=CoEGQzDBR9BCvdWUq57xm4hK4XIGLjfnoK2rVouwNuf2uHODx9LAuamGn2Zx4z+NPg kpGTvz6dBThXYWioiSbCKmQVsFqsvwVKVsNOzjRCIvGgbwEsfI5Lnou/G3EbphlhSEt+ 2TkIpE3n/DAOa69ZV2rP97brd0TqTTcjItVQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=50pQ+Ou+26m2S9kDu+hwVEBsQi5vRdzmSQzVpK4jHMw=; b=lcGuMjsV8y4T5NuoE5rGhe6z16W/LzWamo0/O80t5w3qetJ1Tc2Eb2qD4mUETOlFaQ J+aESHSCpSALFbtv260X22r8lFfSHcjF2GJHMlXlVHrRzE+TmblncvfajdVhyLgK72k/ AHD4aRMFs0yBU61yW8NzOsEQLkkQ8dv3UQuxsz7xugPWUwD1Wx7skLqu0wXW2ZF+nwXL 7yytgT6r9kO/kD12buG+E6tr6T/8xCRK7Lw0Vzqxn7hkWu4edxk41vxkmWVbFkRISZww YwvhlObS/uGivIUc3emtbk5gp1cdM5LWhiznowdtiz9v+CbFbw6lFcJouY2489dJQXT5 mQ1A== X-Gm-Message-State: AJcUukdn+yC5vBYZngjFkZJx59/C6r64at0IJnEpggamTlNBQ0dWFFX7 hfNCBBlK9YSihKBM0f5IPPUD5YrSuSQ0ZAITpCQHu1q9fkfohg== X-Google-Smtp-Source: ALg8bN62JgZm8QlX1hfqcjjfhS4gszELVoTEsKg4cQe1eX/6diux0NCzgFl+blZ8XwaDbvhkZTEtIwUEmV1tTZapksk= X-Received: by 2002:a24:edc4:: with SMTP id r187mr7345424ith.158.1547671018069; Wed, 16 Jan 2019 12:36:58 -0800 (PST) MIME-Version: 1.0 References: <20190115082345.3711-1-ard.biesheuvel@linaro.org> In-Reply-To: <20190115082345.3711-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Wed, 16 Jan 2019 21:36:47 +0100 Message-ID: To: "edk2-devel@lists.01.org" Cc: Leif Lindholm , Laszlo Ersek Subject: Re: [PATCH v2 0/5] ArmPkg: use console for minimal 'exception occurred' message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 20:36:59 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 15 Jan 2019 at 09:23, Ard Biesheuvel wrote: > > When running with a graphical console, no message whatsoever is printed > when the systems hits an unexpected exception and hangs, because even > the minimal 'exception occurred' message is only sent to the serial port. > > So let's fix that, by updating DefaultExceptionHandlerLib to take the > availability of a console into account. (#5) > > This requires some preparatory decruftication so that we can safely refer > to the system table and console (#1 .. #4). > > Changes since v1: > - split off ArmVirtPkg patch (#3) > - always send minimal error message to the serial port before attempting to > send it to console->stdout as well (which is more likely to fail) (#5) > - add Leif's R-b to the series > > Ard Biesheuvel (5): > ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling > ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context > ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase > ArmPkg/DefaultExceptionHandlerLib: drop BASE variant > ArmPkg/DefaultExceptionHandlerLib: use console if available > Series pushed as 47d977733137 ArmPkg/DebugAgentSymbolsBaseLib: remove exception handling 74a12eae9f2c ArmPkg/DefaultExceptionHandlerLib: declare the permitted usage context ef9f0bff477f ArmVirtPkg: drop reference to ArmPkg/DefaultExceptionHandlerLibBase 1e32c49718c6 ArmPkg/DefaultExceptionHandlerLib: drop BASE variant 31f5388006fc ArmPkg/DefaultExceptionHandlerLib: use console if available after applying the changes suggested by Laszlo. I failed to include Laszlo's R-b in 3/5, apologies for that.