From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 777A41A1E6F for ; Wed, 12 Oct 2016 01:36:30 -0700 (PDT) Received: by mail-it0-x236.google.com with SMTP id k64so24304261itb.0 for ; Wed, 12 Oct 2016 01:36:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2PAgPM12mM8u5w8S7KIgmxnxHrBCpMB+6Ci+eoat4i0=; b=hI/pMoTOf8TLhEIOwuFJa6fpfk+pGkJe92TXCSUTXLhzQEdVPI3mm7QTcxmnl6vbAu 9XtjkAux7jFHsXgTYNFEsA5hiW7exckQ1Bpj3ZpLtV/io2MM4vdRLTVo90R/GjZIPtAS BL6SBZKfK3p5JVAv7zlsWRHEfVaB6NeJx7k8w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2PAgPM12mM8u5w8S7KIgmxnxHrBCpMB+6Ci+eoat4i0=; b=eyWWUehQnophVL3JDJDTpS5THHGZ419jyUdWEwZIgLBHseVgz7VBL25/nPwcs+d1Gf hAld3/bxRCxhNTCcF+t3jauV5vrXOT8pPSG1eBAifyFMwaXWs/SZFIsX80eXuLt6U4MH oRiQmHTXz2VtPnmL0oRoNLx5HPHNZFG9VzqQ27hLizuiHsUfxquC4QDo44EuARDE11c4 /+tA9nZ4osouSxhy0M22W/B++TEMzFK0jDYRypspH7IPHsNmT+Dldr9a6o8uf3/dNDWU v0z2m5GxSU/1Rs+GZod9qvhvH0Yw5lMXtCRB5VZLIQRSb4mio0W79jCg1FnpxaWUHJKm vEQg== X-Gm-Message-State: AA6/9Rkv9nO9hd+lMhDZJWtcSzlLzmxO4kvVVUS/BCcNTpXeAI4OPBFiwabpksmQOnG5EHoFwjsN/hdA27ONeoOy X-Received: by 10.36.37.20 with SMTP id g20mr317955itg.63.1476261389815; Wed, 12 Oct 2016 01:36:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.5.139 with HTTP; Wed, 12 Oct 2016 01:36:29 -0700 (PDT) In-Reply-To: References: <20161011050113.197540-1-ruiyu.ni@intel.com> <734D49CCEBEEF84792F5B80ED585239D58E29EAD@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 12 Oct 2016 09:36:29 +0100 Message-ID: To: Laszlo Ersek Cc: "Ni, Ruiyu" , "edk2-devel@lists.01.org" Subject: Re: [PATCH] MdeModulePkg/MdeModulePkg.dec: Fix EBC build failure of PciBus driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 08:36:30 -0000 Content-Type: text/plain; charset=UTF-8 On 12 October 2016 at 08:08, Laszlo Ersek wrote: > On 10/12/16 04:36, Ni, Ruiyu wrote: >> I agree with Ard. Building PciBusDxe driver as EBC ARCH is supported from tool perspective, but doesn't >> make much sense in real world. >> So the patch is just to resolve the build failure in EBC ARCH. > > If Ard is fine with the EBC default for > PcdPciDegradeResourceForOptionRom that this patch results in, then I > don't object. > > Acked-by: Laszlo Ersek > Yes, I am fine with that, as long as the default remains FALSE for AARCH64 Acked-by: Ard Biesheuvel