From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E880D20945BF7 for ; Tue, 12 Sep 2017 08:35:48 -0700 (PDT) Received: by mail-it0-x232.google.com with SMTP id c195so30252643itb.1 for ; Tue, 12 Sep 2017 08:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=I8XK7XWG2y2cvlaadqO5F408r2VhKV+UyWUf22tUapc=; b=i5G/HbY31oOPjohWJ1mX9e9ej+5HDVUZwfJWRo5T5MuUDsn15W0OrhG1lXiJJuM0/o Y5DqNM0h//PSxYwCZyzVgSRzx46NW6dz7AZOmNtsQEP7CjdPVrIn4yNq9CzEZgHYQO5E SgJCJDNSJSoEh3odpTompAgnrjMEKN4cJdwc8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=I8XK7XWG2y2cvlaadqO5F408r2VhKV+UyWUf22tUapc=; b=Z2L3oYkf1drvLx2UO0WlZaUaVbmSNyWj2Xgj/s9ClsBFA7yOQ+3JQlC6KN43ejtfG9 XexqPfF4uRvMfvHRDc4sUTzkwStXSAFk/TO9RNGSFuoodp9JrdTa3447ncpm4/lZgA9t ck82h9yU2a0C5Mu/pMgXyizSMvg2quo3TN7Ov63l/Z+Z9yRXOxCSaTiBRmewNCiO16ZU RBWEc/J3hrRaE9pHIVYaDrBxsCqGKw9PaAvowqgdE0gWVf8UAFXYhQlO5btOPoY1wt0F CzIBMcoCPvw/h0A+Mcxdbq1+cpF1sihLUAh0wUktUaYR4M0qCcGBpZuta5tTDf5sjKWF IRPQ== X-Gm-Message-State: AHPjjUiPMyLU4GfM06EjrnxOwFZxVrPGBgUWkeHPwMXngpjnMW68ClRT O/Uy6qJagsmn4/F8utEEsO8eE2LV2b9Ae46cPu1Njw== X-Google-Smtp-Source: AOwi7QAbg+yXdHbNYAWBp7CSiRt1zdkfwWZz+AJlNHR1ChA6F6U+vHmmkdHGQzpT7P/oMRPD/jwUEHS3d9amuAHpYXs= X-Received: by 10.36.11.196 with SMTP id 187mr3691itd.48.1505230724899; Tue, 12 Sep 2017 08:38:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.152.18 with HTTP; Tue, 12 Sep 2017 08:38:44 -0700 (PDT) In-Reply-To: <6bc51f3f-8b97-3a24-1ccf-aeb838eedb6f@redhat.com> References: <20170910001304.8628-1-lersek@redhat.com> <6bc51f3f-8b97-3a24-1ccf-aeb838eedb6f@redhat.com> From: Ard Biesheuvel Date: Tue, 12 Sep 2017 08:38:44 -0700 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Ruiyu Ni , Eric Dong , Star Zeng Subject: Re: [PATCH 0/5] MdeModulePkg: UDF fixes and cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Sep 2017 15:35:49 -0000 Content-Type: text/plain; charset="UTF-8" On 12 September 2017 at 03:14, Laszlo Ersek wrote: > On 09/10/17 02:12, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: udf_fixes_cleanups >> >> Patches #2, #3 and #4 are needed (and enough) for me to build OVMF for >> IA32 and X64 with clang-3.8, after the UDF introduction. >> >> Patches #1 and #5 are cleanups that I felt fit before patch #2 and after >> patch #4, respectively. >> >> Cc: Ard Biesheuvel >> Cc: Eric Dong >> Cc: Paulo Alcantara >> Cc: Ruiyu Ni >> Cc: Star Zeng >> >> Thanks >> Laszlo >> >> Laszlo Ersek (5): >> MdeModulePkg/UdfDxe: ASSERT() valid ReadFileInfo Flags for INLINE_DATA >> req >> MdeModulePkg/UdfDxe: don't return unset Status if INLINE_DATA req >> succeeds >> MdeModulePkg/UdfDxe: replace zero-init of local variables with >> ZeroMem() >> MdeModulePkg/PartitionDxe: don't divide 64-bit values with C operators >> MdeModulePkg/PartitionDxe: remove always false comparison >> >> MdeModulePkg/Universal/Disk/PartitionDxe/Udf.c | 9 +++++++-- >> MdeModulePkg/Universal/Disk/UdfDxe/File.c | 6 ++++-- >> MdeModulePkg/Universal/Disk/UdfDxe/FileSystemOperations.c | 5 +++++ >> 3 files changed, 16 insertions(+), 4 deletions(-) >> > > Thanks all for the feedback, pushed as commit range > c05cae55ebd8..b4e5807d2492. > > (I didn't change the sizeof / sizeof() stuff -- for one, I didn't want > to touch the code on such an urgent push, relative to the posted and > tested version.) > Rather unexpectedly, the build is still broken on my CI system This time, it is GCC 4.8 that complains about uninitialized variables, most likely false positives again (apologies for the letter soup) : In function 'ReadFile': :876:27: error: 'Status' may be used uninitialized in this function [-Werror=maybe-uninitialized] EFI_STATUS Status; ^ "/home/buildslave/srv/toolchain/arm-tc-14.04/bin/arm-linux-gnueabihf-gcc" -mthumb -mcpu=cortex-a15 -I -g -Os -fshort-wchar -fno-builtin -fno-strict-aliasing -Wall -Werror -Wno-array-bounds -include AutoGen.h -fno-common -mlittle-endian -mabi=aapcs -fno-short-enums -funsigned-char -ffunction-sections -fdata-sections -fomit-frame-pointer -Wno-address -mthumb -mfloat-abi=soft -fno-pic -fno-pie -fstack-protector -mword-relocations -Wno-unused-but-set-variable -DMDEPKG_NDEBUG -DDISABLE_NEW_DEPRECATED_INTERFACES -c -o -I -I -I -I -I -I -I :887:27: error: 'BytesLeft' may be used uninitialized in this function [-Werror=maybe-uninitialized] UINT64 BytesLeft; ^ cc1: all warnings being treated as errors