From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8C0322217CE25 for ; Wed, 6 Dec 2017 12:45:44 -0800 (PST) Received: by mail-it0-x242.google.com with SMTP id f190so9351827ita.5 for ; Wed, 06 Dec 2017 12:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LJf7Jt8LM0Csha+IS7elStdSGkgvj8QPQJHKCrtkZyM=; b=Zf0snr08GKhPSPWrS5rabfgtqMA7iyzTzQGgQ/XpPeyLQ/PA0FBO2oDTyGlJ3RyxXy JZoqkRV6sYFVoznJ28YavKfwsrKRIUDyUmoi7jn+XJzqpIOHZi5CFrfofIU+4w4qYNP5 1pVaCi0Lcj3Mygkl1zxTSN5NZPpDpA3ITKrxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LJf7Jt8LM0Csha+IS7elStdSGkgvj8QPQJHKCrtkZyM=; b=iZGOCZLAuRhVXhHwWztR5YlQFn5xgR6H5Z6qECkXlgoHApeXwLeSiUY1ICuyc851DQ wcgYjaVydK4XE0aZUP0Ng+q3OZ4gdToEeCxaTazD8TkJuCBOpMhMvx3bCsKGXoltQItQ TSobHx3HApqbVGfAtQ+pSSRjsctKdG8woPe5K1bCxGQi/dc/0wIWHB1wxQ2CccrHrt4L b94cAdZSKg6xgwoFGvN7sKmy3eAs2fByYQshQF2biQF/trs6S751zRki6px3El+qDWHV 8SmYDMnznw75I9VD2ngIkvVdtFivN/Esv+s7y2QQYIuo1EqF0vVNBH+QDO2kMj7SyLrE CNUQ== X-Gm-Message-State: AKGB3mIjEMIyAd5zYSjHZSWv6YTqDDrTX0N0O1vw5qC82a288XJokSZF 0S7mVisehD6mwJP45spFJmagi6Quq2SxjOIXKfW5lA== X-Google-Smtp-Source: AGs4zMZAnZ50h5dhXVgsMFEV6+BfZEr83zixUqbkSU2tgxHH3ws965h1mQo0+XblELrra9/d1unvv7UPMlT9keontVQ= X-Received: by 10.36.31.212 with SMTP id d203mr14673479itd.48.1512593416221; Wed, 06 Dec 2017 12:50:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Wed, 6 Dec 2017 12:50:15 -0800 (PST) In-Reply-To: <3e8723e4-111b-2a31-8b07-2545434c3b9f@redhat.com> References: <20171206113711.6040-1-ard.biesheuvel@linaro.org> <3e8723e4-111b-2a31-8b07-2545434c3b9f@redhat.com> From: Ard Biesheuvel Date: Wed, 6 Dec 2017 20:50:15 +0000 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH] ArmVirtPkg: add NOOPT target to platform .DSCs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2017 20:45:44 -0000 Content-Type: text/plain; charset="UTF-8" On 6 December 2017 at 14:14, Laszlo Ersek wrote: > On 12/06/17 12:37, Ard Biesheuvel wrote: >> In order to allow the ArmVirtPkg platforms to be built using the >> NOOPT target, add it explicitly to the BUILD_TARGETS define. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> ArmVirtPkg/ArmVirtQemu.dsc | 2 +- >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +- >> ArmVirtPkg/ArmVirtXen.dsc | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index f09226671827..76a83b99a303 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -25,7 +25,7 @@ [Defines] >> DSC_SPECIFICATION = 0x00010005 >> OUTPUT_DIRECTORY = Build/ArmVirtQemu-$(ARCH) >> SUPPORTED_ARCHITECTURES = AARCH64|ARM >> - BUILD_TARGETS = DEBUG|RELEASE >> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT >> SKUID_IDENTIFIER = DEFAULT >> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemu.fdf >> >> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> index cc2c5a50c925..7d9a9196d640 100644 >> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> @@ -25,7 +25,7 @@ [Defines] >> DSC_SPECIFICATION = 0x00010005 >> OUTPUT_DIRECTORY = Build/ArmVirtQemuKernel-$(ARCH) >> SUPPORTED_ARCHITECTURES = AARCH64|ARM >> - BUILD_TARGETS = DEBUG|RELEASE >> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT >> SKUID_IDENTIFIER = DEFAULT >> FLASH_DEFINITION = ArmVirtPkg/ArmVirtQemuKernel.fdf >> >> diff --git a/ArmVirtPkg/ArmVirtXen.dsc b/ArmVirtPkg/ArmVirtXen.dsc >> index 9b3cc2bd5a10..175b56d10c8f 100644 >> --- a/ArmVirtPkg/ArmVirtXen.dsc >> +++ b/ArmVirtPkg/ArmVirtXen.dsc >> @@ -25,7 +25,7 @@ [Defines] >> DSC_SPECIFICATION = 0x00010005 >> OUTPUT_DIRECTORY = Build/ArmVirtXen-$(ARCH) >> SUPPORTED_ARCHITECTURES = AARCH64|ARM >> - BUILD_TARGETS = DEBUG|RELEASE >> + BUILD_TARGETS = DEBUG|RELEASE|NOOPT >> SKUID_IDENTIFIER = DEFAULT >> FLASH_DEFINITION = ArmVirtPkg/ArmVirtXen.fdf >> >> > > Reviewed-by: Laszlo Ersek Thanks. Pushed as 80ee06cee70c