From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=X6mf5nVd; spf=pass (domain: linaro.org, ip: 209.85.166.196, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196]) by groups.io with SMTP; Thu, 04 Apr 2019 08:26:49 -0700 Received: by mail-it1-f196.google.com with SMTP id f22so4342478ita.3 for ; Thu, 04 Apr 2019 08:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gBy+O15CBHbbZ0tEOUCPgbGxCWWL7sK0qVr/RZT+lXk=; b=X6mf5nVdGDdsqPr+JY4262D3Z+bnEKJZTt+nH2ckTrsOJbfPB6IlK1fQVyAyT188Ro /6kPF1UmxUCTXNFs/rliPjQK5IUf5/Cmk+YrV99i5gfnD4SfgDlyEUYKaGZc9c2zUvlI JgVMZseJq70fOX3WJMFBfL5qa1cRIB9rXGmGAB8b6rnnsnqQGy3i37Pi3sUST+gUFbYw bpw8FB9SJJJY9eqmlIAaBZ+ledrPDj0a0lrvDGmLORJV22+zYLthXhg2ZUEtLpLosjtV sQz14XmAJ2rJy1pVGf7ywxk+og6kGJDuBeCOYbm7rxlrKmlcHoES/HWbeyiwCTRsd4EG bmuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gBy+O15CBHbbZ0tEOUCPgbGxCWWL7sK0qVr/RZT+lXk=; b=elqz25EaSaDgnLrUq82pUaKwq27E+QpmlDOuD/5FoY5jQFYpL54I5Te0aTygryX/R5 fPvUDA97lF6K9t4Lw971wJtFLTsak7XKmywhbT0OQt1bE8/aOaXWGXC/BoFZVGZ4D/g7 qJYTtAYg37aay/oeTe2cpngStrgJcmOtBDdfR+r5Pm9sHc9Fz7WoM9uuqUqDK0aCSYV4 gAOCS5++kUsN9N4FCBqn/iluhnlD0epcG3d6jI7QObYDhOhi1sRfu17ulgHaEsmmqDKR 7oAMubC7lck9VDZrlyBeCN5ZD+G3m5sF/QmBUysP6Bx7E1Sx+XxV41bNTBR9fu8EUNOH BKCA== X-Gm-Message-State: APjAAAXwfWDs/z3wTKy/3To9t459EdKASvYaM14j/0oCTH6hzbRUSnZ2 qRJ4fuW3T0dxPZmW/Usa52+pP0Vdog5bB3Dj0VDwvA== X-Google-Smtp-Source: APXvYqx6lIARXtrQ1evcbckmsXjNB7ExZ1V223jISKLfGbP0dnr2tYBXpX4a4qVNfriFKjf+fGbpKW1EnDOI6N6jfCc= X-Received: by 2002:a24:41cd:: with SMTP id b74mr5554891itd.100.1554391608383; Thu, 04 Apr 2019 08:26:48 -0700 (PDT) MIME-Version: 1.0 References: <20190404135209.13116-1-dandan.bi@intel.com> <20190404135209.13116-3-dandan.bi@intel.com> In-Reply-To: <20190404135209.13116-3-dandan.bi@intel.com> From: "Ard Biesheuvel" Date: Thu, 4 Apr 2019 22:26:37 +0700 Message-ID: Subject: Re: [patch 2/7] BeagleBoardPkg: Update UefiDecompressLib instance To: Dandan Bi Cc: devel@edk2.groups.io, Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Thu, 4 Apr 2019 at 20:52, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683 > > BaseUefiDecompressLib in MdePkg is the > base UEFI decompress Library. > BaseUefiTianoCustomDecompressLib in IntelFrameworkModulePkg > implements the base UEFI decompress functionality and > Tiano decompress functionality. > > 1. TIANOCOMPRESSED rule in BeagleBoardPkg.fdf > is not used, so remove it. > 2. Platform doesn't use the TianoCompress, so do > not have to use BaseUefiTianoCustomDecompressLib, > can use the BaseUefiDecompressLib in MdePkg directly. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > BeagleBoardPkg/BeagleBoardPkg.dsc | 4 ++-- > BeagleBoardPkg/BeagleBoardPkg.fdf | 9 --------- > 2 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/BeagleBoardPkg/BeagleBoardPkg.dsc b/BeagleBoardPkg/BeagleBoardPkg.dsc > index e0fee3692f..e5fbe7eeb2 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -185,17 +185,17 @@ > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > [LibraryClasses.common.UEFI_APPLICATION] > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > > [LibraryClasses.common.UEFI_DRIVER] > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf > - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf > + UefiDecompressLib|MdePkg/Library/BaseUefiDecompressLib/BaseUefiDecompressLib.inf > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] Can we add a single UefiDecompressLib resolution to the common section and drop all the others? > diff --git a/BeagleBoardPkg/BeagleBoardPkg.fdf b/BeagleBoardPkg/BeagleBoardPkg.fdf > index 42d6bad0c7..9c9cecf894 100644 > --- a/BeagleBoardPkg/BeagleBoardPkg.fdf > +++ b/BeagleBoardPkg/BeagleBoardPkg.fdf > @@ -262,19 +262,10 @@ READ_LOCK_STATUS = TRUE > PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > } > > -[Rule.Common.PEIM.TIANOCOMPRESSED] > - FILE PEIM = $(NAMED_GUID) DEBUG_MYTOOLS_IA32 { > - PEI_DEPEX PEI_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > - GUIDED A31280AD-481E-41B6-95E8-127F4C984779 PROCESSING_REQUIRED = TRUE { > - PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > - UI STRING="$(MODULE_NAME)" Optional > - } > - } > - > [Rule.Common.DXE_CORE] > FILE DXE_CORE = $(NAMED_GUID) { > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > } > -- > 2.18.0.windows.1 > With the above update: Reviewed-by: Ard Biesheuvel