From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68])
 by mx.groups.io with SMTP id smtpd.web10.13844.1583155018430960410
 for <devel@edk2.groups.io>;
 Mon, 02 Mar 2020 05:16:58 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=o47jpVsh;
 spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f68.google.com with SMTP id m3so10635608wmi.0
        for <devel@edk2.groups.io>; Mon, 02 Mar 2020 05:16:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=AGk1SLkPhNzABKEPGDzbgk49ooMnMqYh1pNzbO8BmBg=;
        b=o47jpVshIe8ZMg6F2fthS65Wv83XFK0rk+kKjxoU6X0CAbcI8eMUIhENLUu6g+Dsrp
         Di5D3AeJQbrcheZ1UcBArOarTMOefH2QWt+/FCediXiMf0vU02N+I8S0wsiBwNypZZXE
         6LRaL51VeLq1pTSwL2nxGHOjz5S/2oEDhI77A4nYkHFHUPqvoC+BhvH3xvIaJSJYxQee
         D5Jf3RsRfkVtKG6xBc5wnpsBzM6SAUsUfkfPFzRUNpDtLk/ifeO16hlf8hTxXgsxFJpP
         gWLlfQ6uthoAsHMmwCPdGi4ooDBT65inzWQtW/8BeOywlxADxpO0SP6enYe2q5xKpgiT
         xAQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=AGk1SLkPhNzABKEPGDzbgk49ooMnMqYh1pNzbO8BmBg=;
        b=ivR4ltmFLPfPHL3v5Mdq+fYFc4riqUkJQ8pzRrZcm/tx1xlaLaY5HMQWgkULFmyR8p
         7vxd0yaeAf0YkrpO5fSGqY9xV1xJCwXyCNvnoFmHuBm7VGX0QY0hux3TaS3i9WbK7xoi
         h1NZqjP09QnlRoPKBHcassHeotOaeWCaZ3VV/rRqcjkBGraVs1EvC1Js5j9ELzA7WZPK
         qjQU6bEEXroTcB/+C/dmGaGA/2qy2zMV0yi94FvldjrWp7C0nn+i9F6pDv4msOVDrr+i
         6s+QrpNOUD2/5hOpearyBTS5NoYVQbPNEQVW0RFcR6J6CrI5rwg0sG37VUjFRbGLj3yf
         EWDg==
X-Gm-Message-State: APjAAAV5H1USykYUJq45ep3Mx4FE7tjRNQ7ybbuz/A7kHs+81Kt07JZQ
	3+8aC54caSnq5Tpva4yzU8Xk6KlizwCtHBiWovvRnQ==
X-Google-Smtp-Source: APXvYqxo/5n7X4OdODfC1FGgc7PCTgHeEXOT/OuGpF0wjRbvUsYW1i/uK5P7LEdFptnqHK/SGs5wvb8NrXLo/0HJNOc=
X-Received: by 2002:a1c:bc46:: with SMTP id m67mr19172233wmf.40.1583155017020;
 Mon, 02 Mar 2020 05:16:57 -0800 (PST)
MIME-Version: 1.0
References: <20200226100353.31962-1-ard.biesheuvel@linaro.org>
 <20200226100353.31962-7-ard.biesheuvel@linaro.org> <20200302131321.GK23627@bivouac.eciton.net>
In-Reply-To: <20200302131321.GK23627@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Mon, 2 Mar 2020 14:16:46 +0100
Message-ID: <CAKv+Gu875jaa48Bhvb7WP_-BEpVorVCb-56YAhcdp3jAG=maTA@mail.gmail.com>
Subject: Re: [PATCH 6/6] ArmPkg/ArmLib: deprecate set/way cache maintenance routines
To: Leif Lindholm <leif@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Laszlo Ersek <lersek@redhat.com>, 
	Sami Mujawar <sami.mujawar@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Mon, 2 Mar 2020 at 14:13, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Feb 26, 2020 at 11:03:53 +0100, Ard Biesheuvel wrote:
> > Cache maintenance on ARMv7 systems and up should be done by virtual
> > address if the purpose is to manage the cached state of contents of
> > memory. Set/way operations are only intended to maintain the caches
> > themselves, e.g., to ensure that the contents of dirty cachelines
> > are brought to main memory before the core is powered off entirely.
> >
> > UEFI on ARM is typically not involved in the latter at all, and any
> > cache maintenance it does is to ensure that the memory it occupies
> > and modifies remains in a consistent state with respect to the
> > caches.
> >
> > So let's deprecate the set/way routines now that we have removed all
> > uses of it in the core code.
>
> Does this patch simply get dropped in favour of the ASSERT variant?
>

Yes.

But I realised that we still need a fix for CmdRunAxf in that case :-(