public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Ming Huang <ming.huang@linaro.org>,
	wanghuiqiang <wanghuiqiang@huawei.com>
Subject: Re: [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description
Date: Wed, 27 Mar 2019 07:57:16 +0100	[thread overview]
Message-ID: <CAKv+Gu88YKiWxQQf0V-ta=F_X2=Rjrz51f6TM2kF_3_Ds4b1dg@mail.gmail.com> (raw)
In-Reply-To: <20190326202245.15061-1-leif.lindholm@linaro.org>

On Tue, 26 Mar 2019 at 21:22, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Since the D06 port now depends on updated IMP firmware to function
> properly, there needs to be a one-way upgrade path. Upgrade to the
> current state of things must happen via .hpm. Subsequent capsule updates
> cannot be permitted to go below this version.
>
> So update the firmware descriptor to Version: 3 and
> LowestSupportedFirmwareVersion: 3.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> Ming: I would also be cherry-picking this patch into RPF 19.03.
>
>  Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> index 36175338dd..1287dfd834 100644
> --- a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> +++ b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> @@ -22,9 +22,9 @@
>  #define PACKAGE_VERSION                     0xFFFFFFFF
>  #define PACKAGE_VERSION_STRING              L"Unknown"
>
> -#define CURRENT_FIRMWARE_VERSION            0x00000002
> -#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000002"
> -#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000001
> +#define CURRENT_FIRMWARE_VERSION            0x00000003
> +#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000003"
> +#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000003
>
>  #define IMAGE_ID                            SIGNATURE_64('H','W','A', 'R', 'M', '_', 'F', 'd')
>  #define IMAGE_ID_STRING                     L"ARMPlatformFd"
> --
> 2.11.0
>


      reply	other threads:[~2019-03-27  6:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 20:22 [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description Leif Lindholm
2019-03-27  6:57 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu88YKiWxQQf0V-ta=F_X2=Rjrz51f6TM2kF_3_Ds4b1dg@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox