public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description
@ 2019-03-26 20:22 Leif Lindholm
  2019-03-27  6:57 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Leif Lindholm @ 2019-03-26 20:22 UTC (permalink / raw)
  To: edk2-devel; +Cc: Ming Huang, wanghuiqiang, Ard Biesheuvel

Since the D06 port now depends on updated IMP firmware to function
properly, there needs to be a one-way upgrade path. Upgrade to the
current state of things must happen via .hpm. Subsequent capsule updates
cannot be permitted to go below this version.

So update the firmware descriptor to Version: 3 and
LowestSupportedFirmwareVersion: 3.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---

Ming: I would also be cherry-picking this patch into RPF 19.03.

 Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
index 36175338dd..1287dfd834 100644
--- a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
+++ b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
@@ -22,9 +22,9 @@
 #define PACKAGE_VERSION                     0xFFFFFFFF
 #define PACKAGE_VERSION_STRING              L"Unknown"
 
-#define CURRENT_FIRMWARE_VERSION            0x00000002
-#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000002"
-#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000001
+#define CURRENT_FIRMWARE_VERSION            0x00000003
+#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000003"
+#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000003
 
 #define IMAGE_ID                            SIGNATURE_64('H','W','A', 'R', 'M', '_', 'F', 'd')
 #define IMAGE_ID_STRING                     L"ARMPlatformFd"
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description
  2019-03-26 20:22 [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description Leif Lindholm
@ 2019-03-27  6:57 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2019-03-27  6:57 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: edk2-devel@lists.01.org, Ming Huang, wanghuiqiang

On Tue, 26 Mar 2019 at 21:22, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> Since the D06 port now depends on updated IMP firmware to function
> properly, there needs to be a one-way upgrade path. Upgrade to the
> current state of things must happen via .hpm. Subsequent capsule updates
> cannot be permitted to go below this version.
>
> So update the firmware descriptor to Version: 3 and
> LowestSupportedFirmwareVersion: 3.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>
> Ming: I would also be cherry-picking this patch into RPF 19.03.
>
>  Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> index 36175338dd..1287dfd834 100644
> --- a/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> +++ b/Platform/Hisilicon/D06/Drivers/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> @@ -22,9 +22,9 @@
>  #define PACKAGE_VERSION                     0xFFFFFFFF
>  #define PACKAGE_VERSION_STRING              L"Unknown"
>
> -#define CURRENT_FIRMWARE_VERSION            0x00000002
> -#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000002"
> -#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000001
> +#define CURRENT_FIRMWARE_VERSION            0x00000003
> +#define CURRENT_FIRMWARE_VERSION_STRING     L"0x00000003"
> +#define LOWEST_SUPPORTED_FIRMWARE_VERSION   0x00000003
>
>  #define IMAGE_ID                            SIGNATURE_64('H','W','A', 'R', 'M', '_', 'F', 'd')
>  #define IMAGE_ID_STRING                     L"ARMPlatformFd"
> --
> 2.11.0
>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-27  6:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-26 20:22 [PATCH edk2-platforms] Platform/Hisilicon: update D06 system firmware description Leif Lindholm
2019-03-27  6:57 ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox