From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Jan Dąbroś" <jsd@semihalf.com>, "Hua Jing" <jinghua@marvell.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
davidsn@marvell.com
Subject: Re: [platforms PATCH 0/4] Armada capsule support
Date: Fri, 1 Jun 2018 17:34:32 +0200 [thread overview]
Message-ID: <CAKv+Gu88btz2MxYGy9-TAnvCR=nsEYu2nDD0Q=vJibSFGR2Hzw@mail.gmail.com> (raw)
In-Reply-To: <1527863526-5494-1-git-send-email-mw@semihalf.com>
On 1 June 2018 at 16:32, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi,
>
> Hereby I submit a capsule support for Marvell Armada platforms.
> Capsule preparation must be done in two steps, it requires additional
> build flag (-D CAPSULE_ENABLE), so by default nothing changes. Also the
> solution is using generic EDK2 drivers and libraries, so all
> wiki/howtos from Tianocore are valid. Verified from within UEFI
> (CapsuleApp.efi) and standard distro fwupdate (on Debian and Fedora).
> More details can be found in the commit logs.
>
> The code is also available in the github:
> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/capsule-upstream-r20180601
>
> David Sniatkiwicz (1):
> Marvell/Armada7k8k: Introduce capsule FW update implementation
>
> Marcin Wojtas (3):
> Marvell/Armada70x0Db: Shift main FV from 0x0 address
> Marvell/Aramda7k8k: Enable PEI booting stage
> Marvell/Armada7k8k: Wire up capsule support
>
Very nice!
The code looks mostly fine to me, with a couple of minor comments.
> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 96 ++++++-
> Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.dsc | 46 ++++
> Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.fdf | 70 ++++++
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 81 +++++-
> Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.c | 261 ++++++++++++++++++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf | 52 ++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 81 ++++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 50 ++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c | 74 ++++++
> Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 26 ++
> 10 files changed, 829 insertions(+), 8 deletions(-)
> create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.dsc
> create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.fdf
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.c
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c
> create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini
>
> --
> 2.7.4
>
prev parent reply other threads:[~2018-06-01 15:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 14:32 [platforms PATCH 0/4] Armada capsule support Marcin Wojtas
2018-06-01 14:32 ` [platforms PATCH 1/4] Marvell/Armada70x0Db: Shift main FV from 0x0 address Marcin Wojtas
2018-06-01 15:26 ` Ard Biesheuvel
2018-06-01 14:32 ` [platforms PATCH 2/4] Marvell/Aramda7k8k: Enable PEI booting stage Marcin Wojtas
2018-06-01 15:30 ` Ard Biesheuvel
2018-06-01 16:43 ` Marcin Wojtas
2018-06-01 16:57 ` Ard Biesheuvel
2018-06-01 17:18 ` Marcin Wojtas
2018-06-01 14:32 ` [platforms PATCH 3/4] Marvell/Armada7k8k: Introduce capsule FW update implementation Marcin Wojtas
2018-06-01 15:32 ` Ard Biesheuvel
2018-06-01 16:02 ` Marcin Wojtas
2018-06-01 16:08 ` Ard Biesheuvel
2018-06-01 16:20 ` Marcin Wojtas
2018-06-01 14:32 ` [platforms PATCH 4/4] Marvell/Armada7k8k: Wire up capsule support Marcin Wojtas
2018-06-01 15:34 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu88btz2MxYGy9-TAnvCR=nsEYu2nDD0Q=vJibSFGR2Hzw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox