From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9C5F9207DF2A3 for ; Fri, 1 Jun 2018 08:34:33 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id d185-v6so2160824ioe.0 for ; Fri, 01 Jun 2018 08:34:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EJ0JbtH74fqej54SIWvOczLJW8jF73qsXCIXgO+wqKE=; b=e9kzSLpcm3BZaywo5+Fs6lyAqyvMSEKtZeb1FF24IImCsGiUXHQ6qAvNNatr9gCq1O Vs9VH5u+JziRbMADFZ1Hl+FIdHDrnqHp7vpk+ZbGHdworAIfBF+JGU97nhUWi4UTtJm9 abrVVycKWVOhkoWlmq1vvrgN1SviwdEkFUi3g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EJ0JbtH74fqej54SIWvOczLJW8jF73qsXCIXgO+wqKE=; b=XYuTCA4fqEpEyi49lF2Z5xmYFRRbmRI/gkhWL11J9SYj99+i/GjiyW5jYHqZsply7U 19AZ1i8Eryjx85pbQVuCTyVhSs6ALQ+6nz8g2e3jt9UpxmOoFb5xE5m5JTxKewIGADJa N5k6Nje2qBhLDLCzrFBpCxaqK8Qb8cjZrgG3n280Jx+dMauHw/VywrImLVxRmsrmal6M Tq7Igm3PhIgb45AmV8Rd+TallUmmBIeHcIr2OzYcqL31BgS7ulroJt1rmQwkJ22ejXma gxYYFy+2AkWqx7sHEOByV4/3VbBNNSAeeG4qdpPODFdHUpNevAPaL1+r3BSC68lPX1TZ Uf5w== X-Gm-Message-State: ALKqPwfzSHFq9LskPmnBxFgRDzrX11z7vEVU4d+oPb4p8YDIVznyBVVp ch5T8jSsmqevxci6dqhUAkoFFToFd+aFe0nm8uZZBA== X-Google-Smtp-Source: ADUXVKICRuSk9H1/WACx5jDX68fZPiGLuxbVgg05i14OkxxKruqR8NA1w5rWV2kj6Sb/WxLKBgv+GxUR+lnYoJBuHDs= X-Received: by 2002:a6b:dd0b:: with SMTP id f11-v6mr5265745ioc.173.1527867272898; Fri, 01 Jun 2018 08:34:32 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 08:34:32 -0700 (PDT) In-Reply-To: <1527863526-5494-1-git-send-email-mw@semihalf.com> References: <1527863526-5494-1-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Fri, 1 Jun 2018 17:34:32 +0200 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Hua Jing , Grzegorz Jaszczyk , davidsn@marvell.com Subject: Re: [platforms PATCH 0/4] Armada capsule support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 15:34:33 -0000 Content-Type: text/plain; charset="UTF-8" On 1 June 2018 at 16:32, Marcin Wojtas wrote: > Hi, > > Hereby I submit a capsule support for Marvell Armada platforms. > Capsule preparation must be done in two steps, it requires additional > build flag (-D CAPSULE_ENABLE), so by default nothing changes. Also the > solution is using generic EDK2 drivers and libraries, so all > wiki/howtos from Tianocore are valid. Verified from within UEFI > (CapsuleApp.efi) and standard distro fwupdate (on Debian and Fedora). > More details can be found in the commit logs. > > The code is also available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/capsule-upstream-r20180601 > > David Sniatkiwicz (1): > Marvell/Armada7k8k: Introduce capsule FW update implementation > > Marcin Wojtas (3): > Marvell/Armada70x0Db: Shift main FV from 0x0 address > Marvell/Aramda7k8k: Enable PEI booting stage > Marvell/Armada7k8k: Wire up capsule support > Very nice! The code looks mostly fine to me, with a couple of minor comments. > Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 96 ++++++- > Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.dsc | 46 ++++ > Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.fdf | 70 ++++++ > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 81 +++++- > Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.c | 261 ++++++++++++++++++++ > Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf | 52 ++++ > Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc | 81 ++++++ > Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf | 50 ++++ > Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c | 74 ++++++ > Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini | 26 ++ > 10 files changed, 829 insertions(+), 8 deletions(-) > create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.dsc > create mode 100644 Platform/Marvell/Armada70x0Db/Armada70x0DbCapsule.fdf > create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.c > create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/PlatformFlashAccessLib/PlatformFlashAccessLib.inf > create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.aslc > create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptor.inf > create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwareDescriptorPei.c > create mode 100644 Silicon/Marvell/Armada7k8k/Feature/Capsule/SystemFirmwareUpdateConfig/SystemFirmwareUpdateConfig.ini > > -- > 2.7.4 >