From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com
 [IPv6:2607:f8b0:4001:c06::22b])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 8D0D081F71
 for <edk2-devel@lists.01.org>; Thu,  9 Feb 2017 01:09:07 -0800 (PST)
Received: by mail-io0-x22b.google.com with SMTP id v96so12058407ioi.0
 for <edk2-devel@lists.01.org>; Thu, 09 Feb 2017 01:09:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=vezGhSF/h26P9jdes97hGFeTxQ6IoZvRD99cR61Sgw8=;
 b=aFFPfxT8ZKAIjLM2QKiqHJlSoEep1opuUdLVukoQm8b4xSsWLqUU1i/qobJ3Du7sjE
 fRnzCmhmHWF+b8CPUI+L51LldjUxziEDbiKnW1PWC1f57z4fyFZqNqmGP+oFsMId9YsE
 2VOcehlIXcNCL+9WpuxqqBadBer+IR6I+n/1Y=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=vezGhSF/h26P9jdes97hGFeTxQ6IoZvRD99cR61Sgw8=;
 b=bX9qSpxU+kmQsa0TuhSylIxY0hw1quh5q2mftTkRDy2DoKXmwhqOd+aJxBBrP0cSlk
 15lIlKu2Dv28L3s80I+W4AHfoLR0gqonqGhgNB13P8TPZZ1bWwg956AEAVcqjT94Syht
 OsmJco5/1JL+iXtkBVPotvDOFa471/21O8NTI22DDWjHKt5Ia1wk73bFKZK5eu84GZ7r
 HhxShFl34XdMb+MDal55DPmKfIsC3673ehSg19WQmpLFERL5ngqloKM/YKJv4S+8kLlz
 ROabI0KPfeK8nnHd9d1jPO2PaKF5MzGPqRWpTD2th2QR8X4xVzD6wI2He2fJSVRuW8Gc
 48mA==
X-Gm-Message-State: AMke39nNshKSqXSrEhENw9KRkQ12LHyQXQkg4cQggJJMA6A7WkIhU5zzg6LRLCZtM+7NNsWwnewXXbRpeJip/lun
X-Received: by 10.107.53.17 with SMTP id c17mr2104586ioa.45.1486631346955;
 Thu, 09 Feb 2017 01:09:06 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.144.139 with HTTP; Thu, 9 Feb 2017 01:09:06 -0800 (PST)
In-Reply-To: <CAKv+Gu8yDQSXadM5fUyw1yqNUKiaaosZ1E=CZ3ugiZqzBALwJw@mail.gmail.com>
References: <1486624832-15736-1-git-send-email-jiewen.yao@intel.com>
 <74D8A39837DF1E4DA445A8C0B3885C503A8EBD52@shsmsx102.ccr.corp.intel.com>
 <CAKv+Gu8yDQSXadM5fUyw1yqNUKiaaosZ1E=CZ3ugiZqzBALwJw@mail.gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Thu, 9 Feb 2017 09:09:06 +0000
Message-ID: <CAKv+Gu88s2zZeHOb-sPMbd_usgkZfEePR4kpNYZk7-VvRsRuvw@mail.gmail.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>, "Tian,
 Feng" <feng.tian@intel.com>, 
 Leif Lindholm <leif.lindholm@linaro.org>, "Kinney,
 Michael D" <michael.d.kinney@intel.com>, 
 "Fan, Jeff" <jeff.fan@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH V3 0/4] DXE Memory Protection
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Feb 2017 09:09:07 -0000
Content-Type: text/plain; charset=UTF-8

On 9 February 2017 at 08:49, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 9 February 2017 at 07:43, Yao, Jiewen <jiewen.yao@intel.com> wrote:
>> Hi Lindholm/Ard
>> This version 3 contains both of your feedback before.
>>
>> If you can do me a favor to evaluated the impact to ARM, that will be great.
>>
>
> I will take a look right away.
>

I am hitting the following assert as soon as ArmCpuDxe is loaded:

Loading driver at 0x0005BE15000 EntryPoint=0x0005BE16048 ArmCpuDxe.efi
InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 5B142398
ProtectUefiImageCommon - 0x5B142140
  - 0x000000005BE15000 - 0x0000000000010000
InstallProtocolInterface: 26BACCB1-6F42-11D4-BCE7-0080C73C8881 5BE23008
InstallProtocolInterface: AD651C7D-3C22-4DBF-92E8-38A7CDAE87B2 5BE230B0
MemoryProtectionCpuArchProtocolNotify:
ProtectUefiImageCommon - 0x5EF02400
  - 0x000000005EEC4000 - 0x0000000000042000
SetUefiImageMemoryAttributes - 0x000000005EEC4000 - 0x0000000000001000
(0x0000000000004000)
EfiAttributeToArmAttribute: 0x4000 attributes is not supported.
ASSERT [ArmCpuDxe]
/home/ard/build/uefi-next/ArmPkg/Drivers/CpuDxe/AArch64/Mmu.c(220): 0

The reason appears to be that the GCD memory descriptor retrieved in
SetUefiImageMemoryAttributes() for this region has Attributes == 0

I am digging further ...