From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B80D922280C22 for ; Wed, 27 Dec 2017 00:49:44 -0800 (PST) Received: by mail-io0-x244.google.com with SMTP id n14so11474327iob.4 for ; Wed, 27 Dec 2017 00:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=73msg87W3eJ47wgrG2K+b4ksCoAZ2g0l5wzZ8fPI8w4=; b=Q6dVIb4YAThtCZu/Ej7osmwLppfd3HEKdxBa339M0incwPmDUe+p9UipohKQzPRWRU hNTsupLVP6HZsqGHfhjZDGfs0NwVOhYatFyTlql4+Ngj1SLIRV94v55HgVXRjQP8PAbT xW7COWNS9VOc1akDz/UTuYnlm/rtnTQ1qNdPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=73msg87W3eJ47wgrG2K+b4ksCoAZ2g0l5wzZ8fPI8w4=; b=DQ+UILozvI/ggft7yrEsJ5H+sMnjvwZVfi0GaeDTXEWI2otvfgRLYcbpwtamniJp1i zCsLQKS1XkuuURVhNmsWr+GShxP/5OpIsghecjDN9mAiA/dKVNsEr/djtoBdt3sQew+H Xu5az2YM87/Xw+t2O1vAPL3BWZHTFzodNkfphZIKF9/mFlBVOQOklYcwxrp/mn5zrP0k Ven3vLVt1j3PKGTe8HwvfKW8Dk6HJmGdZNvyk4xw9LdzvrdkHflLbs7YIaAogMiTimsz EnMRapYtWHqVNcg+cq5bS56EdBPhCeJHdLPDmpeWQ2Adwmi+i993gMpoEgHXKQkcTuny H9KQ== X-Gm-Message-State: AKGB3mJneeWMXLBDte+KtvCSleMLp2yai/LiiiBx3uLP2KJl0X4lUuHS Q0xY0SAPrnK62oFRlCvHwWcfsrlCks6WMclFxDSW4/Pr+ZI= X-Google-Smtp-Source: ACJfBouphcbwJKciKe5ZQT37bjhMH+i8Gq1DI7LuvAebrfuwquIZ2Hz1QlKZ+vq91GbWPcWl5RzU1ZSI+Ifovjt1lSI= X-Received: by 10.107.151.142 with SMTP id z136mr37252986iod.248.1514364879102; Wed, 27 Dec 2017 00:54:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Wed, 27 Dec 2017 00:54:38 -0800 (PST) In-Reply-To: References: <20171227080522.10388-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Wed, 27 Dec 2017 08:54:38 +0000 Message-ID: To: "Long, Qin" Cc: "edk2-devel@lists.01.org" , "Ye, Ting" Subject: Re: [PATCH] CryptoPkg/OpensslLib AARCH64: suppress format string warning X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Dec 2017 08:49:45 -0000 Content-Type: text/plain; charset="UTF-8" On 27 December 2017 at 08:53, Long, Qin wrote: > Thanks, Ard. > Reviewed-by: Long Qin > Thanks. Pushed as 08ba82934ebd > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel > Sent: Wednesday, December 27, 2017 4:05 PM > To: edk2-devel@lists.01.org; Long, Qin ; Ye, Ting > Cc: Ard Biesheuvel > Subject: [edk2] [PATCH] CryptoPkg/OpensslLib AARCH64: suppress format string warning > > On GCC Build: openssl-1.1.0g introduced one additional build warning: > ...\openssl\crypto\asn1\x_int64.c:105:32: error: format '%ld' expects > argument of type 'long int', but argument 3 has type 'int64_t > {aka long long int}' [-Werror=format=] return BIO_printf(out, "%"BIO_PRI64"d\n", **(int64_t **)pval); > ^ > Add "-Wno-error=format" to GCC build flags to suppress this warning, since we have no real printf usage in BaseCryptLib, and BIO_printf() was already wrapped as a dummy implementation in CryptoPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- > CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 5302ad7fb5ef..602953eefff7 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > @@ -560,7 +560,7 @@ [BuildOptions] > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS > GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) > - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) > + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format > > # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: > # 1295: Deprecated declaration - give arg types diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > index 0c7f9e9e66f4..f697243f9787 100644 > --- a/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > +++ b/CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > @@ -521,7 +521,7 @@ [BuildOptions] > GCC:*_*_X64_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format -DNO_MSABI_VA_FUNCS > GCC:*_*_IPF_CC_FLAGS = -U_WIN32 -U_WIN64 $(OPENSSL_FLAGS) -Wno-error=maybe-uninitialized -Wno-error=format > GCC:*_*_ARM_CC_FLAGS = $(OPENSSL_FLAGS) > - GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) > + GCC:*_*_AARCH64_CC_FLAGS = $(OPENSSL_FLAGS) -Wno-error=format > > # suppress the following warnings in openssl so we don't break the build with warnings-as-errors: > # 1295: Deprecated declaration - give arg types > -- > 2.11.0 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel