From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BAA9522361E78 for ; Thu, 8 Feb 2018 07:56:55 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id e1so7009885ita.0 for ; Thu, 08 Feb 2018 08:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IyDE12wTUApDCl4lgxORHkKOpJVYIS1hTIQaSV68rTw=; b=YwCf+N2T9zrVc73hgdYrybAdxF+oj+7n/CCfF8uB8tD+v33cv/8g1AiEIGohc+jmnQ fPzN7HgZk4KgSLtruqUyGTqG1SnAXkt4VvzIuXu9DGZ7AG6051Q8h0ajPCRp+W48vI3a RQr7MeDzEThfwVgn8WO/Xf5WtYcMvKsnuA6f8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IyDE12wTUApDCl4lgxORHkKOpJVYIS1hTIQaSV68rTw=; b=tknyTMoe9XJu/hsoCyynp6KyimYFa4ms8dZLD4D7JH7YJwm/y4DATzLSA+bcoqCf63 /biIO5cRg8KyJPH+wPrIWzu4bvAO865oM6e/u4zCUoMPfdomvlxLNCVGw0ari1uyamMu ePfq/D3ye/PeRo9sAIczQxRvh9se9XiSHb3hDI/Fhba29k3xV8d7ekeN1TO6P6AkYiVZ sCvv0FPSvxToClTO6pxsefChpJIjf0H3NwU/WBmOmYF4pIauaHhKJ6umOYqtcqiItGxz RHJB9+GdUqaIEdc/SI0lOZJ606K79KxCjlEB/IIw644B6aIR6J6ArrGzfwGyOZU7kDl2 pvhg== X-Gm-Message-State: APf1xPAu3gGp3O3AFi7yqeXv4svIOfp420wXbUTpAh7BDF93/NIidpgu 3Sso/+FZJyKuQHTQ1gK8ZYwD2QojZoTwmASlpTM3hQ== X-Google-Smtp-Source: AH8x225MBAy3rjlgZHshWmDUndFfJCKFSQC6jLkH+nMMf1jUfMbLdAuB02ZA9BJUsUJPBGxQynzix2xVSxZIqtQsml4= X-Received: by 10.36.39.215 with SMTP id g206mr1965588ita.17.1518105759986; Thu, 08 Feb 2018 08:02:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Thu, 8 Feb 2018 08:02:39 -0800 (PST) In-Reply-To: References: <1517819152-20583-1-git-send-email-haojian.zhuang@linaro.org> <20180206172956.buzy2wyiionbugxt@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 8 Feb 2018 16:02:39 +0000 Message-ID: To: Haojian Zhuang Cc: Leif Lindholm , "edk2-devel@lists.01.org" , Linaro UEFI Mailman List , Heyi Guo Subject: Re: [edk2-platforms][PATCH] Platform/Hisilicon/HiKey960: add skeleton of HiKey960 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 15:56:56 -0000 Content-Type: text/plain; charset="UTF-8" On 8 February 2018 at 16:01, Haojian Zhuang wrote: > On 7 February 2018 at 01:29, Leif Lindholm wrote: >> On Mon, Feb 05, 2018 at 04:25:52PM +0800, Haojian Zhuang wrote: >>> Add skeleton of HiKey960 platform. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Haojian Zhuang >>> --- >>> Platform/Hisilicon/HiKey960/HiKey960.dsc | 457 +++++++++++++++++++++ >>> Platform/Hisilicon/HiKey960/HiKey960.fdf | 343 ++++++++++++++++ >>> .../HiKey960/Library/HiKey960Lib/HiKey960.c | 144 +++++++ >>> .../HiKey960/Library/HiKey960Lib/HiKey960Helper.S | 52 +++ >>> .../HiKey960/Library/HiKey960Lib/HiKey960Lib.inf | 47 +++ >>> .../HiKey960/Library/HiKey960Lib/HiKey960Mem.c | 167 ++++++++ >>> 6 files changed, 1210 insertions(+) >>> create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.dsc >>> create mode 100644 Platform/Hisilicon/HiKey960/HiKey960.fdf >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960.c >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Helper.S >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Lib.inf >>> create mode 100644 Platform/Hisilicon/HiKey960/Library/HiKey960Lib/HiKey960Mem.c >>> >> >> (I would be even happier if you could break the common parts of >> Hikey/Hikey960 descriptions into a common .dsc, like the d02,3,5 >> platforms do with Silicon/Hisilicon/Hisilicon.dsc.inc.) >> > > Hi Leif, > > I met an issue that blocks me. Hisilicon.dsc.inc makes use of dynamic > PCD value on PcdPlatformBootTimeOut. > And this PCD value is expected to store in variable storage device. As you know, > we haven't enabled variable storage device on HiKey yet. > > This one makes UEFI hang on HiKey. > Can't you just redeclare it as fixed in your .DSC ?