From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.12436.1582886726115211493 for ; Fri, 28 Feb 2020 02:45:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=bfN1+/CO; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id m16so2349156wrx.11 for ; Fri, 28 Feb 2020 02:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s11e0dYm2MMmcCwQQ7n7lmCLgPZsxiymgrSoRMXFiHk=; b=bfN1+/COrkZkiUezo3kVx5IXXomiT9yr9dKyXH5uh7yDO+X4Xx8mRmNlECzSBYUbG3 XYLtytBe/XmdhDdwtteLEb1EkiELCZBd6ee64fhk93FxsbOnucgztbFkRzuk+c6kml01 Ymyup6KFq4oo0nnemlsdIiIIa45iB+VO/wcjVE3r3o6lUMMdScuGdptLTWXW67H8DHfi k9m5ISgMF3eCtR4YceC3PvdssTS9sCImejV9sxmsxXK4yxONonodKqD5DRvkyIwBbISQ bsHPBimeDOgWqzGPWrwv4aji6LUVKZ3rCjNL1ktblgwH6nS6Do5ov4s7aPHduH2gMWOq MlXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s11e0dYm2MMmcCwQQ7n7lmCLgPZsxiymgrSoRMXFiHk=; b=TCNTiS8Ozr1OT92LnB49HAsA9+ZlfgqZT6Kr8i15cJ5gRDxB88OZeWsUxd95PolTbf XlWR7tmVGa7JDES2nsSBvZFreSVYXP6FzTCIBiUJnP62EFzgnyxteltEXl2Yd3LJl2kb imqRTxb24avkEzfY3I/Dp+6hrxrbVhJd5x+VuhQPREeruJQx6xKkGlRp4xrpilFosZoH pWoTovFX4KI9tEnOZjbWwQjsFQ4ZNNpej1Vlac9609whiG3w6wuIcimwajAymjhoECay 6xlHfHvMq4BjtOtiX+/JdD8zLNGwh8mtHjAAC+5xxY9sGvl0S6lRt4MyJaVG2tcYLg4s oXJQ== X-Gm-Message-State: APjAAAWWYpfFOiDUH/6g5YpIkibJcydAcyh4VBpcrJ7ibkElsX4oqK6A AxSUhCkOGvFLg8KiKX7xl54mab/47JZU7eJJwkR1aQ== X-Google-Smtp-Source: APXvYqx+h0ByZ74j6Wp595IG5hHW11k4TkRQ4eG5bHbffdGZGzC1FgGjGBlwYnLGWXmnkvAN/9mRnOOZT3Y8Q31/erM= X-Received: by 2002:a5d:5188:: with SMTP id k8mr4241159wrv.151.1582886724546; Fri, 28 Feb 2020 02:45:24 -0800 (PST) MIME-Version: 1.0 References: <20200228103855.11352-1-pete@akeo.ie> <20200228103855.11352-5-pete@akeo.ie> In-Reply-To: <20200228103855.11352-5-pete@akeo.ie> From: "Ard Biesheuvel" Date: Fri, 28 Feb 2020 11:45:13 +0100 Message-ID: Subject: Re: [edk2-platforms][PATCH 04/15] Silicon/BcmGenet: Add missing I/O mapping length and clean up To: Pete Batard Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Fri, 28 Feb 2020 at 11:39, Pete Batard wrote: > > Remove unneeded extra parenthesis on PCD, which can cause problems > when used with ACPI ASL macros and add an [Includes] section to the > .inf, so that the Genet.h header can be referenced where required. > > Signed-off-by: Pete Batard > --- > Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h | 3 ++- > Silicon/Broadcom/Drivers/Net/BcmNet.dec | 3 +++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h > index 4a3827c0e0d1..f56fb2977422 100644 > --- a/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h > +++ b/Silicon/Broadcom/Drivers/Net/BcmGenetDxe/Genet.h > @@ -11,7 +11,8 @@ > > #include > > -#define GENET_BASE_ADDRESS (FixedPcdGet64 (PcdBcmGenetRegistersAddress)) > +#define GENET_BASE_ADDRESS FixedPcdGet64 (PcdBcmGenetRegistersAddress) > +#define GENET_LENGTH 0x00010000 > > #define GENET_SYS_RBUF_FLUSH_CTRL 0x0008 > #define GENET_UMAC_MAC0 0x080c > diff --git a/Silicon/Broadcom/Drivers/Net/BcmNet.dec b/Silicon/Broadcom/Drivers/Net/BcmNet.dec > index 2a8688cb09a7..483b033af51c 100644 > --- a/Silicon/Broadcom/Drivers/Net/BcmNet.dec > +++ b/Silicon/Broadcom/Drivers/Net/BcmNet.dec > @@ -12,6 +12,9 @@ [Defines] > PACKAGE_GUID = 34E19823-D23A-41AB-9C09-ED1225B32DFF > PACKAGE_VERSION = 1.0 > > +[Includes] > + . > + This looks fishy. Won't this cause *every* module that incorporates this .dec to add . to its include path? > [Guids] > gBcmNetTokenSpaceGuid = {0x12b97d70, 0x9149, 0x4c2f, {0x82, 0xd5, 0xad, 0xa9, 0x1e, 0x92, 0x75, 0xa1}} > > -- > 2.21.0.windows.1 >