From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::232; helo=mail-it0-x232.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x232.google.com (mail-it0-x232.google.com [IPv6:2607:f8b0:4001:c0b::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3078E2210D9F2 for ; Fri, 23 Mar 2018 20:46:20 -0700 (PDT) Received: by mail-it0-x232.google.com with SMTP id c1-v6so4916393itj.1 for ; Fri, 23 Mar 2018 20:52:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=JIOHbvuG/xubi6MC4N9GoqWAq4E6G8Yw+gJ5seO+Rh8=; b=EZ1DrbembpMIKgYJdzJt3VHx+e4YDf3/B2/GXS7L27Zn+ym+ur6NjFbR4e7UL46tzz s4GiMUuqWa8LKo3Ke4qjoq9cfhzIXtX92wgkylohNx6lfDorStOtq62a64nCb6b5w7Fw THUNlRWsu8mqRr90kcjG0odmAXIxIPx/KQwK4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=JIOHbvuG/xubi6MC4N9GoqWAq4E6G8Yw+gJ5seO+Rh8=; b=hBUBtJ/15Da8Vy6dt88qloCMy1m+0YddqLfOKnHql3SyKCmlBgXFaUnSjw2FMql45k ndshrA4WH86BdUfzTfINA66ejMr0QvCSLIBPIB8pNWLwWZLBBIjg5XaNdv0AZTgvT/0u WeBY0s6kz2/LiHlq4d/Z0PztCHQ7TnWw9kJ0g2+ggityBW5iq8JvORTUuqQcAyPuwTYJ z7IoywmzMrANNtlrdE03nNmi8nUJBoF/phCf+bO2dOgfB0bvoP3KpXJr9QIdR5qrHK0w FsV9wuskmTX4Nxc1MUZVXCesVfDwOsmQzexvq23LEeoiekul7jR15QzbxSBlaGCTCERj t2Hg== X-Gm-Message-State: AElRT7GvVdhdmbZBXmNRoSyiTY0cfRUqNdgVVp6/2z4pfaMkjYgmQJxt EqVSclUWN6N/lim29T0JZxzhouOhTFzsRnidy4zsHQ== X-Google-Smtp-Source: AG47ELsvBQ1pgIt+ZA9pOqDbsSGbyTQoavspk2oHC4fsyN0S+8fvV2qH1khxOYRaVUGlTYELAXN+R/k2YYui3gVr0IU= X-Received: by 2002:a24:d98d:: with SMTP id p135-v6mr15595516itg.106.1521863573403; Fri, 23 Mar 2018 20:52:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Fri, 23 Mar 2018 20:52:53 -0700 (PDT) In-Reply-To: <20180323215714.27542-1-lersek@redhat.com> References: <20180323215714.27542-1-lersek@redhat.com> From: Ard Biesheuvel Date: Sat, 24 Mar 2018 03:52:53 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Rocky , Ruiyu Ni Subject: Re: [PATCH] OvmfPkg/QemuVideoDxe: handle invalid BltOperation gracefully X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2018 03:46:21 -0000 Content-Type: text/plain; charset="UTF-8" On 23 March 2018 at 21:57, Laszlo Ersek wrote: > According to the UEFI spec, EFI_GRAPHICS_OUTPUT_PROTOCOL.Blt() is supposed > to catch an invalid BltOperation, and report it with > EFI_INVALID_PARAMETER. > > Remove the assertion from QemuVideoGraphicsOutputBlt() that prevents this > from working in NOOPT and DEBUG builds. > > Cc: Ard Biesheuvel > Cc: Rocky > Cc: Ruiyu Ni > Reported-by: Rocky > Analyzed-by: Ruiyu Ni > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=897 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > > Notes: > Repo: https://github.com/lersek/edk2.git > Branch: qemuvideo_invalid_bltop > > OvmfPkg/QemuVideoDxe/Gop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/QemuVideoDxe/Gop.c b/OvmfPkg/QemuVideoDxe/Gop.c > index b479d24a8763..d51efc2a83d5 100644 > --- a/OvmfPkg/QemuVideoDxe/Gop.c > +++ b/OvmfPkg/QemuVideoDxe/Gop.c > @@ -366,7 +366,7 @@ Returns: > > default: > Status = EFI_INVALID_PARAMETER; > - ASSERT (FALSE); > + break; > } > > gBS->RestoreTPL (OriginalTPL); > -- > 2.14.1.3.gb7cf6e02401b >