From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=mTdjTxzW; spf=pass (domain: linaro.org, ip: 209.85.166.65, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by groups.io with SMTP; Fri, 07 Jun 2019 06:16:03 -0700 Received: by mail-io1-f65.google.com with SMTP id h6so1374883ioh.3 for ; Fri, 07 Jun 2019 06:16:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gR2CzlpPzybIZIMGSsGAbJ7oO/U/Rqqh8aQ82OJwWgA=; b=mTdjTxzWEwxh+WPEAPrsUZyjTICMBZOAN9q0CZKCIT4PBXfpx/GOm4FVhGAKW09jvz 9kChDdFq/sGttP5zImzXugDEdPfprIoyVGGbrbQyaHlfGRs3EoC4F99ggBA9IV23QPMO NxO1nFECfT92OpKuQYE4OHwd7S60RJmNhRi6LvsHtDrTBsbnEYQk0abChyhHEYDgnFch Ny+xrMri98tTWeaVCbqeEwBSIfDEWBh7dRheYvhIh/IPbeEJVY0T9V+tzJIrWk7Z6yMY lvBRowjCAltgjBY/CG+F6CnpXH41jxjfN1KTxIer7lsSH1rkQ0druc8LEJgxJdmfGeZD 41zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gR2CzlpPzybIZIMGSsGAbJ7oO/U/Rqqh8aQ82OJwWgA=; b=eohVjXKBBlz44EK2wjqqKtJaQMuJ6+VNi1fnD3Kdgv93J/ECaHokdjONNnBpCumYNb 2wqLLju3esioW4bg14P1u8ZwMVjNPX/Hu7FKPus0EHPh5ZfpqvEt9hybg6Ba5ci+lCwg XzOyDhUbIPoHQRqwG1LtTkvDCB026qE3NZQaQIz7zIzj6QCiUARyIUfZoBmnm3Rxdefj x45YcEh27kk7rH9edDoGWg5eMbzN+qyT2SzjcScbYPZw6uAM2Glo2tbH1/0q5RRpkuKD rVXIe/RE9q30DKGjI4C8+8SIvlYISzaFZjnr3Dqm0AABElcJzuA6t5ahWfU+gDDULM2g Pw9Q== X-Gm-Message-State: APjAAAUTPAnukWwsITqkBwh6latR0ltvvhb1+VYoJHSEyvbwrGvYl+Ti jLcg4LiQYegHOh20fxmsRwD86/w9cWQ9J0mWM2YqTA== X-Google-Smtp-Source: APXvYqxfUWvYOt8A2HgtDJVTPwZvdjd3yqn4bMwYvbkculAglv7oN+B4ySGK8FRF1SFTEw34NhsWkNZNbj64apEY14E= X-Received: by 2002:a5d:9d83:: with SMTP id 3mr29581071ion.65.1559913362178; Fri, 07 Jun 2019 06:16:02 -0700 (PDT) MIME-Version: 1.0 References: <1559913090-27760-1-git-send-email-mw@semihalf.com> In-Reply-To: <1559913090-27760-1-git-send-email-mw@semihalf.com> From: "Ard Biesheuvel" Date: Fri, 7 Jun 2019 15:15:50 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Replace unused compatible string in ACPI UART node To: Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin Content-Type: text/plain; charset="UTF-8" On Fri, 7 Jun 2019 at 15:11, Marcin Wojtas wrote: > > Linux FWTS test of the ARM SBSA compliance suite > fail on using unsupported _CID in UART node. Instead of > removing, replace _HID to unique one ("MRVL0001") and > match the driver via _CID ("HISI0031"). > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel Pushed as 1098e7ec3ee9..52f5e8d1abdf > --- > Changelog: > v1->v2 > - Use "HISI0031" as _CID and change _HID to "MRVL0001" > - Reflect the change in the commit message > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 4 ++-- > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 4 ++-- > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl > index 90b191b..5bac76a 100644 > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl > @@ -102,8 +102,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3) > > Device (COM1) > { > - Name (_HID, "HISI0031") // _HID: Hardware ID > - Name (_CID, "8250dw") // _CID: Compatible ID > + Name (_HID, "MRVL0001") // _HID: Hardware ID > + Name (_CID, "HISI0031") // _CID: Compatible ID > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > { > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl > index 5c060a3..e373d46 100644 > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl > @@ -146,8 +146,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3) > > Device (COM1) > { > - Name (_HID, "HISI0031") // _HID: Hardware ID > - Name (_CID, "8250dw") // _CID: Compatible ID > + Name (_HID, "MRVL0001") // _HID: Hardware ID > + Name (_CID, "HISI0031") // _CID: Compatible ID > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > { > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > index f7cffb9..7e9e361 100644 > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > @@ -145,8 +145,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3) > > Device (COM1) > { > - Name (_HID, "HISI0031") // _HID: Hardware ID > - Name (_CID, "8250dw") // _CID: Compatible ID > + Name (_HID, "MRVL0001") // _HID: Hardware ID > + Name (_CID, "HISI0031") // _CID: Compatible ID > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address > Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings > { > -- > 2.7.4 >