* [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Replace unused compatible string in ACPI UART node
@ 2019-06-07 13:11 Marcin Wojtas
2019-06-07 13:15 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Wojtas @ 2019-06-07 13:11 UTC (permalink / raw)
To: devel; +Cc: leif.lindholm, ard.biesheuvel, mw, jsd, jaz, kostap
Linux FWTS test of the ARM SBSA compliance suite
fail on using unsupported _CID in UART node. Instead of
removing, replace _HID to unique one ("MRVL0001") and
match the driver via _CID ("HISI0031").
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas <mw@semihalf.com>
---
Changelog:
v1->v2
- Use "HISI0031" as _CID and change _HID to "MRVL0001"
- Reflect the change in the commit message
Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 4 ++--
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 4 ++--
Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
index 90b191b..5bac76a 100644
--- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
+++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
@@ -102,8 +102,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
Device (COM1)
{
- Name (_HID, "HISI0031") // _HID: Hardware ID
- Name (_CID, "8250dw") // _CID: Compatible ID
+ Name (_HID, "MRVL0001") // _HID: Hardware ID
+ Name (_CID, "HISI0031") // _CID: Compatible ID
Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
index 5c060a3..e373d46 100644
--- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
+++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
@@ -146,8 +146,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
Device (COM1)
{
- Name (_HID, "HISI0031") // _HID: Hardware ID
- Name (_CID, "8250dw") // _CID: Compatible ID
+ Name (_HID, "MRVL0001") // _HID: Hardware ID
+ Name (_CID, "HISI0031") // _CID: Compatible ID
Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
index f7cffb9..7e9e361 100644
--- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
+++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
@@ -145,8 +145,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
Device (COM1)
{
- Name (_HID, "HISI0031") // _HID: Hardware ID
- Name (_CID, "8250dw") // _CID: Compatible ID
+ Name (_HID, "MRVL0001") // _HID: Hardware ID
+ Name (_CID, "HISI0031") // _CID: Compatible ID
Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Replace unused compatible string in ACPI UART node
2019-06-07 13:11 [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Replace unused compatible string in ACPI UART node Marcin Wojtas
@ 2019-06-07 13:15 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2019-06-07 13:15 UTC (permalink / raw)
To: Marcin Wojtas
Cc: edk2-devel-groups-io, Leif Lindholm, Jan Dąbroś,
Grzegorz Jaszczyk, Kostya Porotchkin
On Fri, 7 Jun 2019 at 15:11, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Linux FWTS test of the ARM SBSA compliance suite
> fail on using unsupported _CID in UART node. Instead of
> removing, replace _HID to unique one ("MRVL0001") and
> match the driver via _CID ("HISI0031").
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as 1098e7ec3ee9..52f5e8d1abdf
> ---
> Changelog:
> v1->v2
> - Use "HISI0031" as _CID and change _HID to "MRVL0001"
> - Reflect the change in the commit message
>
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 4 ++--
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 4 ++--
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> index 90b191b..5bac76a 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> @@ -102,8 +102,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
>
> Device (COM1)
> {
> - Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> + Name (_HID, "MRVL0001") // _HID: Hardware ID
> + Name (_CID, "HISI0031") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> index 5c060a3..e373d46 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> @@ -146,8 +146,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
>
> Device (COM1)
> {
> - Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> + Name (_HID, "MRVL0001") // _HID: Hardware ID
> + Name (_CID, "HISI0031") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index f7cffb9..7e9e361 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -145,8 +145,8 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
>
> Device (COM1)
> {
> - Name (_HID, "HISI0031") // _HID: Hardware ID
> - Name (_CID, "8250dw") // _CID: Compatible ID
> + Name (_HID, "MRVL0001") // _HID: Hardware ID
> + Name (_CID, "HISI0031") // _CID: Compatible ID
> Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _ADR: Address
> Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-07 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-07 13:11 [edk2-platforms: PATCH v2] Marvell/Armada7k8k: Replace unused compatible string in ACPI UART node Marcin Wojtas
2019-06-07 13:15 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox