From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-it0-x235.google.com (mail-it0-x235.google.com
 [IPv6:2607:f8b0:4001:c0b::235])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 198221A1E1E
 for <edk2-devel@ml01.01.org>; Wed,  3 Aug 2016 03:00:16 -0700 (PDT)
Received: by mail-it0-x235.google.com with SMTP id u186so294007402ita.0
 for <edk2-devel@ml01.01.org>; Wed, 03 Aug 2016 03:00:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=MrPaR1DKGToFng1vBtPTvZnG69J3lcCZfqb8DJUSoJk=;
 b=KdByd3rR9F9pNA5Sr1yZGQ7X6D77RXfanBl4AfAG+tg3x16NxP6L8NgysiRIzQVgw9
 zRNCkNIs3tcQCAjGMgdtQLRzKm5rHDhuujBOJB44ham5ajR5RDxl5OuGDLk8IJXK10x+
 0lstRFkjuCF7NB43LtWL8Dt9vwBEJV8dx9DNA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=MrPaR1DKGToFng1vBtPTvZnG69J3lcCZfqb8DJUSoJk=;
 b=ehgTXi1VgRJffbyqG3deB8bEVuCxQrXvdMraAbnKt8yb00wkJD3RJdFXtjFfQ7aBOp
 flJEsqHgQx2wk6f3mkEqa4xAMcImEIbLPwN2PqaBBPeygmM1O8n6Bpx3B1bdcXiHvXnD
 6fQ/+duvuu9fGSmhh6pAo0ew3hsbsYcdje2tGoNK/DCB7+5EBF0FwrQbuXhaLfUozFBu
 ld2KzMRnZkgOKjNDCzuAKE23mqBSuoOUPxjG/kok5dUkzLKv3gdSL1I9qZGC6kEaSrXD
 /FUP8f/tr5H/TtMDPISyRlP/q8fsMMMYolZySU8OLZOOh6J73rjW9paScQ0U6Q3JvHOK
 fGog==
X-Gm-Message-State: AEkoouuFwiAizire8xGmIJew2UG0XO7tHtkcvhjzr5GvEdMd6+fjlsgO8MxFT7c+2ZurkF07Ut8Tw1flrJRvQG5x
X-Received: by 10.36.25.144 with SMTP id b138mr18835486itb.29.1470218415313;
 Wed, 03 Aug 2016 03:00:15 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.36.204.195 with HTTP; Wed, 3 Aug 2016 03:00:14 -0700 (PDT)
In-Reply-To: <7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com>
References: <1470212464-28071-1-git-send-email-ard.biesheuvel@linaro.org>
 <1470212464-28071-2-git-send-email-ard.biesheuvel@linaro.org>
 <7ab6eb2f-30d8-a3b1-071e-b407c4a9fd3b@redhat.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Wed, 3 Aug 2016 12:00:14 +0200
Message-ID: <CAKv+Gu8B4fFf9Kz_SbomqDr-xF-BPr=x+mfRPJF0kSxDhJcY1Q@mail.gmail.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
 Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 1/2] EmbeddedPkg: make PrePiMemoryAllocationLib a SEC type library
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2016 10:00:16 -0000
Content-Type: text/plain; charset=UTF-8

On 3 August 2016 at 11:56, Laszlo Ersek <lersek@redhat.com> wrote:
> On 08/03/16 10:21, Ard Biesheuvel wrote:
>> This library is only used by the various PrePi implementations, all of
>> which are of type SEC.
>
> You can actually enforce that client module type restriction, by setting
>
>     LIBRARY_CLASS                  = MemoryAllocationLib|SEC
>
> Can you try that, in addition to the MODULE_TYPE change?
>
> Just an idea, of course.
>

That is a valid point, but it is kind of orthogonal to the issue I am
trying to solve.

In patch #2, I override the CC flags for SEC and BASE type modules,
but this static library gets build with the PEIM rules in effect, so I
don't really mind if anyone uses this module elsewhere. I could
perhaps simply change the type to BASE as well.