From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC2961A1E12 for ; Mon, 1 Aug 2016 05:11:00 -0700 (PDT) Received: by mail-io0-x230.google.com with SMTP id m101so180665819ioi.2 for ; Mon, 01 Aug 2016 05:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=/liJx2abOauFTbvA5cBA+9ai/OYbDsPyxVi9/q+RTDs=; b=eZCfhpomTFyFsnHCb6fQYYp8ucSNYM4rXL8WhCOkViuGDfrWYOYH7r99dCJZvTXr3h pxBofD/tcLgCofdmzomOTFdvqDocPtpVr/s/HXBohHIRjcOKgXuV00F3DM/04iEXcIaI j2NYPsKvJGbk1nFMLVD692S7E9NcMaaehkGNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/liJx2abOauFTbvA5cBA+9ai/OYbDsPyxVi9/q+RTDs=; b=Ofd70yf63LyXB9JqvjhQKn3iC/Zbrano5YC1BDhYoWByxFiu4XNkXPZLVlxLPFH/1L 9WD9BN6PQJ6iXLE9r0tiC8g9GmS2otQ7WIWaE0jKF1J3Kjb/jN8C1AwUiFodsGW5DvBe k26rbD1/tBr6iNKnul4MfAYw5q8tDTbRv7DL9jE42zAVYlVJ8cB3qbzGgmFexVwAHwhP isXu58E1yealchrmMrLFkR+Jb0LyoYHNaK/Mc6Nt2JjheukkumnQ0oLsSSk+NZs6QsdU 0nHoXFHBtngzpzvqw/olVnF/RMFiDiYNV4QD4cW0SeP43cJOPGaS+ZBLuDq/XY0kK2Kx 8Axg== X-Gm-Message-State: AEkoouu4+B8UdvK0PYi6xDZJ3zSqaw83C6+Jf8vF1uTtDxE8c61kwRs36Qxc8c0/eLG0S3vTJSUcMX9D2t+HL1MR X-Received: by 10.107.41.67 with SMTP id p64mr53331373iop.130.1470053460093; Mon, 01 Aug 2016 05:11:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Mon, 1 Aug 2016 05:10:59 -0700 (PDT) In-Reply-To: <1469833592-25559-1-git-send-email-supreeth.venkatesh@arm.com> References: <1469833592-25559-1-git-send-email-supreeth.venkatesh@arm.com> From: Ard Biesheuvel Date: Mon, 1 Aug 2016 14:10:59 +0200 Message-ID: To: Supreeth Venkatesh Cc: edk2-devel-01 , Leif Lindholm , john.powell@arm.com Subject: Re: [PATCH] ArmPkg/Library: Add ArmReadSctlr for aarch64 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Aug 2016 12:11:01 -0000 Content-Type: text/plain; charset=UTF-8 On 30 July 2016 at 01:06, Supreeth Venkatesh wrote: > One of the UEFI Self Certification tests (UEFI-SCT) need to read the > current exception level SCTLR Register. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: John Powell > Signed-off-by: Supreeth Venkatesh > --- Thanks for the patch. I don't think mentioning the UEFI-SCT here makes any sense, since the function is defined in ArmLIb.h, and simply missing from the AARCH64 implementation. I fixed this up when applying (07783fdd67e4) Thanks, Ard. > ArmPkg/Library/ArmLib/Common/AArch64/ArmLibSupport.S | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/ArmLib/Common/AArch64/ArmLibSupport.S b/ArmPkg/Library/ArmLib/Common/AArch64/ArmLibSupport.S > index a6fd5e3..c9f3bd1 100644 > --- a/ArmPkg/Library/ArmLib/Common/AArch64/ArmLibSupport.S > +++ b/ArmPkg/Library/ArmLib/Common/AArch64/ArmLibSupport.S > @@ -1,7 +1,7 @@ > #------------------------------------------------------------------------------ > # > # Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> -# Copyright (c) 2011 - 2014, ARM Limited. All rights reserved. > +# Copyright (c) 2011 - 2016, ARM Limited. All rights reserved. > # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > @@ -39,6 +39,7 @@ GCC_ASM_EXPORT (ArmCallWFE) > GCC_ASM_EXPORT (ArmCallSEV) > GCC_ASM_EXPORT (ArmReadCpuActlr) > GCC_ASM_EXPORT (ArmWriteCpuActlr) > +GCC_ASM_EXPORT (ArmReadSctlr) > > #------------------------------------------------------------------------------ > > @@ -205,4 +206,13 @@ ASM_PFX(ArmWriteCpuActlr): > isb > ret > > +ASM_PFX(ArmReadSctlr): > + EL1_OR_EL2_OR_EL3(x1) > +1:mrs x0, sctlr_el1 > + ret > +2:mrs x0, sctlr_el2 > + ret > +3:mrs x0, sctlr_el3 > +4:ret > + > ASM_FUNCTION_REMOVE_IF_UNREFERENCED > -- > 2.8.0 >