From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3B81721CF3B7F for ; Mon, 3 Jul 2017 08:02:23 -0700 (PDT) Received: by mail-it0-x22a.google.com with SMTP id m68so89143607ith.1 for ; Mon, 03 Jul 2017 08:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ISpq0D9n+XLHD7hQP8LVLIeKw177OJX85sJN5w5uDbk=; b=kX/6ze4McNQegvltimnuRE+XwQlgBefNb9HuNftPrZaoZ7MbEs6hABktMK9+LlXadd BImnzT9Qd4SEkUO1dCkx5k4g+7tKy4QepPKKhycUdAgKPg0x1wTx3X/9cJ1ZynJml4Bl A7UX5u/5AqElIdLdjid7R7DkbGJVIX1f0nItk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ISpq0D9n+XLHD7hQP8LVLIeKw177OJX85sJN5w5uDbk=; b=M2cgIZkuvsc4//1mtTBNQFInIU+/OUCasZwg0eaAeZE+nevqOF95E61biHb5176DQi 9O3uvx79kyUWFrkzek2i4bSF6hmOW+qrHHJnKmIrqewaJo8sN3rU0F4KXlKXu/wTMnhl C5gcLE2NHco6wm82N08DE3kA9lZbwEDUkfP1q331oyFhbddx2AN+/nJ6oKOwry9MXxpG 1zL2GLeZ2+ZxH6U60ziBVNK0Gkzs3xhPprO5QMY4B6fRoZlbMsozsHuE4unR+W7y742B RyBVYR+MMsOFx+LIFh/5OSGI2C6nF4xQ7rMvIQsVIY32nwuesfEqIsx+gkEKSd58kIsh 58yA== X-Gm-Message-State: AIVw110VWV0WL6JLKq21AktaQjgoZRFPj3m+kAkmXHWBmTx9uJRYgoRB yX/qyMq6g4qdK1A1lkNwl3EGf7Mrk9MjndIrVg== X-Received: by 10.36.9.144 with SMTP id 138mr9294371itm.98.1499094239484; Mon, 03 Jul 2017 08:03:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.134.134 with HTTP; Mon, 3 Jul 2017 08:03:58 -0700 (PDT) In-Reply-To: <20170703150238.32652-1-ard.biesheuvel@linaro.org> References: <20170703150238.32652-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Mon, 3 Jul 2017 16:03:58 +0100 Message-ID: To: "edk2-devel@lists.01.org" , Leif Lindholm Cc: Ard Biesheuvel Subject: Re: [PATCH] ArmPkg: implement ResetSystemLib using PSCI 0.2 calls X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 15:02:23 -0000 Content-Type: text/plain; charset="UTF-8" On 3 July 2017 at 16:02, Ard Biesheuvel wrote: > This adds an implementation of the ResetSystemLib library class as > defined in MdeModulePkg. It is used as the platform glue by the generic > ResetSystemRuntimeDxe which lives in the same package. > > This implementation is intended to replace the EfiResetSystemLib based > implementation that is deprecated now that we have decided that there is > no longer a reason to keep a different ResetSystem() implementation > under EmbeddedPkg. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Ard Biesheuvel > --- > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 115 ++++++++++++++++++++ > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 35 ++++++ > 2 files changed, 150 insertions(+) > > diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c > new file mode 100644 > index 000000000000..d6d26bce5009 > --- /dev/null > +++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c > @@ -0,0 +1,115 @@ > +/** @file > + ResetSystemLib implementation using PSCI calls > + > + Copyright (c) 2017, Linaro Ltd. All rights reserved.
> + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the BSD License > + which accompanies this distribution. The full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > + > +#include > + > +#include > +#include > +#include > +#include > + > +#include > + > +/** > + This function causes a system-wide reset (cold reset), in which > + all circuitry within the system returns to its initial state. This type of reset > + is asynchronous to system operation and operates without regard to > + cycle boundaries. > + > + If this function returns, it means that the system does not support cold reset. > +**/ > +VOID > +EFIAPI > +ResetCold ( > + VOID > + ) > +{ > + ARM_SMC_ARGS ArmSmcArgs; > + > + // Send a PSCI 0.2 SYSTEM_RESET command > + ArmSmcArgs.Arg0 = ARM_SMC_ID_PSCI_SYSTEM_RESET; > + ArmCallSmc (&ArmSmcArgs); > +} > + > +/** > + This function causes a system-wide initialization (warm reset), in which all processors > + are set to their initial state. Pending cycles are not corrupted. > + > + If this function returns, it means that the system does not support warm reset. > +**/ > +VOID > +EFIAPI > +ResetWarm ( > + VOID > + ) > +{ > + // Map a warm reset into a cold reset > + ResetCold (); > +} > + > +/** > + This function causes the system to enter a power state equivalent > + to the ACPI G2/S5 or G3 states. > + > + If this function returns, it means that the system does not support shutdown reset. > +**/ > +VOID > +EFIAPI > +ResetShutdown ( > + VOID > + ) > +{ > + ARM_SMC_ARGS ArmSmcArgs; > + > + // Send a PSCI 0.2 SYSTEM_OFF command > + ArmSmcArgs.Arg0 = ARM_SMC_ID_PSCI_SYSTEM_OFF; > + ArmCallSmc (&ArmSmcArgs); > +} > + > +/** > + This function causes the system to enter S3 and then wake up immediately. > + > + If this function returns, it means that the system does not support S3 feature. > +**/ > +VOID > +EFIAPI > +EnterS3WithImmediateWake ( > + VOID > + ) > +{ > + // Not implemented > +} > + > +/** > + This function causes a systemwide reset. The exact type of the reset is > + defined by the EFI_GUID that follows the Null-terminated Unicode string passed > + into ResetData. If the platform does not recognize the EFI_GUID in ResetData > + the platform must pick a supported reset type to perform.The platform may > + optionally log the parameters from any non-normal reset that occurs. > + > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData The data buffer starts with a Null-terminated string, > + followed by the EFI_GUID. > +**/ > +VOID > +EFIAPI > +ResetPlatformSpecific ( > + IN UINTN DataSize, > + IN VOID *ResetData > + ) > +{ > + // Map the platform specific reset as reboot > + ResetCold (); > +} > diff --git a/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > new file mode 100644 > index 000000000000..3e66f75a3498 > --- /dev/null > +++ b/ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > @@ -0,0 +1,35 @@ > +#/** @file > +# ResetSystemLib implementation using PSCI calls > +# > +# Copyright (c) 2017, Linaro Ltd. All rights reserved.
> +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010019 > + BASE_NAME = ArmPsciResetSystemLib Forgot to update the base name to ArmSmcPsciResetSystemLib > + FILE_GUID = 18B12C83-7718-4D83-ADA4-87F2FE698DD4 > + MODULE_TYPE = BASE > + VERSION_STRING = 1.0 > + LIBRARY_CLASS = ResetSystemLib > + > +[Sources] > + ArmSmcPsciResetSystemLib.c > + > +[Packages] > + ArmPkg/ArmPkg.dec > + MdeModulePkg/MdeModulePkg.dec > + MdePkg/MdePkg.dec > + > +[LibraryClasses] > + ArmSmcLib > + BaseLib > + DebugLib > -- > 2.9.3 >