From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BADB42219BCAF for ; Sat, 23 Dec 2017 05:19:32 -0800 (PST) Received: by mail-it0-x241.google.com with SMTP id d137so17339728itc.2 for ; Sat, 23 Dec 2017 05:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F3tZabkc0qUUK8HVEcD1N3MGRQDBuvtlGAq0/lyOwWo=; b=LVEPUxqlzaWSAqgE2vp5WX0sAvl4Nn3gYTG6M7oqNBtx8/eb/07LMDhXgG/c6uGcVQ +k4/8R/Vohvhfu4YihamZAbsaZKYK/bv/Rg+qLXTLD0xEPHD13RbpO/fZliO+INDkzXs kYb9aVlq+OZdZ3p5tcbQUzB+Z9jK+RYBSH5sw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F3tZabkc0qUUK8HVEcD1N3MGRQDBuvtlGAq0/lyOwWo=; b=ejPFDRUA0PjcMUZYwco3JBLEP1wSxJp97DTzD9kloCemiu//F9HX5HDOQY1Mz3vTDr 6TRrSjcr1KIvSar+tvjWvGbxwJ9ww17NMGg/AoR16Pe864Fsx6YlwU9FxKnJahFzNJGZ mdfFqhFdiPTof5BThwgpgWWVSFysylCHt7r0CNuKSnEHGu8lwP1z2Am9V8uHRrnWIRF0 RPTQOhVIJma2ry3JRlWZYpSD2Fc99kt/UmZKo6/E8/Y0Tw6Ppc+zOJ6W0i15A+kUwREm akTX6xHaUC3tycE0vntYHmoO21bO+3kCcVa4mJFjPqNr3kxMZEdJDIHx2QkqYCSHqvc3 fD/A== X-Gm-Message-State: AKGB3mKSk9oqBGVVDR3hKuN025Wwwbdxxc+Zc+mPbLCiEGwOfhgoCRXG KM0TKw/E3E2ykB17uIHShGPpsX9Zd7nALbi1yY8TAg== X-Google-Smtp-Source: ACJfBotRYc4QjZ/bWBmsIeVBxsgAF9gUEdBRPCVvwc38eqEZN9dzvWDXaZ/9jnLKfEWavZ7aFw9wYiXX0U7IaFpuxS0= X-Received: by 10.36.219.214 with SMTP id c205mr21478673itg.65.1514035463265; Sat, 23 Dec 2017 05:24:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Sat, 23 Dec 2017 05:24:22 -0800 (PST) In-Reply-To: <20171222183418.8616-6-evan.lloyd@arm.com> References: <20171222183418.8616-1-evan.lloyd@arm.com> <20171222183418.8616-6-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Sat, 23 Dec 2017 13:24:22 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , <"ard.biesheuvel@linaro.org"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"Matteo.Carlini@arm.com"@arm.com>, <"nd@arm.com"@arm.com> Subject: Re: [PATCH v2 05/13] ArmPlatformPkg: PL111Lcd: Replace magic number with macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Dec 2017 13:19:33 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 18:34, wrote: > From: Girish Pathak > > Minor code change, replaces magic number with macro in LCD disable. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Girish Pathak > Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > index 267c972bf795997f1df88b82acbaea5f75a7a00e..b236cbfcfffadd6fa7610dcae5c5bc748aac0f69 100644 > --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c > @@ -117,8 +117,7 @@ LcdSetMode ( > } > > // Disable the CLCD_LcdEn bit > - LcdControl = MmioRead32 (PL111_REG_LCD_CONTROL); > - MmioWrite32 (PL111_REG_LCD_CONTROL, LcdControl & ~1); > + MmioAnd32 (PL111_REG_LCD_CONTROL, ~PL111_CTRL_LCD_EN); > > // Set Timings > MmioWrite32 ( > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >